Wenbin Zhang (Gerrit)

unread,

Aug 10, 2026, 1:13:04 PM (6 days ago) Aug 10

to chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from chromium-bedrock-reviews

Wenbin Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Wenbin Zhang . resolved

PTAL. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

chromium-bedrock-reviews

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Aug 10, 2026, 1:14:41 PM (6 days ago) Aug 10

to Wenbin Zhang, chromium-bedrock-reviews, Erik Chen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Erik Chen

Message from gwsq

Reviewer source(s):
erik...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Aug 10, 2026, 1:23:06 PM (6 days ago) Aug 10

to Wenbin Zhang, Lei Zhang, chromium-bedrock-reviews, Erik Chen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Erik Chen and Wenbin Zhang

Lei Zhang added 1 comment

File chrome/browser/ui/views/extensions/extensions_toolbar_unittest.cc

Line 239, Patchset 6 (Parent): // TODO(crbug.com/40670141): Use IsActionVisibleOnToolbar() because it

Lei Zhang . unresolved

BTW, are there any TODOs for this bug remaining after this CL? If not, close out the bug when this lands?

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen
Wenbin Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Aug 10, 2026, 2:48:01 PM (6 days ago) Aug 10

to Wenbin Zhang, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Wenbin Zhang

Erik Chen voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Wenbin Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Aug 10, 2026, 4:07:41 PM (6 days ago) Aug 10

to Wenbin Zhang, Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Wenbin Zhang

Lei Zhang added 5 comments

File chrome/browser/ui/views/extensions/extensions_toolbar_browsertest.h

Line 43, Patchset 6 (Latest): const std::vector<base::test::FeatureRef>& disabled_features = {});

Lei Zhang . unresolved

Just make the caller pass in the second argument. This is all "new" code, so it's easy to make this change.

File chrome/browser/ui/views/extensions/extensions_toolbar_browsertest.cc

Line 46, Patchset 6 (Latest): // Allow unpacked extensions without developer mode for testing.

Lei Zhang . unresolved

Make this ctor delegate to the ctor below. Then move this comment over.

File chrome/browser/ui/views/extensions/extensions_toolbar_desktop_browsertest.cc

Line 34, Patchset 6 (Latest):

Lei Zhang . unresolved

No random newline in the includes list please.

Line 62, Patchset 6 (Latest): : ExtensionsToolbarBrowserTest(

Lei Zhang . unresolved

Delegate to the ctor below. Then make that ctor enable `kExtensionsMenuAccessControl` to consolidate the code for that.

Line 121, Patchset 6 (Latest):IN_PROC_BROWSER_TEST_F(ExtensionsToolbarDesktopBrowserTest, BrowserActionDragDataPickleRoundTrip) {

Lei Zhang . unresolved

Reminder (as always) to auto-format the CL. e.g. This is over 80 columns.

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 10, 2026, 4:49:16 PM (6 days ago) Aug 10

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for updated 5C

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 10, 2026, 5:08:30 PM (6 days ago) Aug 10

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Erik Chen

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for updated 5C

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Aug 10, 2026, 7:45:42 PM (6 days ago) Aug 10

to Wenbin Zhang, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Wenbin Zhang

Erik Chen voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Wenbin Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 2:18:12 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang added 6 comments

File chrome/browser/ui/views/extensions/extensions_toolbar_browsertest.h

Line 43, Patchset 6: const std::vector<base::test::FeatureRef>& disabled_features = {});

Lei Zhang . resolved

Just make the caller pass in the second argument. This is all "new" code, so it's easy to make this change.

Wenbin Zhang

Done

File chrome/browser/ui/views/extensions/extensions_toolbar_browsertest.cc

Line 46, Patchset 6: // Allow unpacked extensions without developer mode for testing.

Lei Zhang . resolved

Make this ctor delegate to the ctor below. Then move this comment over.

Wenbin Zhang

Done

File chrome/browser/ui/views/extensions/extensions_toolbar_desktop_browsertest.cc

Line 34, Patchset 6:

Lei Zhang . resolved

No random newline in the includes list please.

Wenbin Zhang

Done

Line 62, Patchset 6: : ExtensionsToolbarBrowserTest(

Lei Zhang . resolved

Delegate to the ctor below. Then make that ctor enable `kExtensionsMenuAccessControl` to consolidate the code for that.

Wenbin Zhang

Done

Line 121, Patchset 6:IN_PROC_BROWSER_TEST_F(ExtensionsToolbarDesktopBrowserTest, BrowserActionDragDataPickleRoundTrip) {

Lei Zhang . resolved

Reminder (as always) to auto-format the CL. e.g. This is over 80 columns.

Wenbin Zhang

Done

File chrome/browser/ui/views/extensions/extensions_toolbar_unittest.cc

Line 239, Patchset 6 (Parent): // TODO(crbug.com/40670141): Use IsActionVisibleOnToolbar() because it

Lei Zhang . resolved

BTW, are there any TODOs for this bug remaining after this CL? If not, close out the bug when this lands?

Wenbin Zhang

I found this bug is also associated with a couple of other tests. I have put a note and will revisit this when wrapping up the whole project. Thanks for pointing it out!

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 2:45:16 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for updated 5C rebase

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 2:53:29 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for updated 5C

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 3:33:46 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for rechained 5C

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 4:57:13 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for rechained 5C

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 5:02:54 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for updated 5C

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 11, 2026, 6:20:02 PM (5 days ago) Aug 11

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Lei Zhang

Wenbin Zhang voted Commit-Queue+1

Triggered CQ dry run for updated 5C rebase on 5B

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Aug 11, 2026, 6:32:39 PM (5 days ago) Aug 11

to Wenbin Zhang, Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Wenbin Zhang

Lei Zhang added 1 comment

File chrome/browser/ui/views/extensions/extensions_toolbar_unittest.cc

Line 239, Patchset 6 (Parent): // TODO(crbug.com/40670141): Use IsActionVisibleOnToolbar() because it

Lei Zhang . resolved

BTW, are there any TODOs for this bug remaining after this CL? If not, close out the bug when this lands?

Wenbin Zhang

I found this bug is also associated with a couple of other tests. I have put a note and will revisit this when wrapping up the whole project. Thanks for pointing it out!

Lei Zhang

Thanks for checking.

Open in Gerrit

Related details

Attention is currently required from:

Wenbin Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 14, 2026, 4:21:01 PM (2 days ago) Aug 14

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Erik Chen

Wenbin Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Wenbin Zhang (Gerrit)

unread,

Aug 14, 2026, 7:49:25 PM (2 days ago) Aug 14

to Erik Chen, Lei Zhang, chromium-bedrock-reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Erik Chen

Wenbin Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 14, 2026, 7:58:22 PM (2 days ago) Aug 14

to Wenbin Zhang, Erik Chen, Lei Zhang, chromium-bedrock-reviews, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/ui/views/extensions/extensions_toolbar_desktop_browsertest.cc
Insertions: 24, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/views/extensions/BUILD.gn
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[Bedrock] Migrate ExtensionsToolbarDesktop tests to browser tests (Part 3/3)

As part of Project Bedrock, this CL is Part 3 of a 3-part chain
migrating the large (3000+ lines across 6 files) extensions toolbar
unit test suite (ExtensionsToolbarUnitTest and derived suites) from
unit_tests to browser_tests.

Splitting into multiple browser test files improves test isolation,
maintainability, and build/execution parallelism:
- Part 1 (CL 8211444): ExtensionsToolbarBrowserTest base fixture,
  ExtensionsToolbarControlsBrowserTest,
  ExtensionsMenuButtonBrowserTest, ExtensionsMenuItemBrowserTest.
- Part 2 (CL 8219832):
  ExtensionsMenuSitePermissionsPageViewBrowserTest,
  ExtensionsMenuMainPageViewBrowserTest.
- Part 3 (This CL): ExtensionsToolbarDesktopBrowserTest (27 tests),
  and removal of obsolete ExtensionsToolbarUnitTest harness files.

during migration
BYPASS_RECITATION_REASON=Migrating existing Chromium test code from
feature_promo_controller_unittest.cc to browser_tests as part of
Project Bedrock
TAG=agy
CONV=0e2f8f65-9d3c-4886-8bb3-c908911c4a8c

Bug: 543043111

Bypass-Check-License: file renamed from unit tests to browser tests

Change-Id: Ifaaff108445e30d3592e0de8c06b4c3d945a6486

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8226585

Reviewed-by: Erik Chen <erik...@chromium.org>

Commit-Queue: Wenbin Zhang <wenbi...@google.com>

Cr-Commit-Position: refs/heads/main@{#1680028}

Files:

M chrome/browser/ui/views/extensions/BUILD.gn
M chrome/browser/ui/views/extensions/extensions_toolbar_browsertest.cc
M chrome/browser/ui/views/extensions/extensions_toolbar_browsertest.h
R chrome/browser/ui/views/extensions/extensions_toolbar_desktop_browsertest.cc
D chrome/browser/ui/views/extensions/extensions_toolbar_unittest.cc
D chrome/browser/ui/views/extensions/extensions_toolbar_unittest.h

Change size: L

Delta: 6 files changed, 202 insertions(+), 651 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Erik Chen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Bedrock] Migrate ExtensionsToolbarDesktop tests to browser tests (Part 3/3) [chromium/src : main]

Wenbin Zhang (Gerrit)

Wenbin Zhang added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Erik Chen (Gerrit)

Erik Chen voted Code-Review+1

Related details

Lei Zhang (Gerrit)

Lei Zhang added 5 comments

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Erik Chen (Gerrit)

Erik Chen voted Code-Review+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang added 6 comments

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+1

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+2

Related details

Wenbin Zhang (Gerrit)

Wenbin Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information