Site Search: Refactors existing mediators to use new base class [chromium/src : main]

0 views
Skip to first unread message

Kay Lin (Gerrit)

unread,
Mar 10, 2026, 6:50:44 AM (2 days ago) Mar 10
to chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Kay Lin has uploaded the change for review

Commit message

Site Search: Refactors existing mediators to use new base class

Part 2/2: This CL refactors existing mediators by using the newly
introduced base classes in the previous CL.
Bug: 489633787
Change-Id: Ic11a27c8d4ccd99dc5da371b228588cea4c6b15d

Change diff


Change information

Files:
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/custom_search_engine/CustomSearchEngineListMediator.java
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/custom_site_search/CustomSiteSearchMediator.java
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/extensions/ExtensionSearchEngineMediator.java
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/inactive_shortcut/InactiveShortcutMediator.java
Change size: L
Delta: 4 files changed, 83 insertions(+), 380 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic11a27c8d4ccd99dc5da371b228588cea4c6b15d
Gerrit-Change-Number: 7652354
Gerrit-PatchSet: 1
Gerrit-Owner: Kay Lin <kaiy...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Tomasz Wiszkowski (Gerrit)

unread,
Mar 11, 2026, 4:30:59 PM (20 hours ago) Mar 11
to Kay Lin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Kay Lin

Tomasz Wiszkowski voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kay Lin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic11a27c8d4ccd99dc5da371b228588cea4c6b15d
Gerrit-Change-Number: 7652354
Gerrit-PatchSet: 2
Gerrit-Owner: Kay Lin <kaiy...@google.com>
Gerrit-Reviewer: Kay Lin <kaiy...@google.com>
Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
Gerrit-Attention: Kay Lin <kaiy...@google.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 20:30:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kay Lin (Gerrit)

unread,
6:01 AM (6 hours ago) 6:01 AM
to Tomasz Wiszkowski, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Kay Lin voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic11a27c8d4ccd99dc5da371b228588cea4c6b15d
Gerrit-Change-Number: 7652354
Gerrit-PatchSet: 3
Gerrit-Owner: Kay Lin <kaiy...@google.com>
Gerrit-Reviewer: Kay Lin <kaiy...@google.com>
Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 10:00:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
6:56 AM (5 hours ago) 6:56 AM
to Kay Lin, Tomasz Wiszkowski, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Site Search: Refactors existing mediators to use new base class

Part 2/2: This CL refactors existing mediators by using the newly
introduced base classes in the previous CL.
Bug: 489633787
Change-Id: Ic11a27c8d4ccd99dc5da371b228588cea4c6b15d
Reviewed-by: Tomasz Wiszkowski <en...@google.com>
Commit-Queue: Kay Lin <kaiy...@google.com>
Cr-Commit-Position: refs/heads/main@{#1598330}
Files:
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/custom_search_engine/CustomSearchEngineListMediator.java
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/custom_site_search/CustomSiteSearchMediator.java
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/extensions/ExtensionSearchEngineMediator.java
  • M chrome/browser/search_engines/android/java/src/org/chromium/chrome/browser/search_engines/settings/inactive_shortcut/InactiveShortcutMediator.java
Change size: L
Delta: 4 files changed, 83 insertions(+), 380 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tomasz Wiszkowski
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic11a27c8d4ccd99dc5da371b228588cea4c6b15d
Gerrit-Change-Number: 7652354
Gerrit-PatchSet: 4
Gerrit-Owner: Kay Lin <kaiy...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kay Lin <kaiy...@google.com>
Gerrit-Reviewer: Tomasz Wiszkowski <en...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages