[Extensions] Separate toolbar and menu models in Desktop Android [chromium/src : main]

0 views
Skip to first unread message

Emilia Paz (Gerrit)

unread,
Mar 31, 2026, 10:15:28 PM (2 days ago) Mar 31
to Eva Su, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Attention needed from Eva Su

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Emilia Paz . resolved

Realized we can reduce the complexity on property model creation! That way each component only listens for its relevant udpates

Open in Gerrit

Related details

Attention is currently required from:
  • Eva Su
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ice50014e6a69ef8fdb200c5d855aa978f6bfff5a
Gerrit-Change-Number: 7720219
Gerrit-PatchSet: 3
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Eva Su <ev...@chromium.org>
Gerrit-Attention: Eva Su <ev...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 02:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eva Su (Gerrit)

unread,
Apr 1, 2026, 5:05:07 PM (22 hours ago) Apr 1
to Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
Attention needed from Emilia Paz

Eva Su voted and added 1 comment

Votes added by Eva Su

Code-Review+1

1 comment

Patchset-level comments
Eva Su . resolved

Thanks for improving this!

Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ice50014e6a69ef8fdb200c5d855aa978f6bfff5a
    Gerrit-Change-Number: 7720219
    Gerrit-PatchSet: 3
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Eva Su <ev...@chromium.org>
    Gerrit-Attention: Emilia Paz <emil...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 21:04:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Emilia Paz (Gerrit)

    unread,
    12:45 PM (2 hours ago) 12:45 PM
    to Eva Su, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
    Attention needed from Eva Su

    Emilia Paz added 1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Emilia Paz . resolved

    This also lost +1..

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eva Su
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ice50014e6a69ef8fdb200c5d855aa978f6bfff5a
      Gerrit-Change-Number: 7720219
      Gerrit-PatchSet: 6
      Gerrit-Owner: Emilia Paz <emil...@chromium.org>
      Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
      Gerrit-Reviewer: Eva Su <ev...@chromium.org>
      Gerrit-Attention: Eva Su <ev...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 16:44:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Eva Su (Gerrit)

      unread,
      1:07 PM (2 hours ago) 1:07 PM
      to Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com
      Attention needed from Emilia Paz

      Eva Su voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Emilia Paz
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ice50014e6a69ef8fdb200c5d855aa978f6bfff5a
        Gerrit-Change-Number: 7720219
        Gerrit-PatchSet: 6
        Gerrit-Owner: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Eva Su <ev...@chromium.org>
        Gerrit-Attention: Emilia Paz <emil...@chromium.org>
        Gerrit-Comment-Date: Thu, 02 Apr 2026 17:06:55 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Emilia Paz (Gerrit)

        unread,
        1:11 PM (2 hours ago) 1:11 PM
        to Eva Su, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, hanxi...@chromium.org, peilinwa...@google.com

        Emilia Paz voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ice50014e6a69ef8fdb200c5d855aa978f6bfff5a
        Gerrit-Change-Number: 7720219
        Gerrit-PatchSet: 6
        Gerrit-Owner: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
        Gerrit-Reviewer: Eva Su <ev...@chromium.org>
        Gerrit-Comment-Date: Thu, 02 Apr 2026 17:10:53 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages