extensions: Port tab group API unit tests to browser tests, part 7 [chromium/src : main]

0 views
Skip to first unread message

James Cook (Gerrit)

unread,
Jan 8, 2026, 4:18:46 PM (18 hours ago) Jan 8
to Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Zoraiz Naeem

James Cook added 3 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
James Cook . resolved

Zoraiz, please take a look. Thanks.

File chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Line 809, Patchset 1 (Latest):IN_PROC_BROWSER_TEST_F(TabGroupsApiBrowserTest, TabGroupsOnCreated) {
James Cook . unresolved

This is all cut/paste, with `TEST_F -> IN_PROC_BROWSER_TEST_F`, updating the test suite class name, and switching `browser_context()` to `profile()`. No functional changes.

File chrome/test/data/extensions/api_test/tab_groups/basics/background.js
Line 5, Patchset 1 (Latest):// Basic API tests for the tabGroups API. Most API behavior is tested in
James Cook . unresolved

This file is used by tab_groups_api_apitests.cc, and is an `ExtensionApiTest`, so I updated the comment.

Open in Gerrit

Related details

Attention is currently required from:
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibb82b7607c1dc69b20aae80676a59a2cb6c37905
Gerrit-Change-Number: 7415049
Gerrit-PatchSet: 1
Gerrit-Owner: James Cook <jame...@chromium.org>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 21:18:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Zoraiz Naeem (Gerrit)

unread,
Jan 8, 2026, 4:23:28 PM (18 hours ago) Jan 8
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from James Cook

Zoraiz Naeem voted and added 3 comments

Votes added by Zoraiz Naeem

Code-Review+1

3 comments

Patchset-level comments
Zoraiz Naeem . resolved

lgtm!

File chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Line 809, Patchset 1 (Latest):IN_PROC_BROWSER_TEST_F(TabGroupsApiBrowserTest, TabGroupsOnCreated) {
James Cook . resolved

This is all cut/paste, with `TEST_F -> IN_PROC_BROWSER_TEST_F`, updating the test suite class name, and switching `browser_context()` to `profile()`. No functional changes.

Zoraiz Naeem

Acknowledged

File chrome/test/data/extensions/api_test/tab_groups/basics/background.js
Line 5, Patchset 1 (Latest):// Basic API tests for the tabGroups API. Most API behavior is tested in
James Cook . resolved

This file is used by tab_groups_api_apitests.cc, and is an `ExtensionApiTest`, so I updated the comment.

Zoraiz Naeem

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • James Cook
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibb82b7607c1dc69b20aae80676a59a2cb6c37905
    Gerrit-Change-Number: 7415049
    Gerrit-PatchSet: 1
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Attention: James Cook <jame...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 21:23:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: James Cook <jame...@chromium.org>
    satisfied_requirement
    open
    diffy

    James Cook (Gerrit)

    unread,
    Jan 8, 2026, 5:07:53 PM (18 hours ago) Jan 8
    to Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    James Cook voted and added 1 comment

    Votes added by James Cook

    Commit-Queue+2

    1 comment

    Patchset-level comments
    James Cook . resolved

    Thanks for the review!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibb82b7607c1dc69b20aae80676a59a2cb6c37905
    Gerrit-Change-Number: 7415049
    Gerrit-PatchSet: 1
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 22:07:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 8, 2026, 6:02:27 PM (17 hours ago) Jan 8
    to James Cook, Zoraiz Naeem, Achuith Bhandarkar, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    extensions: Port tab group API unit tests to browser tests, part 7

    The tab groups API unit test suite provides good coverage, but uses
    concepts like Browser and BrowserWindow that are not supposed to be
    used anymore in unit tests. (See chrome browser design principles in
    //docs or the comment in this browser test file.) Converting to browser
    test both fixes this design issue and sets up the tests for future
    conversion to run on desktop Android.

    This CL cut/pastes over all the remaining tests and deletes the unit
    test file.
    Bug: 405219902
    Change-Id: Ibb82b7607c1dc69b20aae80676a59a2cb6c37905
    Reviewed-by: Zoraiz Naeem <zorai...@chromium.org>
    Commit-Queue: James Cook <jame...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1566576}
    Files:
    • M chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
    • D chrome/browser/extensions/api/tab_groups/tab_groups_api_unittest.cc
    • M chrome/test/BUILD.gn
    • M chrome/test/data/extensions/api_test/tab_groups/basics/background.js
    Change size: L
    Delta: 4 files changed, 64 insertions(+), 214 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Zoraiz Naeem
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibb82b7607c1dc69b20aae80676a59a2cb6c37905
    Gerrit-Change-Number: 7415049
    Gerrit-PatchSet: 2
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages