[Desktop Android] Enable ExtensionMultipleUninstallDialog [chromium/src : main]

0 views
Skip to first unread message

Eva Su (Gerrit)

unread,
Oct 27, 2025, 1:35:36 PM (4 days ago) Oct 27
to Tim, Emilia Paz, Chromium LUCI CQ, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz

Eva Su added 1 comment

Commit Message
Line 7, Patchset 6:[Desktop Android] Enable `ExtensionMultipleUninstallDialog` now that
it's been compiled on Desktop Android.
Tim . resolved

nit: Try to keep the title one line long.

Maybe:
[Desktop Android] Enable `ExtensionMultipleUninstallDialog`

We can enable this now that it's being compiled on Desktop Android.

Eva Su

Done, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If41357c37ee014f8bc8fa20e977f2f9b1aaadc18
Gerrit-Change-Number: 7081089
Gerrit-PatchSet: 7
Gerrit-Owner: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Emilia Paz <emil...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 17:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim <tjud...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 27, 2025, 4:21:35 PM (4 days ago) Oct 27
to Eva Su, Tim, Chromium LUCI CQ, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Eva Su

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Emilia Paz . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Eva Su
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If41357c37ee014f8bc8fa20e977f2f9b1aaadc18
Gerrit-Change-Number: 7081089
Gerrit-PatchSet: 7
Gerrit-Owner: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Eva Su <ev...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 20:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Eva Su (Gerrit)

unread,
Oct 27, 2025, 4:26:26 PM (4 days ago) Oct 27
to Emilia Paz, Tim, Chromium LUCI CQ, AyeAye, chromium-a...@chromium.org, extension...@chromium.org

Eva Su voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If41357c37ee014f8bc8fa20e977f2f9b1aaadc18
Gerrit-Change-Number: 7081089
Gerrit-PatchSet: 7
Gerrit-Owner: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 20:26:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 27, 2025, 5:52:17 PM (4 days ago) Oct 27
to Eva Su, Emilia Paz, Tim, AyeAye, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Desktop Android] Enable ExtensionMultipleUninstallDialog

We can enable this now that it's being compiled on Desktop Android.
Fixed: 434755940
Change-Id: If41357c37ee014f8bc8fa20e977f2f9b1aaadc18
Reviewed-by: Emilia Paz <emil...@chromium.org>
Reviewed-by: Tim <tjud...@chromium.org>
Commit-Queue: Eva Su <ev...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536255}
Files:
  • M chrome/browser/extensions/api/developer_private/developer_private_functions_shared.cc
Change size: S
Delta: 1 file changed, 3 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tim, +1 by Emilia Paz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If41357c37ee014f8bc8fa20e977f2f9b1aaadc18
Gerrit-Change-Number: 7081089
Gerrit-PatchSet: 8
Gerrit-Owner: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages