[EICP] Add tests for ExtensionInstallPolicyService [chromium/src : main]
0 views
Skip to first unread message
Yann Dago (Gerrit)
Jan 8, 2026, 11:02:35 AM (24 hours ago) Jan 8
to Nicolas Ouellet-Payeur, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Nicolas Ouellet-Payeur and Yann Dago
Yann Dago voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Nicolas Ouellet-Payeur
- Yann Dago
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Ouellet-Payeur (Gerrit)
Jan 8, 2026, 1:09:08 PM (22 hours ago) Jan 8
to Yann Dago, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Yann Dago
Nicolas Ouellet-Payeur voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nicolas Ouellet-Payeur
| Code-Review | +1 |
2 comments
Patchset-level comments
File chrome/browser/policy/cloud/extension_install_policy_service_unittest.cc
Line 26, Patchset 6:
base::Value value_for_version(base::Value::Type::DICT);
value_for_version.GetDict().Set("action", action);Nicolas Ouellet-Payeur . unresolved
nit: code golf
```
return base::Value::Dict().Set(
extension_version,
base::Value::Dict().Set("action", action));
```
Related details
Attention is currently required from:
- Yann Dago
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Jan 8, 2026, 1:53:31 PM (21 hours ago) Jan 8
to Nicolas Ouellet-Payeur, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Yann Dago
Yann Dago voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yann Dago
| Commit-Queue | +2 |
1 comment
File chrome/browser/policy/cloud/extension_install_policy_service_unittest.cc
Line 26, Patchset 6:
base::Value value_for_version(base::Value::Type::DICT);
value_for_version.GetDict().Set("action", action);Nicolas Ouellet-Payeur . resolved
nit: code golf
```
return base::Value::Dict().Set(
extension_version,
base::Value::Dict().Set("action", action));
```
Yann Dago
Done
Related details
Attention is currently required from:
- Yann Dago
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Jan 8, 2026, 3:19:10 PM (19 hours ago) Jan 8
to Nicolas Ouellet-Payeur, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Yann Dago voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Jan 8, 2026, 6:23:58 PM (16 hours ago) Jan 8
to Nicolas Ouellet-Payeur, Enterprise Policy Reviews, AyeAye, Chromium LUCI CQ, extension...@chromium.org, chromium-a...@chromium.org
Yann Dago voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 8:38:39 PM (14 hours ago) Jan 8
to Yann Dago, Nicolas Ouellet-Payeur, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/policy/cloud/extension_install_policy_service_browsertest.cc
Insertions: 2, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/policy/cloud/extension_install_policy_service_unittest.cc
Insertions: 6, Deletions: 5.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[EICP] Add tests for ExtensionInstallPolicyService
Added unit tests for IsExtensionAllowed
Added browser tests for CanInstallExtension, with policy at machine level
Bug: 469398061
Change-Id: Iab6df7997765adc92a6cf9317a00c6c978e475e7
Reviewed-by: Nicolas Ouellet-Payeur <nico...@chromium.org>
Commit-Queue: Yann Dago <yd...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566659}
Files:
- M chrome/browser/policy/cloud/extension_install_policy_service.cc
- A chrome/browser/policy/cloud/extension_install_policy_service_browsertest.cc
- A chrome/browser/policy/cloud/extension_install_policy_service_unittest.cc
- M chrome/test/BUILD.gn
- M components/policy/core/common/cloud/cloud_policy_client_types.cc
- M components/policy/core/common/cloud/cloud_policy_client_unittest.cc
- M components/policy/core/common/mock_configuration_policy_provider.cc
- M components/policy/core/common/mock_configuration_policy_provider.h
Change size: L
Delta: 8 files changed, 375 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicolas Ouellet-Payeur
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages