[M138-LTS][Extensions] Do not apply DNR rules for Webview requests [chromium/src : refs/branch-heads/7204]
0 views
Skip to first unread message
Gyuyoung Kim (xWF) (Gerrit)
Jan 7, 2026, 9:54:31 PM (2 days ago) Jan 7
to Kelvin Jiang, Devlin Cronin, Victor Gabriel Savu, Chromium LUCI CQ, James Maclean, Kevin McNee, extension...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, webap...@microsoft.com
Attention needed from Devlin Cronin, Kelvin Jiang and Victor Gabriel Savu
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Gyuyoung Kim (xWF) . resolved
The bug was approved to merge the fix to M138. PTAL.
Related details
Attention is currently required from:
- Devlin Cronin
- Kelvin Jiang
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Jan 8, 2026, 8:07:41 AM (yesterday) Jan 8
to Kelvin Jiang, AyeAye, Devlin Cronin, Victor Gabriel Savu, Chromium LUCI CQ, James Maclean, Kevin McNee, extension...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, webap...@microsoft.com
Attention needed from Devlin Cronin, Gyuyoung Kim (xWF), Kelvin Jiang and Victor Gabriel Savu
Gyuyoung Kim (xWF) removed a vote from this change![]( "Open in Gerrit")
Attention is currently required from:
- Devlin Cronin
- Gyuyoung Kim (xWF)
- Kelvin Jiang
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 8, 2026, 1:21:01 PM (21 hours ago) Jan 8
to Kelvin Jiang, Gyuyoung Kim (xWF), Devlin Cronin, AyeAye, Victor Gabriel Savu, Chromium LUCI CQ, James Maclean, Kevin McNee, extension...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, webap...@microsoft.com
Attention needed from Gyuyoung Kim (xWF), Kelvin Jiang and Victor Gabriel Savu
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Gyuyoung Kim (xWF)
- Kelvin Jiang
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kelvin Jiang (Gerrit)
Jan 8, 2026, 4:09:07 PM (19 hours ago) Jan 8
to Gyuyoung Kim (xWF), Devlin Cronin, AyeAye, Victor Gabriel Savu, Chromium LUCI CQ, James Maclean, Kevin McNee, extension...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, webap...@microsoft.com
Attention needed from Gyuyoung Kim (xWF) and Victor Gabriel Savu
Kelvin Jiang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kelvin Jiang
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Gyuyoung Kim (xWF)
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kelvin Jiang (Gerrit)
Jan 8, 2026, 4:22:11 PM (18 hours ago) Jan 8
to Gyuyoung Kim (xWF), Devlin Cronin, AyeAye, Victor Gabriel Savu, Chromium LUCI CQ, James Maclean, Kevin McNee, extension...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, webap...@microsoft.com
Attention needed from Gyuyoung Kim (xWF) and Victor Gabriel Savu
Kelvin Jiang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 5:36:05 PM (17 hours ago) Jan 8
to Kelvin Jiang, Gyuyoung Kim (xWF), Devlin Cronin, AyeAye, Victor Gabriel Savu, James Maclean, Kevin McNee, extension...@chromium.org, chromium-a...@chromium.org, dmurph+wat...@chromium.org, webap...@microsoft.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M138-LTS][Extensions] Do not apply DNR rules for Webview requests
Extensions should not be able to apply DNR rules to requests originating
from WebViews.
(cherry picked from commit 28628907f24e27fff20d26471482f377047db3c8)
Bug: 463155954
Change-Id: I50bcf9d32480407cfa76bb0bfe6cab67351c43ec
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Commit-Queue: Kelvin Jiang <kelvi...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1563452}
Reviewed-by: Kelvin Jiang <kelvi...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7204@{#3473}
Cr-Branched-From: d5de512dc9dc8ddfe4e6d71b0637578bb6158683-refs/heads/main@{#1465706}
Files:
- M chrome/browser/apps/guest_view/web_view_browsertest.cc
- A chrome/test/data/extensions/api_test/declarative_net_request/block_chrome_signin/manifest.json
- A chrome/test/data/extensions/api_test/declarative_net_request/block_chrome_signin/rules.json
- M extensions/browser/api/declarative_net_request/ruleset_manager.cc
Change size: M
Delta: 4 files changed, 71 insertions(+), 0 deletions(-)
Branch: refs/branch-heads/7204
Submit Requirements:
Code-Review: +1 by Devlin Cronin, +1 by Kelvin Jiang
Lint: +0 by AyeAye
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages