[m145] tooltip and css adjustments for pdf summarize button [chromium/src : refs/branch-heads/7632]
0 views
Skip to first unread message
Erik Chen (Gerrit)
Feb 19, 2026, 11:35:15 PM (13 hours ago) Feb 19
to Sophie Chang, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org, srahim...@chromium.org
Attention needed from Sophie Chang
Erik Chen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Feb 19, 2026, 11:39:20 PM (13 hours ago) Feb 19
to Erik Chen, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org, srahim...@chromium.org
Attention needed from Erik Chen
Sophie Chang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
12:37 AM (12 hours ago) 12:37 AM
to Sophie Chang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org, srahim...@chromium.org
Erik Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
2:20 AM (10 hours ago) 2:20 AM
to Sophie Chang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org, srahim...@chromium.org
Erik Chen voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:25 AM (10 hours ago) 2:25 AM
to Erik Chen, Sophie Chang, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org, srahim...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[m145] tooltip and css adjustments for pdf summarize button
This CL is a combo merge of 3 CLs:
(1) tooltip and css adjustments for pdf summarize button
initial, approved CL.
(2) Disable translation for glic summarize button
as strings have not yet been translated, and the feature is only targeted
at en-US, disable translation.
(3) Slight UX tweaks to glic summarize button
minor CSS tweaks that landed today.
> Slight UX tweaks to glic summarize button
>
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7596581
> Commit-Queue: Erik Chen <erik...@chromium.org>
> Reviewed-by: Lei Zhang <the...@chromium.org>
> Reviewed-by: Erik Chen <erik...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1587580}
>
>
> Disable translation for glic summarize button
>
> As this is getting merged to M145 and is en-US only, translation is not
> needed. Translation will be re-added in the future.
>
> Bug: 484089544
> Change-Id: I0a54cb1fbd3178454a84573edd67a3de7df56afb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7596584
> Reviewed-by: Erik Chen <erik...@chromium.org>
> Reviewed-by: Lei Zhang <the...@chromium.org>
> Commit-Queue: Erik Chen <erik...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1587583}
>
>
> tooltip and css adjustments for pdf summarize button
>
> Bug: 483727155
> Change-Id: I83838e8a4a6fff30b7ee050bae1800565cb68e10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7589312
> Commit-Queue: Erik Chen <erik...@chromium.org>
> Reviewed-by: Lei Zhang <the...@chromium.org>
> Reviewed-by: Erik Chen <erik...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1586840}
Change-Id: I01601d0679b27140c5160ba5274f4b6b11283e5f
Bug: 483727155
Fixed: 485983608
Commit-Queue: Erik Chen <erik...@chromium.org>
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Reviewed-by: Erik Chen <erik...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7632@{#3059}
Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
Files:
- M chrome/app/generated_resources.grd
- D chrome/app/generated_resources_grd/IDS_PDF_GLIC_SUMMARIZE.png.sha1
- M chrome/browser/pdf/pdf_extension_util.cc
- M chrome/browser/resources/pdf/elements/viewer_toolbar.css
- M chrome/browser/resources/pdf/elements/viewer_toolbar.html
Change size: S
Delta: 5 files changed, 15 insertions(+), 4 deletions(-)
Branch: refs/branch-heads/7632
Submit Requirements:
Code-Review: +1 by Sophie Chang, +1 by Erik Chen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages