[Extensions] Implement OnToolbarActionRemoved() in menu model [chromium/src : main]
0 views
Skip to first unread message
Emilia Paz (Gerrit)
Oct 30, 2025, 5:32:18 PM (23 hours ago) Oct 30
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Emilia Paz . resolved
A couple straight forward ones going your way :)
Related details
Attention is currently required from:
- Shuhei Takahashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 30, 2025, 5:38:18 PM (23 hours ago) Oct 30
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi
Emilia Paz voted Auto-Submit+0![]( "Open in Gerrit")
| Auto-Submit | +0 |
Related details
Attention is currently required from:
- Shuhei Takahashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shuhei Takahashi (Gerrit)
Oct 30, 2025, 7:54:35 PM (20 hours ago) Oct 30
to Emilia Paz, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Shuhei Takahashi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
1:26 PM (3 hours ago) 1:26 PM
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:28 PM (3 hours ago) 1:28 PM
to Emilia Paz, Shuhei Takahashi, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Implement OnToolbarActionRemoved() in menu model
ToolbarActionsModel::Observer::OnToolbarActionRemoved was moved from
the platform delegate views to the model. This CL implements the
method in the model.
No functionality changed.
Bug: 449814184
Change-Id: I7698ae0a3775bc55d11930efdf3b5f9983c2c3d7
Reviewed-by: Shuhei Takahashi <n...@chromium.org>
Commit-Queue: Emilia Paz <emil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538695}
Files:
- M chrome/browser/ui/extensions/extensions_menu_view_model.cc
- M chrome/browser/ui/extensions/extensions_menu_view_model_browsertest.cc
- M chrome/browser/ui/extensions/extensions_menu_view_platform_delegate.h
- M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.cc
- M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
Change size: M
Delta: 5 files changed, 32 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Shuhei Takahashi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages