[iOS] Move passkey related types to components [chromium/src : main]
0 views
Skip to first unread message
Alexis Hétu (Gerrit)
Oct 28, 2025, 1:28:39 PM (3 days ago) Oct 28
to Tommy Martino, chromium...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, webauthn...@chromium.org
Attention needed from Tommy Martino
Alexis Hétu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Martino (Gerrit)
Oct 29, 2025, 10:27:14 AM (2 days ago) Oct 29
to Alexis Hétu, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, webauthn...@chromium.org
Attention needed from Alexis Hétu
Tommy Martino added 1 comment![]( "Open in Gerrit")
File components/webauthn/ios/passkey_types.h
Line 13, Patchset 2 (Latest):
namespace PasskeyTypes {Tommy Martino . unresolved
Generally, components namespaces match the top-level directory (so `webauthn` in this case). Also, whatever name we use should be in `snake_case`.
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Oct 29, 2025, 1:43:19 PM (2 days ago) Oct 29
to Chromium LUCI CQ, Tommy Martino, chromium...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, webauthn...@chromium.org
Attention needed from Tommy Martino
Alexis Hétu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexis Hétu
| Commit-Queue | +1 |
1 comment
File components/webauthn/ios/passkey_types.h
Generally, components namespaces match the top-level directory (so `webauthn` in this case). Also, whatever name we use should be in `snake_case`.
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Martino (Gerrit)
Oct 30, 2025, 4:49:31 PM (23 hours ago) Oct 30
to Alexis Hétu, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, webauthn...@chromium.org
Attention needed from Alexis Hétu
Tommy Martino voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Oct 30, 2025, 4:57:53 PM (23 hours ago) Oct 30
to Tommy Martino, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, webauthn...@chromium.org
Alexis Hétu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 30, 2025, 6:07:03 PM (22 hours ago) Oct 30
to Alexis Hétu, Tommy Martino, chromium...@chromium.org, chromium-a...@chromium.org, derinel+wat...@google.com, extension...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org, webauthn...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Move passkey related types to components
Some types will we used by PasskeyTabHelper to make passkey
related requests, so these types will be moved to:
components/webauthn/ios/
These types are:
- ReauthenticatePurpose
- SharedKey
- SharedKeyList
- KeysFetchedCallback
Aliases still exist for these types in PasskeyKeychainProvider
and will be removed once all uses of these aliases are removed.
Bug: 385174410
Change-Id: Ie808bd28ab755315b75f65d0b88ff9a5c13b888f
Reviewed-by: Tommy Martino <tmar...@chromium.org>
Commit-Queue: Alexis Hétu <su...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538234}
Files:
- M components/webauthn/ios/BUILD.gn
- A components/webauthn/ios/passkey_types.h
- M ios/chrome/browser/credential_exchange/coordinator/credential_export_coordinator.mm
- M ios/chrome/common/credential_provider/BUILD.gn
- M ios/chrome/common/credential_provider/passkey_keychain_provider.h
- M ios/chrome/common/credential_provider/passkey_keychain_provider.mm
- M ios/chrome/common/credential_provider/passkey_keychain_provider_bridge.h
- M ios/chrome/common/credential_provider/passkey_keychain_provider_bridge.mm
- M ios/chrome/credential_provider_extension/credential_provider_view_controller.mm
Change size: M
Delta: 9 files changed, 127 insertions(+), 102 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tommy Martino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages