Howard Chang (Gerrit)

unread,

May 26, 2026, 1:55:47 PM (6 days ago) May 26

to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Howard Chang abandoned this change.

View Change

Abandoned

Unused

Howard Chang abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

John Lee (Gerrit)

unread,

May 26, 2026, 7:53:25 PM (6 days ago) May 26

to Howard Chang, John Lee, Abe Boujane, Dana Fried, Ian Vollick, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Abe Boujane, Dana Fried, Howard Chang and Ian Vollick

John Lee voted and added 1 comment

Votes added by John Lee

Code-Review

+1

1 comment

File chrome/test/data/webui/settings/skills_page_test.ts

Line 49, Patchset 5 (Latest): assertTrue(subpage.getPref('skills.enabled').value as boolean);

John Lee . unresolved

`getPref<boolean>`

Open in Gerrit

Related details

Attention is currently required from:

Abe Boujane
Dana Fried
Howard Chang
Ian Vollick

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

May 27, 2026, 2:55:36 PM (5 days ago) May 27

to John Lee, Abe Boujane, Dana Fried, Ian Vollick, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Abe Boujane, Dana Fried and Ian Vollick

Howard Chang added 1 comment

File chrome/test/data/webui/settings/skills_page_test.ts

Line 49, Patchset 5: assertTrue(subpage.getPref('skills.enabled').value as boolean);

John Lee . resolved

`getPref<boolean>`

Howard Chang

Done

Open in Gerrit

Related details

Attention is currently required from:

Abe Boujane
Dana Fried
Ian Vollick

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ian Vollick (Gerrit)

unread,

May 27, 2026, 4:21:31 PM (5 days ago) May 27

to Howard Chang, John Lee, Abe Boujane, Dana Fried, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Abe Boujane, Dana Fried and Howard Chang

Ian Vollick voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Abe Boujane
Dana Fried
Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

May 29, 2026, 7:59:20 PM (3 days ago) May 29

to Howard Chang, Reilly Grant, Alex Ilin, Carlos Pizano, Ian Vollick, John Lee, Abe Boujane, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Abe Boujane, Alex Ilin, Carlos Pizano and Howard Chang

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Abe Boujane
Alex Ilin
Carlos Pizano
Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Abe Boujane (Gerrit)

unread,

9:47 AM (7 hours ago) 9:47 AM

to Howard Chang, Reilly Grant, Alex Ilin, Carlos Pizano, Ian Vollick, John Lee, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Alex Ilin, Carlos Pizano and Howard Chang

Abe Boujane voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

2:02 PM (3 hours ago) 2:02 PM

to David Pennington, Abe Boujane, Reilly Grant, Ian Vollick, John Lee, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from David Pennington

Howard Chang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

David Pennington

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Pennington (Gerrit)

unread,

2:17 PM (3 hours ago) 2:17 PM

to Howard Chang, Abe Boujane, Reilly Grant, Ian Vollick, John Lee, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Howard Chang

David Pennington added 2 comments

File chrome/browser/resources/settings/ai_page/ai_page.html

Line 5, Patchset 9 (Latest): }

David Pennington . unresolved

is there any reason for not adding these rules to a CSS file?

This seems unrelated to the description of the change, lets add some extra details.

File chrome/browser/resources/settings/metrics_browser_proxy.ts

Line 342, Patchset 9 (Latest): MAX_VALUE = 9,

David Pennington . unresolved

shouldnt the max value be 8 here?

Open in Gerrit

Related details

Attention is currently required from:

Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

David Pennington (Gerrit)

unread,

2:17 PM (3 hours ago) 2:17 PM

to Howard Chang, Abe Boujane, Reilly Grant, Ian Vollick, John Lee, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Attention needed from Howard Chang

David Pennington voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Howard Chang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Howard Chang (Gerrit)

unread,

2:28 PM (2 hours ago) 2:28 PM

to David Pennington, Abe Boujane, Reilly Grant, Ian Vollick, John Lee, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Howard Chang added 2 comments

File chrome/browser/resources/settings/ai_page/ai_page.html

Line 5, Patchset 9 (Latest): }

David Pennington . resolved

is there any reason for not adding these rules to a CSS file?
This seems unrelated to the description of the change, lets add some extra details.

Howard Chang

Polymer components declare their local styles inside a <style> block in the component's HTML template. This keeps style rules encapsulated within the element's shadow root. You can also find similar pattern for other html files.

File chrome/browser/resources/settings/metrics_browser_proxy.ts

Line 342, Patchset 9 (Latest): MAX_VALUE = 9,

David Pennington . resolved

shouldnt the max value be 8 here?

Howard Chang

No, the MAX_VALUE in WebUI enums serves as the exclusive boundary value. You can also find similar pattern in other enums in this file as well.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

2:32 PM (2 hours ago) 2:32 PM

to Howard Chang, David Pennington, Abe Boujane, Reilly Grant, Ian Vollick, John Lee, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rainhar...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

settings: Add dedicated Skills subpage and toggle

original
cl:https://chromium-review.git.corp.google.com/c/chromium/src/+/7868856

Bug: 513332678

Change-Id: Icb2b0be7e841f0e942ed87ad35abe3169360a677

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7876585

Commit-Queue: Howard Chang <howa...@google.com>

Reviewed-by: John Lee <john...@chromium.org>

Reviewed-by: Ian Vollick <vol...@chromium.org>

Reviewed-by: Abe Boujane <bou...@google.com>

Reviewed-by: David Pennington <dpen...@chromium.org>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1639547}

Files:

M chrome/app/shared_settings_strings.grdp
A chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_SKILLS_GALLERY_HEADER.png.sha1
A chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_SKILLS_GALLERY_LABEL.png.sha1
A chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_SKILLS_SETTING_LABEL.png.sha1
A chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_SKILLS_SETTING_SUBLABEL.png.sha1
A chrome/app/shared_settings_strings_grdp/IDS_SETTINGS_SKILLS_TOGGLE_LABEL.png.sha1
M chrome/browser/extensions/BUILD.gn
M chrome/browser/extensions/api/settings_private/prefs_util.cc
M chrome/browser/resources/settings/BUILD.gn
M chrome/browser/resources/settings/ai_page/OWNERS
M chrome/browser/resources/settings/ai_page/ai_page.html
M chrome/browser/resources/settings/ai_page/ai_page.ts
M chrome/browser/resources/settings/ai_page/ai_page_index.html
M chrome/browser/resources/settings/ai_page/ai_page_index.ts
A chrome/browser/resources/settings/ai_page/skills_page.html
A chrome/browser/resources/settings/ai_page/skills_page.ts
M chrome/browser/resources/settings/lazy_load.ts
M chrome/browser/resources/settings/metrics_browser_proxy.ts
M chrome/browser/resources/settings/route.ts
M chrome/browser/resources/settings/router.ts
M chrome/browser/ui/BUILD.gn
M chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
M chrome/browser/ui/webui/settings/settings_ui.cc
M chrome/test/data/webui/settings/BUILD.gn
M chrome/test/data/webui/settings/OWNERS
M chrome/test/data/webui/settings/ai_page_test.ts
M chrome/test/data/webui/settings/settings_browsertest.cc
A chrome/test/data/webui/settings/skills_page_test.ts
M tools/metrics/histograms/metadata/settings/enums.xml

Change size: L

Delta: 29 files changed, 276 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ian Vollick, +1 by John Lee, +1 by Reilly Grant, +1 by David Pennington, +1 by Abe Boujane

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

settings: Add dedicated Skills subpage and toggle [chromium/src : main]

Howard Chang (Gerrit)

Howard Chang abandoned this change

Related details

John Lee (Gerrit)

John Lee voted and added 1 comment

Votes added by John Lee

1 comment

Related details

Howard Chang (Gerrit)

Howard Chang added 1 comment

Related details

Ian Vollick (Gerrit)

Ian Vollick voted Code-Review+1

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

1 comment

Related details

Abe Boujane (Gerrit)

Abe Boujane voted Code-Review+1

Related details

Howard Chang (Gerrit)

Howard Chang voted Commit-Queue+1

Related details

David Pennington (Gerrit)

David Pennington added 2 comments

Related details

David Pennington (Gerrit)

David Pennington voted Code-Review+1

Related details

Howard Chang (Gerrit)

Howard Chang added 2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information