Add cws zero state iph variation 3 [chromium/src : main]
2 views
Skip to first unread message
Howard Chang (Gerrit)
Oct 28, 2025, 5:47:34 PM (4 days ago) Oct 28
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Howard Chang abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Oct 29, 2025, 1:27:53 PM (3 days ago) Oct 29
to Howard Chang, Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz and Howard Chang
Dana Fried added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Dana Fried . unresolved
I don't understand what is happening here; it looks like the only difference between the previous CL and this one is underlining "Extensions" but there's a lot of code changes!
Related details
Attention is currently required from:
- Emilia Paz
- Howard Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Howard Chang (Gerrit)
Oct 29, 2025, 1:39:47 PM (3 days ago) Oct 29
to Dana Fried, Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Dana Fried and Emilia Paz
Howard Chang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dana Fried . resolved
I don't understand what is happening here; it looks like the only difference between the previous CL and this one is underlining "Extensions" but there's a lot of code changes!
Howard Chang
There are some differences between previous cl and this one as this is another variation of the ui (V3) instead of changing the ui in the previous cl (V2). We will be experimenting between these ui to compare which gives better results.
Detail changes are listed below:
1. https://screenshot.googleplex.com/6Ko2mXcaZzVbdUv V2a and V2b has different tab order and "Visit Webstore" is replaced by "Help me write"
2. This CL change the header to "Supercharge your browser with extensions and themes" which previous cl did not
3. Since this is another variation of the ui (V3 vs V2), we need similar amount of setup as previous cl
Related details
Attention is currently required from:
- Dana Fried
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Oct 29, 2025, 8:17:38 PM (3 days ago) Oct 29
to Howard Chang, Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz and Howard Chang
Dana Fried voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Emilia Paz
- Howard Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 30, 2025, 1:23:28 PM (2 days ago) Oct 30
to Howard Chang, Dana Fried, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Attention needed from Howard Chang
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Howard Chang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Howard Chang (Gerrit)
Oct 30, 2025, 2:11:13 PM (2 days ago) Oct 30
to Emilia Paz, Dana Fried, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Howard Chang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 30, 2025, 4:35:26 PM (2 days ago) Oct 30
to Howard Chang, Emilia Paz, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add cws zero state iph variation 3
This cl is similar to https://chromium-review.googlesource.com/c/chromium/src/+/7084950
Demo: https://screenshot.googleplex.com/Bw3Mfz9CxjRaJnz
Bug: 409573170
Change-Id: I8545e2674ec70d26ac99e241ed38ad9a972ff320
Reviewed-by: Dana Fried <dfr...@chromium.org>
Reviewed-by: Emilia Paz <emil...@chromium.org>
Commit-Queue: Howard Chang <howa...@google.com>
Cr-Commit-Position: refs/heads/main@{#1538136}
Files:
- M chrome/app/extensions_strings.grdp
- A chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_CHIPS_WITH_LINK_IPH_DESCRIPTION.png.sha1
- A chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_CHIPS_WITH_LINK_IPH_LINK_LABEL.png.sha1
- A chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_IPH_HEADER_V2.png.sha1
- M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.css
- M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.html.ts
- M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.ts
- M chrome/browser/ui/views/user_education/browser_user_education_service.cc
- M chrome/browser/ui/webui/extensions_zero_state_promo/extensions_zero_state_promo_interactive_uitest.cc
- M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
- M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_ui.cc
- M chrome/test/data/webui/extensions_zero_state/zero_state_promo_app_test.ts
- M chrome/test/data/webui/extensions_zero_state/zero_state_promo_browsertest.cc
- M components/feature_engagement/public/feature_constants.cc
- M components/feature_engagement/public/feature_constants.h
- M extensions/common/extension_urls.cc
- M extensions/common/extension_urls.h
- M extensions/common/switches.cc
- M extensions/common/switches.h
Change size: L
Delta: 19 files changed, 373 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz, +1 by Dana Fried
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 30, 2025, 8:00:31 PM (2 days ago) Oct 30
to Chromium LUCI CQ, Howard Chang, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, dfried...@chromium.org, estali...@chromium.org, extension...@chromium.org
Emilia Paz has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages