hierarchical: Add submenus for extensions in app menu [chromium/src : main]

[Masa Fujita (Gerrit)]

New activity on the change

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 7

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 18 Oct 2025 16:48:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 10

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sat, 18 Oct 2025 20:01:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 12

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sun, 19 Oct 2025 07:16:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 13

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Sun, 19 Oct 2025 08:09:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 15

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 22 Oct 2025 08:14:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 16

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 22 Oct 2025 08:23:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 19

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 23 Oct 2025 19:54:15 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 20

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 24 Oct 2025 00:19:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Masa Fujita (Gerrit)]

Attention needed from Jenna Himawan and Wenyu Fu

Masa Fujita voted and added 7 comments

Votes added by Masa Fujita

Commit-Queue

+1

7 comments

File chrome/android/java/src/org/chromium/chrome/browser/app/appmenu/AppMenuPropertiesDelegateImpl.java

Line 452, Patchset 25: .with(AppMenuItemProperties.TITLE_CONDENSED, getContentDescription(id))

Wenyu Fu . resolved

This method checks if the id is `preferences_id` so this is effectively always null.

Masa Fujita

It seems that I was misunderstanding what TITLE_CONDENSED was doing, but it seems like we actually don't need this for menu items. I removed it.

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java

Line 720, Patchset 25: R.id.extensions_menu_id,

Wenyu Fu . resolved

`buildManageExtensionsItem` uses the same menu ID as `buildExtensionsItem`. Can you please add an assert (checking ChromeFeatureList.SUBMENUS_IN_APP_MENU) to make sure they are not misused?

Masa Fujita

Done

File chrome/browser/ui/android/appmenu/internal/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuCoordinatorFactory.java

Line 51, Patchset 25: SubmenuHeaderFactory submenuHeaderFactory) {

Wenyu Fu . resolved

nit: @param javadoc

Masa Fujita

Done

File chrome/browser/ui/android/appmenu/internal/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuCoordinatorImpl.java

Line 61, Patchset 25: SubmenuHeaderFactory submenuHeaderFactory) {

Wenyu Fu . resolved

nit: @param javadoc

Masa Fujita

Done

File chrome/browser/ui/android/appmenu/internal/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuHandlerImpl.java

Line 152, Patchset 25: SubmenuHeaderFactory submenuHeaderFactory) {

Wenyu Fu . resolved

nit: @param javadoc

Masa Fujita

Done

Line 297, Patchset 25: mHierarchicalMenuController =

Wenyu Fu . resolved

nit: Let's check the feature flag here before create the controller.

Masa Fujita

Done

Line 303, Patchset 25: true);

Wenyu Fu . resolved

nit: add param hint

Masa Fujita

Done

Open in Gerrit

Related details

Attention is currently required from:

• Jenna Himawan
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 27

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jenna Himawan <jhim...@google.com>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Comment-Date: Sat, 25 Oct 2025 02:28:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Wenyu Fu <wen...@chromium.org>

[Jenna Himawan (Gerrit)]

Attention needed from Masa Fujita and Wenyu Fu

Jenna Himawan added 4 comments

File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Line 3858, Patchset 27 (Latest): .createNewTab(params, TabLaunchType.FROM_CHROME_UI, null);

Jenna Himawan . unresolved

nit: add comment containing the parameter name so we know what parameter is being set to null

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java

Line 716, Patchset 27 (Latest): shouldShowIconBeforeItem() ? R.drawable.ic_extension_24dp : 0,

Jenna Himawan . unresolved

Maybe use Resources.ID_NULL instead of 0? (here and elsewhere)

File chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java

Line 410, Patchset 27 (Latest): private void assertSubMenuItemsAreEqual(

Jenna Himawan . unresolved

nit: `assertHasSubMenuItemIds` might be a more descriptive name?

File chrome/browser/ui/android/appmenu/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuItemWithSubmenuProperties.java

Line 47, Patchset 27 (Latest): ENABLED,

Jenna Himawan . unresolved

why is TITLE_CONDENSED being deleted?

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 27

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Comment-Date: Sat, 25 Oct 2025 02:44:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Masa Fujita (Gerrit)]

Attention needed from Jenna Himawan and Wenyu Fu

Masa Fujita voted and added 4 comments

Votes added by Masa Fujita

Commit-Queue

+1

4 comments

File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Line 3858, Patchset 27: .createNewTab(params, TabLaunchType.FROM_CHROME_UI, null);

Jenna Himawan . resolved

nit: add comment containing the parameter name so we know what parameter is being set to null

Masa Fujita

Done

File chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegate.java

Line 716, Patchset 27: shouldShowIconBeforeItem() ? R.drawable.ic_extension_24dp : 0,

Jenna Himawan . resolved

Maybe use Resources.ID_NULL instead of 0? (here and elsewhere)

Masa Fujita

Done

File chrome/android/junit/src/org/chromium/chrome/browser/tabbed_mode/TabbedAppMenuPropertiesDelegateUnitTest.java

Line 410, Patchset 27: private void assertSubMenuItemsAreEqual(

Jenna Himawan . resolved

nit: `assertHasSubMenuItemIds` might be a more descriptive name?

Masa Fujita

agreed, thanks!

File chrome/browser/ui/android/appmenu/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuItemWithSubmenuProperties.java

Line 47, Patchset 27: ENABLED,

Jenna Himawan . unresolved

why is TITLE_CONDENSED being deleted?

Masa Fujita

It seems that TITLE_CONDENSED was meant for the icons in the icon row, so I think it was a mistake to have added it. But I'm not too confident - let me know if you know more (+ @wen...@chromium.org)

Open in Gerrit

Related details

Attention is currently required from:

• Jenna Himawan
• Wenyu Fu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 28

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jenna Himawan <jhim...@google.com>

Gerrit-Attention: Wenyu Fu <wen...@chromium.org>

Gerrit-Comment-Date: Sat, 25 Oct 2025 15:06:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Jenna Himawan <jhim...@google.com>

[Wenyu Fu (Gerrit)]

Attention needed from Jenna Himawan and Masa Fujita

Wenyu Fu voted and added 3 comments

Votes added by Wenyu Fu

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 28 (Latest):

Wenyu Fu . resolved

Looks good in general.

Please get Jenna's +1 before submit

File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Line 3856, Patchset 28 (Latest): if (currentTab == null) {

Wenyu Fu . unresolved

nitty nit: Maybe also confirm with UX if it make sense to show the extension store item when the tab is null (e.g. in tab switcher)

File chrome/browser/ui/android/appmenu/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuItemWithSubmenuProperties.java

Line 47, Patchset 27: ENABLED,

Jenna Himawan . unresolved

why is TITLE_CONDENSED being deleted?

Masa Fujita

It seems that TITLE_CONDENSED was meant for the icons in the icon row, so I think it was a mistake to have added it. But I'm not too confident - let me know if you know more (+ @wen...@chromium.org)

Wenyu Fu

It seems that TITLE_CONDENSED was meant for the icons in the icon row

I don't have too much context here, but according to the code in `buildModelForIcon`, it seems to be the case (provide content description for buttons without text).

Tf it's not being used, Im fine with removing. We can add that back later if we decided to.

Open in Gerrit

Related details

Attention is currently required from:

• Jenna Himawan
• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 28

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Attention: Jenna Himawan <jhim...@google.com>

Gerrit-Comment-Date: Mon, 27 Oct 2025 20:37:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Masa Fujita <mas...@google.com>

Comment-In-Reply-To: Jenna Himawan <jhim...@google.com>

[Masa Fujita (Gerrit)]

Attention needed from Jenna Himawan

Masa Fujita added 2 comments

File chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Line 3856, Patchset 28 (Latest): if (currentTab == null) {

Wenyu Fu . resolved

nitty nit: Maybe also confirm with UX if it make sense to show the extension store item when the tab is null (e.g. in tab switcher)

Masa Fujita

We only show the extensions item in `MenuGroup.PAGE_MENU` (which excludes things like the tab switcher), so it should be rare for `currentTab` to be null.

File chrome/browser/ui/android/appmenu/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuItemWithSubmenuProperties.java

Line 47, Patchset 27: ENABLED,

Jenna Himawan . resolved

why is TITLE_CONDENSED being deleted?

Masa Fujita

It seems that TITLE_CONDENSED was meant for the icons in the icon row, so I think it was a mistake to have added it. But I'm not too confident - let me know if you know more (+ @wen...@chromium.org)

Wenyu Fu

It seems that TITLE_CONDENSED was meant for the icons in the icon row

I don't have too much context here, but according to the code in `buildModelForIcon`, it seems to be the case (provide content description for buttons without text).

Tf it's not being used, Im fine with removing. We can add that back later if we decided to.

Masa Fujita

sg, thanks! Done

Open in Gerrit

Related details

Attention is currently required from:

• Jenna Himawan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 28

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jenna Himawan <jhim...@google.com>

Gerrit-Comment-Date: Mon, 27 Oct 2025 21:29:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Masa Fujita <mas...@google.com>

Comment-In-Reply-To: Jenna Himawan <jhim...@google.com>

Comment-In-Reply-To: Wenyu Fu <wen...@chromium.org>

[Jenna Himawan (Gerrit)]

Attention needed from Masa Fujita

Jenna Himawan voted and added 1 comment

Votes added by Jenna Himawan

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 29 (Latest):

Jenna Himawan . resolved

Looks good! Thank you for doing this work. Sorry for the delay!

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I877c85070143f874fd0d880d9e7880a0a300c6f3

Gerrit-Change-Number: 7012587

Gerrit-PatchSet: 29

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>

Gerrit-CC: AJITH KUMAR V <aji...@samsung.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Comment-Date: Wed, 29 Oct 2025 16:51:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes