extensions menu: Introduce pinning preference [chromium/src : main]

[Masa Fujita (Gerrit)]

Masa Fujita has uploaded the change for review

Commit message

extensions menu: Introduce pinning preference

This change adds `EXTENSIONS_MENU_ICON_PINNED` preference, which will
keep track of the user's preference to display or not display the puzzle
piece icon.

Bug: 481457578

Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Change diff

Change information

Files:

• M chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
• M chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/extensions/BUILD.gn

Change size: XS

Delta: 2 files changed, 7 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 1

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

[Masa Fujita (Gerrit)]

Attention needed from Emilia Paz

Masa Fujita voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Emilia Paz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Mar 2026 11:44:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Emilia Paz (Gerrit)]

Attention needed from Masa Fujita

Emilia Paz added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emilia Paz . resolved

Thanks Masa! Is there a reason why we don't want to have this preference in `ExtensionPrefs` (C++)? ExtensionsPrefs is the single source of truth for all extension-related logic. It allows for sync across devices, and I believe it should sync for Android devices too. Is it preferred to have android-only preferences in Java? Does `ChromePreferenceKeys` sync across devices?
We may wanna open a thread in the AL-CRX chat

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Comment-Date: Mon, 09 Mar 2026 21:46:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Masa Fujita (Gerrit)]

Attention needed from Emilia Paz

Masa Fujita added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emilia Paz . resolved

Thanks Masa! Is there a reason why we don't want to have this preference in `ExtensionPrefs` (C++)? ExtensionsPrefs is the single source of truth for all extension-related logic. It allows for sync across devices, and I believe it should sync for Android devices too. Is it preferred to have android-only preferences in Java? Does `ChromePreferenceKeys` sync across devices?
We may wanna open a thread in the AL-CRX chat

Masa Fujita

My thinking was that this preference was closer to other Java UI settings, e.g. whether to show the bookmarks bar, which are considered local preferences and don't sync across devices on Clank. Also, since this settings is specific to Android, it doesn't feel right to store it in `ExtensionPrefs` that sync across all platforms. WDYT?

Open in Gerrit

Related details

Attention is currently required from:

• Emilia Paz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Mar 2026 04:46:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Emilia Paz <emil...@chromium.org>

[Masa Fujita (Gerrit)]

Attention needed from Emilia Paz

Masa Fujita added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emilia Paz . resolved

Thanks Masa! Is there a reason why we don't want to have this preference in `ExtensionPrefs` (C++)? ExtensionsPrefs is the single source of truth for all extension-related logic. It allows for sync across devices, and I believe it should sync for Android devices too. Is it preferred to have android-only preferences in Java? Does `ChromePreferenceKeys` sync across devices?
We may wanna open a thread in the AL-CRX chat

Masa Fujita

My thinking was that this preference was closer to other Java UI settings, e.g. whether to show the bookmarks bar, which are considered local preferences and don't sync across devices on Clank. Also, since this settings is specific to Android, it doesn't feel right to store it in `ExtensionPrefs` that sync across all platforms. WDYT?

Masa Fujita

On a second thought, it might make sense to keep this in the extensions prefs if this has the possibility of being ported to as a feature for Desktop too... let's ask AL-CRX

Open in Gerrit

Related details

Attention is currently required from:

• Emilia Paz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Comment-Date: Tue, 10 Mar 2026 07:03:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Masa Fujita <mas...@google.com>

Comment-In-Reply-To: Emilia Paz <emil...@chromium.org>

[Emilia Paz (Gerrit)]

Attention needed from Masa Fujita

Emilia Paz added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emilia Paz . unresolved

Thanks Masa! Is there a reason why we don't want to have this preference in `ExtensionPrefs` (C++)? ExtensionsPrefs is the single source of truth for all extension-related logic. It allows for sync across devices, and I believe it should sync for Android devices too. Is it preferred to have android-only preferences in Java? Does `ChromePreferenceKeys` sync across devices?
We may wanna open a thread in the AL-CRX chat

Masa Fujita

My thinking was that this preference was closer to other Java UI settings, e.g. whether to show the bookmarks bar, which are considered local preferences and don't sync across devices on Clank. Also, since this settings is specific to Android, it doesn't feel right to store it in `ExtensionPrefs` that sync across all platforms. WDYT?

Masa Fujita

On a second thought, it might make sense to keep this in the extensions prefs if this has the possibility of being ported to as a feature for Desktop too... let's ask AL-CRX

Emilia Paz

Based on AL-CRX chat, we wanna use extensions prefs (or general pref)

Open in Gerrit

Related details

Attention is currently required from:

• Masa Fujita

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Masa Fujita <mas...@google.com>

Gerrit-Comment-Date: Thu, 12 Mar 2026 06:01:19 +0000

[Masa Fujita (Gerrit)]

Attention needed from Emilia Paz

Masa Fujita added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Emilia Paz . unresolved

Thanks Masa! Is there a reason why we don't want to have this preference in `ExtensionPrefs` (C++)? ExtensionsPrefs is the single source of truth for all extension-related logic. It allows for sync across devices, and I believe it should sync for Android devices too. Is it preferred to have android-only preferences in Java? Does `ChromePreferenceKeys` sync across devices?
We may wanna open a thread in the AL-CRX chat

Masa Fujita

My thinking was that this preference was closer to other Java UI settings, e.g. whether to show the bookmarks bar, which are considered local preferences and don't sync across devices on Clank. Also, since this settings is specific to Android, it doesn't feel right to store it in `ExtensionPrefs` that sync across all platforms. WDYT?

Masa Fujita

On a second thought, it might make sense to keep this in the extensions prefs if this has the possibility of being ported to as a feature for Desktop too... let's ask AL-CRX

Emilia Paz

Based on AL-CRX chat, we wanna use extensions prefs (or general pref)

Masa Fujita

Yep, I'm whipping up the CL right now - thank you so much for pointing it out!

Open in Gerrit

Related details

Attention is currently required from:

• Emilia Paz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9b5019a152dc290cf06139c3ba4efa29d959a955

Gerrit-Change-Number: 7641299

Gerrit-PatchSet: 2

Gerrit-Owner: Masa Fujita <mas...@google.com>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Masa Fujita <mas...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 06:11:38 +0000

[Masa Fujita (Gerrit)]

Masa Fujita abandoned this change.

View Change

Abandoned

Masa Fujita abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon