Fix tvOS build by adding nogncheck to printing headers [chromium/src : main]
0 views
Skip to first unread message
Gyuyoung Kim (Gerrit)
Feb 19, 2026, 5:36:20 AM (20 hours ago) Feb 19
to Stefan Zager, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, cobalt-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Stefan Zager
Gyuyoung Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (Gerrit)
Feb 19, 2026, 5:36:54 AM (20 hours ago) Feb 19
to Stefan Zager, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, cobalt-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Stefan Zager
Gyuyoung Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Gyuyoung Kim . resolved
The build fail on tvos trybot is not related to this CL. The failure is going to be fixed by the other CL.
Gyuyoung Kim (Gerrit)
Feb 19, 2026, 4:37:12 PM (9 hours ago) Feb 19
to Dave Tapuska, Stefan Zager, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, cobalt-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Dave Tapuska and Stefan Zager
Gyuyoung Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Dave Tapuska
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Feb 19, 2026, 5:43:31 PM (8 hours ago) Feb 19
to Gyuyoung Kim, Stefan Zager, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, cobalt-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Gyuyoung Kim and Stefan Zager
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gyuyoung Kim
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (Gerrit)
Feb 19, 2026, 8:35:09 PM (5 hours ago) Feb 19
to Dave Tapuska, Stefan Zager, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, cobalt-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Attention needed from Stefan Zager
Gyuyoung Kim voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Stefan Zager
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 9:18:43 PM (4 hours ago) Feb 19
to Gyuyoung Kim, Dave Tapuska, Stefan Zager, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, cobalt-...@google.com, chromium-a...@chromium.org, extension...@chromium.org, cros-print...@google.com, print-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix tvOS build by adding nogncheck to printing headers
The tvOS build has been failing since crrev.com/c/7585171, which added
//printing dependencies conditionally based on enable_printing.
While the code is correctly guarded by #if defined(ENABLE_PRINTING), gn
check still fails on platforms like tvOS where printing is disabled
because the headers are visible but their corresponding deps are
missing.
This CL adds // nogncheck to resolve the "Include not allowed" error.
Bug: 391914246
Change-Id: I95d85bb6ab31fbfee02a50aecbff5ff2dc825b00
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuy...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1587574}
Files:
- M content/renderer/gpu_benchmarking_extension.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages