[m145] [PDF] Add a Glic summarize button [chromium/src : refs/branch-heads/7632]

0 views
Skip to first unread message

Erik Chen (Gerrit)

unread,
Feb 19, 2026, 8:39:14 PM (5 hours ago) Feb 19
to Lei Zhang, Chromium LUCI CQ, AyeAye, chromium-a...@chromium.org, srahim...@chromium.org, pdf-r...@chromium.org, extension...@chromium.org
Attention needed from Erik Chen

Message from Erik Chen

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7632
Gerrit-Change-Id: I322fffd555c9ea9f7ac071327984a593223e8201
Gerrit-Change-Number: 7595583
Gerrit-PatchSet: 4
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:39:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sophie Chang (Gerrit)

unread,
Feb 19, 2026, 8:40:39 PM (5 hours ago) Feb 19
to Lei Zhang, Erik Chen, Chromium LUCI CQ, AyeAye, chromium-a...@chromium.org, srahim...@chromium.org, pdf-r...@chromium.org, extension...@chromium.org
Attention needed from Erik Chen

Sophie Chang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Chen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7632
Gerrit-Change-Id: I322fffd555c9ea9f7ac071327984a593223e8201
Gerrit-Change-Number: 7595583
Gerrit-PatchSet: 4
Gerrit-Owner: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Reviewer: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 01:40:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Erik Chen (Gerrit)

unread,
Feb 19, 2026, 8:41:51 PM (5 hours ago) Feb 19
to Lei Zhang, Sophie Chang, Chromium LUCI CQ, AyeAye, chromium-a...@chromium.org, srahim...@chromium.org, pdf-r...@chromium.org, extension...@chromium.org

Erik Chen submitted the change

Change information

Commit message:
[m145] [PDF] Add a Glic summarize button

Merge note: this string has been translated so it's safe to merge.

Add an experimental button to the toolbar, guarded by a feature flag.
It does not do anything yet when pressed.

(cherry picked from commit f7fc17456fc32e94e16d0f6099097e63ac27d840)
Bug: 483727155
Change-Id: I322fffd555c9ea9f7ac071327984a593223e8201
Reviewed-by: Rebekah Potter <rbpo...@chromium.org>
Reviewed-by: Erik Chen <erik...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1584318}
Fixed: 485982230
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7632@{#3042}
Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
Files:
  • M chrome/app/generated_resources.grd
  • A chrome/app/generated_resources_grd/IDS_PDF_GLIC_SUMMARIZE.png.sha1
  • M chrome/browser/pdf/pdf_extension_util.cc
  • M chrome/browser/resources/pdf/elements/viewer_toolbar.css
  • M chrome/browser/resources/pdf/elements/viewer_toolbar.html
  • M chrome/browser/resources/pdf/elements/viewer_toolbar.ts
  • M chrome/common/BUILD.gn
  • M chrome/common/chrome_features.cc
  • M chrome/common/chrome_features.h
Change size: M
Delta: 9 files changed, 77 insertions(+), 2 deletions(-)
Branch: refs/branch-heads/7632
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sophie Chang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7632
Gerrit-Change-Id: I322fffd555c9ea9f7ac071327984a593223e8201
Gerrit-Change-Number: 7595583
Gerrit-PatchSet: 5
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages