Add missing context for cryptotokenPrivate API (issue 802843004 by arnarb@chromium.org)

3 views
Skip to first unread message

arn...@chromium.org

unread,
Dec 19, 2014, 9:58:50 AM12/19/14
to kal...@chromium.org, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, juan...@google.com, xiy...@chromium.org
Reviewers: kalman,

Message:
Missed this line in 766303003

Description:
Add missing context for cryptotokenPrivate API

BUG=443296
R=kalman
CC=xiyuan,juanlang

Please review this at https://codereview.chromium.org/802843004/

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+2, -1 lines):
M chrome/common/extensions/api/_api_features.json


Index: chrome/common/extensions/api/_api_features.json
diff --git a/chrome/common/extensions/api/_api_features.json
b/chrome/common/extensions/api/_api_features.json
index
43cde5436da75887cf5f560f3cff9d0231bab5c1..671a43cee5ea5294efec4373b24a0ae022ba9a7b
100644
--- a/chrome/common/extensions/api/_api_features.json
+++ b/chrome/common/extensions/api/_api_features.json
@@ -211,7 +211,8 @@
"contexts": ["blessed_extension"]
},
"cryptotokenPrivate": {
- "dependencies": ["permission:cryptotokenPrivate"]
+ "dependencies": ["permission:cryptotokenPrivate"],
+ "contexts": ["blessed_extension"]
},
"dataReductionProxy": {
"dependencies": ["permission:dataReductionProxy"],


kal...@chromium.org

unread,
Dec 19, 2014, 3:38:16 PM12/19/14
to arn...@chromium.org, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, juan...@google.com, xiy...@chromium.org
lgtm



https://codereview.chromium.org/802843004/

commi...@chromium.org

unread,
Dec 19, 2014, 4:24:44 PM12/19/14
to arn...@chromium.org, kal...@chromium.org, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, juan...@google.com, xiy...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/802843004/1


https://codereview.chromium.org/802843004/

commi...@chromium.org

unread,
Dec 19, 2014, 5:22:38 PM12/19/14
to arn...@chromium.org, kal...@chromium.org, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, juan...@google.com, xiy...@chromium.org
Committed patchset #1 (id:1)

https://codereview.chromium.org/802843004/

commi...@chromium.org

unread,
Dec 19, 2014, 5:24:32 PM12/19/14
to arn...@chromium.org, kal...@chromium.org, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, juan...@google.com, xiy...@chromium.org
Patchset 1 (id:??) landed as
https://crrev.com/126517868057958d2d5fddbc70e669ffd477a69d
Cr-Commit-Position: refs/heads/master@{#309281}

https://codereview.chromium.org/802843004/
Reply all
Reply to author
Forward
0 new messages