extensions: Port more extensions API tests to desktop Android, part 6 [chromium/src : main]

0 views
Skip to first unread message

James Cook (Gerrit)

unread,
Oct 23, 2025, 8:20:49 PM (5 days ago) Oct 23
to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Michael Wojcicka

James Cook voted and added 1 comment

Votes added by James Cook

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
James Cook . resolved

Michael, please take a look. The tryjobs were green on my last run and all I did in the final patchset was remove logs. If you see red, don't bother to review. :-)

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Wojcicka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
Gerrit-Change-Number: 7081138
Gerrit-PatchSet: 4
Gerrit-Owner: James Cook <jame...@chromium.org>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-Reviewer: Michael Wojcicka <mw...@google.com>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-Attention: Michael Wojcicka <mw...@google.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 00:20:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Wojcicka (Gerrit)

unread,
Oct 23, 2025, 8:57:43 PM (5 days ago) Oct 23
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from James Cook

Michael Wojcicka voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • James Cook
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
    Gerrit-Change-Number: 7081138
    Gerrit-PatchSet: 4
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Michael Wojcicka <mw...@google.com>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Attention: James Cook <jame...@chromium.org>
    Gerrit-Comment-Date: Fri, 24 Oct 2025 00:57:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    James Cook (Gerrit)

    unread,
    Oct 23, 2025, 10:14:19 PM (5 days ago) Oct 23
    to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    James Cook added 1 comment

    Patchset-level comments
    James Cook . resolved

    Thanks for the review! (And the bots are green, whew!) I'll land this when the upstream CLs are approved.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
    Gerrit-Change-Number: 7081138
    Gerrit-PatchSet: 4
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Michael Wojcicka <mw...@google.com>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Comment-Date: Fri, 24 Oct 2025 02:14:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    James Cook (Gerrit)

    unread,
    Oct 27, 2025, 2:27:09 PM (yesterday) Oct 27
    to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    James Cook voted and added 1 comment

    Votes added by James Cook

    Commit-Queue+2

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    James Cook . resolved

    Thanks for the review!

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
    Gerrit-Change-Number: 7081138
    Gerrit-PatchSet: 4
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Michael Wojcicka <mw...@google.com>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Comment-Date: Mon, 27 Oct 2025 18:27:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    James Cook (Gerrit)

    unread,
    Oct 27, 2025, 3:47:38 PM (yesterday) Oct 27
    to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    James Cook voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
    Gerrit-Change-Number: 7081138
    Gerrit-PatchSet: 4
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Michael Wojcicka <mw...@google.com>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-Comment-Date: Mon, 27 Oct 2025 19:47:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 27, 2025, 4:24:42 PM (yesterday) Oct 27
    to James Cook, Michael Wojcicka, Achuith Bhandarkar, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    extensions: Port more extensions API tests to desktop Android, part 6

    There have been some fixes to the underlying test framework that
    appear to have fixed some tests that were flaky. Enable them.
    Bug: 405219117
    Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
    Reviewed-by: Michael Wojcicka <mw...@google.com>
    Commit-Queue: James Cook <jame...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1536196}
    Files:
    • M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael Wojcicka
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0a2cb964107f07413125a3258da1dc7b8053642
    Gerrit-Change-Number: 7081138
    Gerrit-PatchSet: 5
    Gerrit-Owner: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-Reviewer: Michael Wojcicka <mw...@google.com>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages