[Desktop Android] Monitor muted state changes in TabsEventRouter [chromium/src : main]
0 views
Skip to first unread message
Devlin Cronin (Gerrit)
Jan 7, 2026, 7:51:28 PM (2 days ago) Jan 7
to Devlin Cronin, Darryl James, James Cook, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Darryl James and James Cook
Devlin Cronin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Devlin Cronin . resolved
Heya folks, mind taking a look?
James: Extension-y bits
Darryl: //chrome/browser/ui/tabs
Thanks in advance!
Related details
Attention is currently required from:
- Darryl James
- James Cook
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Jan 7, 2026, 9:08:20 PM (2 days ago) Jan 7
to Devlin Cronin, Darryl James, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Darryl James and Devlin Cronin
James Cook voted and added 1 comment![]( "Open in Gerrit")
Votes added by James Cook
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Darryl James
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darryl James (Gerrit)
Jan 8, 2026, 12:17:21 PM (22 hours ago) Jan 8
to Devlin Cronin, James Cook, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Darryl James voted and added 2 comments![]( "Open in Gerrit")
Votes added by Darryl James
| Code-Review | +1 |
2 comments
Patchset-level comments
Darryl James . resolved
lgtm!
Commit Message
Line 16, Patchset 5 (Latest):
This also changes the implementation of SetTabUdioMuted to set the muteDarryl James . unresolved
super duper nit: `SetTabUdioMuted` -> `SetTabAudioMuted`
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 8, 2026, 1:29:20 PM (21 hours ago) Jan 8
to Devlin Cronin, Darryl James, James Cook, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Devlin Cronin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Commit Message
Line 16, Patchset 5:
This also changes the implementation of SetTabUdioMuted to set the muteDarryl James . resolved
super duper nit: `SetTabUdioMuted` -> `SetTabAudioMuted`
Devlin Cronin
Good catch : ) Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 1:32:20 PM (21 hours ago) Jan 8
to Devlin Cronin, Darryl James, James Cook, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Desktop Android] Monitor muted state changes in TabsEventRouter
Today, muted state changes in tabs are observed in the tabs API by
listening for tab updated events from the TabStripModel. This won't
work on desktop android (since that platform doesn't have a
TabStripModel). Instead, listen for muted events from the tab's
WebContents itself via WebContents::DidUpdateAudioMutingState(). This
approach is viable on all platforms.
This also changes the implementation of SetTabAudioMuted to set the mute
metadata *before* setting the contents as muted. This is necessary for
this change so that the API sees the proper value when notified of the
mute change and may conceivably fix any other observers that were
monitoring this.
Bug: 473593117
Change-Id: Ibb62cb73c512510c089cbccf1a7cae8351550733
Reviewed-by: Darryl James <dlj...@chromium.org>
Reviewed-by: James Cook <jame...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566411}
Files:
- M chrome/browser/extensions/api/tabs/tabs_event_router.cc
- M chrome/browser/extensions/api/tabs/tabs_event_router.h
- M chrome/browser/ui/tabs/tab_muted_utils.cc
Change size: S
Delta: 3 files changed, 13 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darryl James, +1 by James Cook
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages