Replace base::Dictionary with base::Value::Dict [chromium/src : main]

David Bertoni (Gerrit)

unread,

Dec 21, 2022, 9:33:43 PM12/21/22

to Teresa Mao, chromium-a...@chromium.org, extension...@chromium.org, Ben Wells, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ben Wells, Teresa Mao.

Patch set 1:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  lgtm, thanks!

To view, visit change 4117699. To unsubscribe, or for help writing mail filters, visit settings.

Teresa Mao (Gerrit)

unread,

Dec 26, 2022, 2:00:28 PM12/26/22

to chromium-a...@chromium.org, extension...@chromium.org, David Bertoni, Ben Wells, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ben Wells, Teresa Mao.

Patch set 1:Commit-Queue +1

View Change

To view, visit change 4117699. To unsubscribe, or for help writing mail filters, visit settings.

Teresa Mao (Gerrit)

unread,

Dec 26, 2022, 2:06:33 PM12/26/22

to chromium-a...@chromium.org, extension...@chromium.org, David Bertoni, Ben Wells, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Ben Wells, Teresa Mao.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 4117699. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Dec 26, 2022, 2:44:42 PM12/26/22

to Teresa Mao, chromium-a...@chromium.org, extension...@chromium.org, David Bertoni, Ben Wells, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Teresa Mao: Commit
  David Bertoni: Looks good to me

Replace base::Dictionary with base::Value::Dict

Update outdated comment as part of cleaning up code. Doc: https://docs.google.com/document/d/1CwYuMXnVQsRsghwVzEkWj9GZzfERputSLQaKx5xLhjQ/edit#

Bug: 1187001
Change-Id: I618dbe6ab43e2aac83122af71532adf58fa12276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117699
Commit-Queue: Teresa Mao <te...@chromium.org>
Reviewed-by: David Bertoni <dber...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1087006}
---
M chrome/browser/extensions/api/resources_private/resources_private_api.cc
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/chrome/browser/extensions/api/resources_private/resources_private_api.cc b/chrome/browser/extensions/api/resources_private/resources_private_api.cc
index cf1df99..1628c01 100644
--- a/chrome/browser/extensions/api/resources_private/resources_private_api.cc
+++ b/chrome/browser/extensions/api/resources_private/resources_private_api.cc
@@ -32,7 +32,7 @@
 // To add a new component to this API, simply:
 // 1. Add your component to the Component enum in
 //      chrome/common/extensions/api/resources_private.idl
-// 2. Create an AddStringsForMyComponent(base::DictionaryValue * dict) method.
+// 2. Create an AddStringsForMyComponent(base::Value::Dict * dict) method.
 // 3. Tie in that method to the switch statement in Run()
 
 namespace extensions {

To view, visit change 4117699. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward