extensions: Enable more downloads API tests on desktop Android [chromium/src : main]
0 views
Skip to first unread message
James Cook (Gerrit)
Oct 27, 2025, 5:33:44 PM (6 days ago) Oct 27
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
James Cook added 1 comment![]( "Open in Gerrit")
File chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
Line 466, Patchset 3 (Latest):
CreateBrowserWindow(std::move(params), future.GetCallback());James Cook . unresolved
This never calls the callback.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Oct 27, 2025, 6:54:47 PM (6 days ago) Oct 27
to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Michael Wojcicka
James Cook added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
James Cook . resolved
Michael, please take a look. As we discussed on chat, I expect one or two of these tests to fail -- my local machine is wedged and won't tell me which test is failing. I'm just going to re-ifdef them out. Thanks!
File chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
Line 466, Patchset 3:
CreateBrowserWindow(std::move(params), future.GetCallback());James Cook . resolved
This never calls the callback.
James Cook
From a previous discussion with another engineer. It never calls the callback for incognito profiles, which is why this function is ifdef'd out still.
Related details
Attention is currently required from:
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
Oct 27, 2025, 7:20:58 PM (6 days ago) Oct 27
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from James Cook
Michael Wojcicka voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Wojcicka
| Code-Review | +1 |
1 comment
Patchset-level comments
Michael Wojcicka . resolved
Looks fine to me. Ack. about the test failure!
Related details
Attention is currently required from:
- James Cook
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Oct 27, 2025, 8:03:51 PM (6 days ago) Oct 27
to Michael Wojcicka, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
James Cook voted and added 1 comment![]( "Open in Gerrit")
Votes added by James Cook
| Commit-Queue | +2 |
1 comment
Patchset-level comments
James Cook . resolved
Bots are all green. The trouble was that I run my local avd.py emulator with --enable-network so I can browse the web. The bots don't do that, and it changes Chrome's internal networking behavior enough to make these tests fail locally. But now I know how to work on them locally and they'll pass on the bots. Thanks for the review!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 27, 2025, 8:06:42 PM (6 days ago) Oct 27
to James Cook, Michael Wojcicka, Achuith Bhandarkar, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
extensions: Enable more downloads API tests on desktop Android
Convert the usage of Browser to BrowserWindowInterface. There are
still some issues to be worked out before we can enable the incognito
tests, however.
Bug: 405219117
Change-Id: I8d95192e4f95c7a009b40e2cfa7babdc30448df7
Reviewed-by: Michael Wojcicka <mw...@google.com>
Commit-Queue: James Cook <jame...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536338}
Files:
- M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
- M chrome/test/BUILD.gn
Change size: M
Delta: 2 files changed, 33 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Wojcicka
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages