Don't pin NotebookLM for family link supervised users [chromium/src : main]

0 views
Skip to first unread message

James Cook (Gerrit)

unread,
Mar 11, 2026, 11:26:33 AM (yesterday) Mar 11
to Alan Cutter, Tomek Jurkiewicz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, oshima...@chromium.org
Attention needed from Alan Cutter

James Cook voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Cutter
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I20c639e83f6ad4810eb968831b726353b1a06dbb
Gerrit-Change-Number: 7651280
Gerrit-PatchSet: 4
Gerrit-Owner: Alan Cutter <alanc...@google.com>
Gerrit-Reviewer: Alan Cutter <alanc...@google.com>
Gerrit-Reviewer: James Cook <jame...@chromium.org>
Gerrit-CC: Tomek Jurkiewicz <t...@google.com>
Gerrit-Attention: Alan Cutter <alanc...@google.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 15:26:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tomek Jurkiewicz (Gerrit)

unread,
Mar 11, 2026, 1:35:22 PM (23 hours ago) Mar 11
to Alan Cutter, James Cook, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, oshima...@chromium.org
Attention needed from Alan Cutter

Tomek Jurkiewicz added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tomek Jurkiewicz . unresolved

Hey,

I'm unsure if we should move forward with this for two reasons: one logical, and one technical.

The logical reason is whether really all Family Link users, including eg. Geller ones, should not be able to use notebook LM. From the bug description it is not clear if notebook LM is not working for all types of Family Link users, or only some.

Your have some alternatives: the best is to use some capability (see [example capability](https://g3doc.corp.google.com/identity/accountcapabilities/definitions/chrome/canusegeminiinchrome/README.md?cl=head) - but you probably shouldn't use this specific one).

The other alternative comes from the technical aspect: indeed, kSupervisedUserId checks if the user is Family Link, but it's not a good idea to gate all possible features behind one pref. Maybe you should create your own preference, which is just enabled alongside kSupervisedUserId?

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Cutter
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I20c639e83f6ad4810eb968831b726353b1a06dbb
    Gerrit-Change-Number: 7651280
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alan Cutter <alanc...@google.com>
    Gerrit-Reviewer: Alan Cutter <alanc...@google.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-CC: Tomek Jurkiewicz <t...@google.com>
    Gerrit-Attention: Alan Cutter <alanc...@google.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 17:35:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    James Lee (Gerrit)

    unread,
    3:41 AM (9 hours ago) 3:41 AM
    to Alan Cutter, James Cook, Tomek Jurkiewicz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, oshima...@chromium.org
    Attention needed from Alan Cutter

    James Lee added 1 comment

    Patchset-level comments
    Tomek Jurkiewicz . unresolved

    Hey,

    I'm unsure if we should move forward with this for two reasons: one logical, and one technical.

    The logical reason is whether really all Family Link users, including eg. Geller ones, should not be able to use notebook LM. From the bug description it is not clear if notebook LM is not working for all types of Family Link users, or only some.

    Your have some alternatives: the best is to use some capability (see [example capability](https://g3doc.corp.google.com/identity/accountcapabilities/definitions/chrome/canusegeminiinchrome/README.md?cl=head) - but you probably shouldn't use this specific one).

    The other alternative comes from the technical aspect: indeed, kSupervisedUserId checks if the user is Family Link, but it's not a good idea to gate all possible features behind one pref. Maybe you should create your own preference, which is just enabled alongside kSupervisedUserId?

    James Lee

    +1: this check should be based on a new Account Capability which accurately reflects "is this account eligible for NotebookLM".

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alan Cutter
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I20c639e83f6ad4810eb968831b726353b1a06dbb
    Gerrit-Change-Number: 7651280
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alan Cutter <alanc...@google.com>
    Gerrit-Reviewer: Alan Cutter <alanc...@google.com>
    Gerrit-Reviewer: James Cook <jame...@chromium.org>
    Gerrit-CC: James Lee <ljj...@google.com>
    Gerrit-CC: Tomek Jurkiewicz <t...@google.com>
    Gerrit-Attention: Alan Cutter <alanc...@google.com>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 07:41:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Tomek Jurkiewicz <t...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages