Log Wallet private pass consent from settings [chromium/src : main]
0 views
Skip to first unread message
Florian Leimgruber (Gerrit)
Apr 1, 2026, 8:36:56 AM (yesterday) Apr 1
to Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Vidhan Jain
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
Apr 1, 2026, 9:03:11 AM (yesterday) Apr 1
to Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Florian Leimgruber
Vidhan Jain added 3 comments![]( "Open in Gerrit")
File chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
Line 1202, Patchset 2 (Latest):
consent_auditor::ConsentAuditor::SessionId session_id;Vidhan Jain . unresolved
Default to `ConsentAuditor::GenerateSessionId()`?
Line 1213, Patchset 2 (Latest):
entity_instance, consent_auditor::ConsentAuditor::GenerateSessionId(),Vidhan Jain . unresolved
`session_id`?
File chrome/browser/extensions/api/autofill_private/autofill_private_api_unittest.cc
Line 670, Patchset 2 (Latest):
EXPECT_CALL(consent_auditor(), RecordWalletPrivatePassConsent);Vidhan Jain . unresolved
We could update the mock expectations to capture the session_id returned by `RecordWalletPrivatePassConsent` and verify that the exact same ID is passed into `SaveWalletEntityInstance`?
Related details
Attention is currently required from:
- Florian Leimgruber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
Apr 1, 2026, 9:12:14 AM (yesterday) Apr 1
to Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Florian Leimgruber
Vidhan Jain added 1 comment![]( "Open in Gerrit")
File chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
Default to `ConsentAuditor::GenerateSessionId()`?
Vidhan Jain
On a second thought, it makes sense to use the placeholder value when `kWalletApiPrivatePassesConsent` is disabled. I assume we don't log the consent in that case.
Related details
Attention is currently required from:
- Florian Leimgruber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
Apr 1, 2026, 9:25:35 AM (yesterday) Apr 1
to Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Vidhan Jain
Florian Leimgruber voted and added 3 comments![]( "Open in Gerrit")
Votes added by Florian Leimgruber
| Commit-Queue | +1 |
3 comments
File chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
Line 1202, Patchset 2:
consent_auditor::ConsentAuditor::SessionId session_id;Vidhan Jain . resolved
Default to `ConsentAuditor::GenerateSessionId()`?
Florian Leimgruber
Exactly, it doesn't matter. The current implementation just constructs an invalid ID - but since it's never read when kWalletApiPrivatePassesConsent is disabled, that's ok.
Line 1213, Patchset 2:
entity_instance, consent_auditor::ConsentAuditor::GenerateSessionId(),Vidhan Jain . resolved
Florian Leimgruber`session_id`?
Thanks, done 🤦♂️
File chrome/browser/extensions/api/autofill_private/autofill_private_api_unittest.cc
Line 670, Patchset 2:
EXPECT_CALL(consent_auditor(), RecordWalletPrivatePassConsent);Vidhan Jain . resolved
We could update the mock expectations to capture the session_id returned by `RecordWalletPrivatePassConsent` and verify that the exact same ID is passed into `SaveWalletEntityInstance`?
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
Apr 1, 2026, 9:45:20 AM (yesterday) Apr 1
to Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Florian Leimgruber
Vidhan Jain voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Florian Leimgruber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
Apr 1, 2026, 9:49:50 AM (yesterday) Apr 1
to Viktor Semeniuk, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Viktor Semeniuk
Florian Leimgruber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Florian Leimgruber
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Florian Leimgruber . resolved
Hi Viktor, could you PTAL at the comment changes in chrome/browser/resources/settings/autofill_page/*?
Related details
Attention is currently required from:
- Viktor Semeniuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
5:47 AM (9 hours ago) 5:47 AM
to Viktor Semeniuk, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Viktor Semeniuk
Florian Leimgruber added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Florian Leimgruber . resolved
ping
Related details
Attention is currently required from:
- Viktor Semeniuk
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Viktor Semeniuk (Gerrit)
6:05 AM (9 hours ago) 6:05 AM
to Florian Leimgruber, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Florian Leimgruber
Viktor Semeniuk voted and added 1 comment![]( "Open in Gerrit")
Votes added by Viktor Semeniuk
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Florian Leimgruber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
6:13 AM (9 hours ago) 6:13 AM
to Viktor Semeniuk, Vidhan Jain, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Florian Leimgruber voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:16 AM (9 hours ago) 6:16 AM
to Florian Leimgruber, Viktor Semeniuk, Vidhan Jain, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Log Wallet private pass consent from settings
See the description of crrev.com/c/7698856 for some general context
around consent logging for Wallet private passes.
This CL implements logging the consent for newly created Wallet private
passes from settings, by calling RecordWalletPrivatePassConsent() with
hardcoded string IDs of the save dialog before calling the Wallet API.
See crrev.com/c/7706320 as for why the string IDs need to be hardcoded.
Bug: 489354073
Change-Id: Ie761e152b4bd22aa723b149f11f2bfccaf083332
Reviewed-by: Vidhan Jain <vid...@google.com>
Reviewed-by: Viktor Semeniuk <vsem...@google.com>
Commit-Queue: Florian Leimgruber <fleim...@google.com>
Cr-Commit-Position: refs/heads/main@{#1609083}
Files:
- M chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
- M chrome/browser/extensions/api/autofill_private/autofill_private_api_unittest.cc
- M chrome/browser/resources/settings/autofill_page/autofill_ai_add_or_edit_dialog.html
- M chrome/browser/resources/settings/autofill_page/autofill_ai_add_or_edit_dialog.ts
Change size: M
Delta: 4 files changed, 57 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vidhan Jain, +1 by Viktor Semeniuk
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages