[Extensions] Make test equality parameters order-agnostic [chromium/src : main]

0 views
Skip to first unread message

Kyle Horimoto (Gerrit)

unread,
Apr 1, 2026, 4:00:54 PM (23 hours ago) Apr 1
to Justin Lulejian, Kyle Horimoto, Emilia Paz, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz, Justin Lulejian and Tim

Kyle Horimoto voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
  • Justin Lulejian
  • Tim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic42835e2229f682e10d7954c9dd74a8d7b29d449
Gerrit-Change-Number: 7719138
Gerrit-PatchSet: 5
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Tim <tjud...@chromium.org>
Gerrit-Attention: Justin Lulejian <jlul...@chromium.org>
Gerrit-Attention: Emilia Paz <emil...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 20:00:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
12:47 PM (2 hours ago) 12:47 PM
to Justin Lulejian, Kyle Horimoto, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Justin Lulejian and Tim

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Emilia Paz . resolved

Thanks Justin!

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Lulejian
  • Tim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic42835e2229f682e10d7954c9dd74a8d7b29d449
Gerrit-Change-Number: 7719138
Gerrit-PatchSet: 5
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Tim <tjud...@chromium.org>
Gerrit-Attention: Justin Lulejian <jlul...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 16:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tim (Gerrit)

unread,
2:23 PM (1 hour ago) 2:23 PM
to Justin Lulejian, Kyle Horimoto, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Justin Lulejian

Tim voted and added 4 comments

Votes added by Tim

Code-Review+1

4 comments

Patchset-level comments
Tim . resolved

Thanks Justin. LGTM, with just a couple small nits!

File chrome/test/data/extensions/api_test/apitest/background.js
Line 21, Patchset 5 (Latest): '\nAPI Test Error in testAssertEq\n' +
'{"test":1} did not deep-equal null\n' +
'API Test Error in testAssertEq\n' +
'null did not deep-equal {"test":1}',
messages);
Tim . unresolved

nit: Did `git cl format --js` format it with this indentation?

File extensions/common/api/test.json
Line 221, Patchset 5 (Parent): // These need to be optional because they can be null.
Tim . unresolved

nit: any specific reason you removed this comment here and below, but not in the middle?

File extensions/renderer/resources/test_custom_bindings.js
Line 512, Patchset 5 (Latest): '\nExpected unequal values, but both are ' + $JSON.stringify(value);
Tim . unresolved

optional: While we're here, let's template this string:
```
`\nExpected unequal values, but both are ${$JSON.stringify(value)}`;
```

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Lulejian
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic42835e2229f682e10d7954c9dd74a8d7b29d449
Gerrit-Change-Number: 7719138
Gerrit-PatchSet: 5
Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Justin Lulejian <jlul...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 18:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Lulejian (Gerrit)

unread,
2:27 PM (1 hour ago) 2:27 PM
to Tim, Kyle Horimoto, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Justin Lulejian voted and added 3 comments

Votes added by Justin Lulejian

Auto-Submit+1
Commit-Queue+2

3 comments

File chrome/test/data/extensions/api_test/apitest/background.js
Line 21, Patchset 5 (Latest): '\nAPI Test Error in testAssertEq\n' +
'{"test":1} did not deep-equal null\n' +
'API Test Error in testAssertEq\n' +
'null did not deep-equal {"test":1}',
messages);
Tim . resolved

nit: Did `git cl format --js` format it with this indentation?

Justin Lulejian

Unfortunately yes 😞

File extensions/common/api/test.json
Line 221, Patchset 5 (Parent): // These need to be optional because they can be null.
Tim . resolved

nit: any specific reason you removed this comment here and below, but not in the middle?

Justin Lulejian

Nope, reverted! Thanks for the catch.

File extensions/renderer/resources/test_custom_bindings.js
Line 512, Patchset 5 (Latest): '\nExpected unequal values, but both are ' + $JSON.stringify(value);
Tim . resolved

optional: While we're here, let's template this string:
```
`\nExpected unequal values, but both are ${$JSON.stringify(value)}`;
```

Justin Lulejian

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic42835e2229f682e10d7954c9dd74a8d7b29d449
    Gerrit-Change-Number: 7719138
    Gerrit-PatchSet: 5
    Gerrit-Owner: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Justin Lulejian <jlul...@chromium.org>
    Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 18:27:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Tim <tjud...@chromium.org>
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages