Aida Zolic (Gerrit)

unread,

Dec 27, 2023, 8:10:02 AM12/27/23

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #10 to this change.

View Change

[Skyvault] POC

Start of the Skyvault Clippy POC.

Currently supports (different versions listed, newer always superset):
 - PS3
   - Saving screenshots in OneDrive (through Downloads)
   - Hiding all non-cloud volumes from the Files App (just UI)
   -
 - PS4
   - Saving screenshots to OneDrive (through temp dir)
   - Hiding all non-cloud volumes from the Files App (not mounted or ReadOnly)
 - PS6
   - Saving video captures to OneDrive
 - PS8
  - Allow seeing OneDrive from any files app dialog
  - Removes notifications from UploadToCloud IOTasks when part of screen captures

To work, requires enabling Clippy, the new NavigationTree,
and CloudUpload.

Change-Id: I636ea2bb0d33645162f293cfc192f87c0c150f0d
Bug:b:311672644
---
M ash/capture_mode/capture_mode_controller.cc
M ash/capture_mode/capture_mode_controller.h
M ash/capture_mode/test_capture_mode_delegate.cc
M ash/capture_mode/test_capture_mode_delegate.h
M ash/public/cpp/capture_mode/capture_mode_delegate.h
M chrome/browser/ash/extensions/file_manager/private_api_util.cc
M chrome/browser/ash/file_manager/file_manager_string_util.cc
M chrome/browser/ash/file_manager/url_util.cc
M chrome/browser/chromeos/policy/dlp/dlp_files_controller.cc
M chrome/browser/chromeos/policy/dlp/dlp_files_controller.h
M chrome/browser/chromeos/upload_office_to_cloud/upload_office_to_cloud.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.h
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.h
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h
M ui/file_manager/file_manager/common/js/flags.ts
M ui/file_manager/file_manager/containers/directory_tree_container.ts
M ui/file_manager/file_manager/state/ducks/navigation.ts
20 files changed, 337 insertions(+), 28 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Dec 28, 2023, 6:01:20 AM12/28/23

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #11 to this change.

View Change

20 files changed, 355 insertions(+), 40 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Dec 28, 2023, 8:51:53 AM12/28/23

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #12 to this change.

View Change

M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.h


M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.h
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h
M ui/file_manager/file_manager/common/js/flags.ts
M ui/file_manager/file_manager/containers/directory_tree_container.ts
M ui/file_manager/file_manager/state/ducks/navigation.ts

22 files changed, 393 insertions(+), 74 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Dec 29, 2023, 12:22:26 PM12/29/23

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #13 to this change.

View Change

M chrome/browser/BUILD.gn


M chrome/browser/ash/extensions/file_manager/private_api_util.cc
M chrome/browser/ash/file_manager/file_manager_string_util.cc
M chrome/browser/ash/file_manager/url_util.cc
M chrome/browser/chromeos/policy/dlp/dlp_files_controller.cc
M chrome/browser/chromeos/policy/dlp/dlp_files_controller.h
M chrome/browser/chromeos/upload_office_to_cloud/upload_office_to_cloud.cc

M chrome/browser/download/chrome_download_manager_delegate.cc
M chrome/browser/download/chrome_download_manager_delegate.h
A chrome/browser/download/download_cloud_uploader.cc
A chrome/browser/download/download_cloud_uploader.h
M chrome/browser/download/download_target_determiner.cc


M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.h
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.h
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.h
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h

M components/download/internal/common/download_item_impl.cc
M components/download/internal/common/download_item_impl_delegate.cc
M components/download/public/common/download_item_impl.h
M components/download/public/common/download_item_impl_delegate.h
M content/browser/download/download_manager_impl.cc
M content/browser/download/download_manager_impl.h
M content/public/browser/download_manager_delegate.h


M ui/file_manager/file_manager/common/js/flags.ts
M ui/file_manager/file_manager/containers/directory_tree_container.ts
M ui/file_manager/file_manager/state/ducks/navigation.ts

35 files changed, 549 insertions(+), 76 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Dec 29, 2023, 12:26:16 PM12/29/23

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #14 to this change.

View Change

[Skyvault] POC

Start of the Skyvault Clippy POC.

Currently supports (different versions listed, newer always superset):
 - PS3
   - Saving screenshots in OneDrive (through Downloads)
   - Hiding all non-cloud volumes from the Files App (just UI)
   -
 - PS4
   - Saving screenshots to OneDrive (through temp dir)
   - Hiding all non-cloud volumes from the Files App (not mounted or ReadOnly)
 - PS6
   - Saving video captures to OneDrive
 - PS8
  - Allow seeing OneDrive from any files app dialog
  - Removes notifications from UploadToCloud IOTasks when part of screen captures

 - PS13
  - Downloads uploaded to OneDrive (through temp dir)
  - TODO: Allow the user to select a location in OneDrive vs uploading only to home dir

Aida Zolic (Gerrit)

unread,

Jan 2, 2024, 12:11:00 PM1/2/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #15 to this change.

View Change

M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc
M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.h


M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.h
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.h
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h
M components/download/internal/common/download_item_impl.cc
M components/download/internal/common/download_item_impl_delegate.cc
M components/download/public/common/download_item_impl.h
M components/download/public/common/download_item_impl_delegate.h
M content/browser/download/download_manager_impl.cc
M content/browser/download/download_manager_impl.h
M content/public/browser/download_manager_delegate.h
M ui/file_manager/file_manager/common/js/flags.ts
M ui/file_manager/file_manager/containers/directory_tree_container.ts
M ui/file_manager/file_manager/state/ducks/navigation.ts

37 files changed, 1,188 insertions(+), 245 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 3, 2024, 8:56:46 AM1/3/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Attention is currently required from: Aya Elsayed, Sergey Poromov.

Aida Zolic uploaded patch set #16 to this change.

View Change

37 files changed, 1,191 insertions(+), 245 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 4, 2024, 5:41:40 AM1/4/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #17 to this change.

View Change

35 files changed, 1,162 insertions(+), 244 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 4, 2024, 5:48:13 AM1/4/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #18 to this change.

View Change

35 files changed, 1,171 insertions(+), 244 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 4, 2024, 9:01:48 AM1/4/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #19 to this change.

View Change

M chrome/browser/ash/extensions/file_manager/private_api_util.cc
M chrome/browser/ash/file_manager/file_manager_string_util.cc
M chrome/browser/ash/file_manager/url_util.cc
M chrome/browser/chromeos/upload_office_to_cloud/upload_office_to_cloud.cc
M chrome/browser/download/chrome_download_manager_delegate.cc
M chrome/browser/download/chrome_download_manager_delegate.h

M chrome/browser/download/download_target_determiner.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.h
M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc
M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.h

M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_util.cc


M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.h
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.h
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h
M components/download/internal/common/download_item_impl.cc
M components/download/internal/common/download_item_impl_delegate.cc
M components/download/public/common/download_item_impl.h
M components/download/public/common/download_item_impl_delegate.h
M content/browser/download/download_manager_impl.cc
M content/browser/download/download_manager_impl.h
M content/public/browser/download_manager_delegate.h
M ui/file_manager/file_manager/common/js/flags.ts
M ui/file_manager/file_manager/containers/directory_tree_container.ts
M ui/file_manager/file_manager/state/ducks/navigation.ts

33 files changed, 1,096 insertions(+), 247 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 8, 2024, 5:04:15 AM1/8/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #20 to this change.

View Change

33 files changed, 1,160 insertions(+), 247 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 8, 2024, 7:14:00 AM1/8/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #21 to this change.

View Change

M chrome/browser/chromeos/policy/dlp/dlp_files_controller.h

34 files changed, 1,162 insertions(+), 236 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 8, 2024, 8:01:33 AM1/8/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #22 to this change.

View Change

M chrome/browser/ash/file_manager/volume_manager.cc

34 files changed, 1,178 insertions(+), 263 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 9, 2024, 7:35:16 AM1/9/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #23 to this change.

View Change

34 files changed, 1,171 insertions(+), 256 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 9, 2024, 7:48:00 AM1/9/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #24 to this change.

View Change

34 files changed, 1,172 insertions(+), 251 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 9, 2024, 7:50:38 AM1/9/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #25 to this change.

View Change

34 files changed, 1,170 insertions(+), 251 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 9, 2024, 9:43:17 AM1/9/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #26 to this change.

View Change

M chrome/browser/download/chrome_download_manager_delegate.cc
M chrome/browser/download/chrome_download_manager_delegate.h
M chrome/browser/download/download_target_determiner.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.cc
M chrome/browser/ui/ash/capture_mode/chrome_capture_mode_delegate.h
M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc
M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.h
M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_util.cc
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.h
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.cc
M chrome/browser/ui/webui/ash/cloud_upload/one_drive_upload_handler.h
M chrome/common/chrome_features.cc
M chrome/common/chrome_features.h
M components/download/internal/common/download_item_impl.cc
M components/download/internal/common/download_item_impl_delegate.cc
M components/download/public/common/download_item_impl.h
M components/download/public/common/download_item_impl_delegate.h
M content/browser/download/download_manager_impl.cc
M content/browser/download/download_manager_impl.h
M content/public/browser/download_manager_delegate.h
M ui/file_manager/file_manager/common/js/flags.ts
M ui/file_manager/file_manager/containers/directory_tree_container.ts
M ui/file_manager/file_manager/state/ducks/navigation.ts

33 files changed, 1,169 insertions(+), 250 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 10, 2024, 12:39:52 PM1/10/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #27 to this change.

View Change

33 files changed, 1,232 insertions(+), 265 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Jan 10, 2024, 1:06:37 PM1/10/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org

Aida Zolic uploaded patch set #28 to this change.

View Change

33 files changed, 1,232 insertions(+), 263 deletions(-)

To view, visit change 5119720. To unsubscribe, or for help writing mail filters, visit settings.

Aida Zolic (Gerrit)

unread,

Feb 7, 2024, 9:28:40 AM2/7/24

to chromium-a...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, greengra...@google.com, michaelpg+wa...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, Sergey Poromov, Aya Elsayed, chromium...@chromium.org

Aida Zolic abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[Skyvault] POC [chromium/src : main]

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic (Gerrit)

Aida Zolic abandoned this change

Related details