Buganizer components for Smartcard [chromium/src : main]

5 views
Skip to first unread message

Maksim Ivanov (Gerrit)

unread,
Nov 29, 2022, 9:24:49 PM11/29/22
to Fabian Sommer, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org

Attention is currently required from: Fabian Sommer.

Maksim Ivanov would like Fabian Sommer to review this change.

View Change

Buganizer components for Smartcard

Update metadata to use Buganizer component IDs instead of the
(deprecated) Monorail ones.

Bug: none
Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
---
M chrome/browser/certificate_provider/DIR_METADATA
M chrome/browser/extensions/api/certificate_provider/DIR_METADATA
M chrome/test/data/extensions/api_test/certificate_provider/DIR_METADATA
M chrome/test/data/extensions/signin_screen_manual_test_app/DIR_METADATA
M chromeos/components/certificate_provider/DIR_METADATA
M chromeos/components/security_token_pin/DIR_METADATA
6 files changed, 43 insertions(+), 12 deletions(-)


To view, visit change 4064760. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
Gerrit-Change-Number: 4064760
Gerrit-PatchSet: 1
Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
Gerrit-Attention: Fabian Sommer <fabian...@chromium.org>
Gerrit-MessageType: newchange

Maksim Ivanov (Gerrit)

unread,
Nov 29, 2022, 9:28:00 PM11/29/22
to chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, Fabian Sommer, chromium...@chromium.org

Attention is currently required from: Fabian Sommer.

Patch set 1:Auto-Submit +1

View Change

    To view, visit change 4064760. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
    Gerrit-Change-Number: 4064760
    Gerrit-PatchSet: 1
    Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
    Gerrit-Attention: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Comment-Date: Wed, 30 Nov 2022 02:24:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Maksim Ivanov (Gerrit)

    unread,
    Nov 29, 2022, 9:37:19 PM11/29/22
    to valeb...@google.com, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, Fabian Sommer

    Attention is currently required from: Fabian Sommer.

    Maksim Ivanov has uploaded this change for review.

    View Change

    Buganizer components for Smartcard

    Update metadata to use Buganizer component IDs instead of the
    (deprecated) Monorail ones.

    Bug: none
    Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
    ---
    M chrome/browser/certificate_provider/DIR_METADATA
    M chrome/browser/extensions/api/certificate_provider/DIR_METADATA
    M chrome/test/data/extensions/api_test/certificate_provider/DIR_METADATA
    M chrome/test/data/extensions/signin_screen_manual_test_app/DIR_METADATA
    M chromeos/components/certificate_provider/DIR_METADATA
    M chromeos/components/security_token_pin/DIR_METADATA
    6 files changed, 43 insertions(+), 12 deletions(-)


    To view, visit change 4064760. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
    Gerrit-Change-Number: 4064760
    Gerrit-PatchSet: 1
    Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
    Gerrit-Attention: Fabian Sommer <fabian...@chromium.org>
    Gerrit-MessageType: newchange

    Fabian Sommer (Gerrit)

    unread,
    Nov 30, 2022, 7:18:50 AM11/30/22
    to Maksim Ivanov, valeb...@google.com, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, chromium...@chromium.org

    Attention is currently required from: Maksim Ivanov.

    Patch set 1:Code-Review +1Commit-Queue +2

    View Change

    1 comment:

    To view, visit change 4064760. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
    Gerrit-Change-Number: 4064760
    Gerrit-PatchSet: 1
    Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
    Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
    Gerrit-Comment-Date: Wed, 30 Nov 2022 12:15:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 30, 2022, 8:22:17 AM11/30/22
    to Maksim Ivanov, valeb...@google.com, chromium-a...@chromium.org, extension...@chromium.org, oshima...@chromium.org, Fabian Sommer, chromium...@chromium.org

    Chromium LUCI CQ submitted this change.

    View Change

    Approvals: Fabian Sommer: Looks good to me; Commit Maksim Ivanov: Send CL to CQ automatically after approval
    Buganizer components for Smartcard

    Update metadata to use Buganizer component IDs instead of the
    (deprecated) Monorail ones.

    Bug: none
    Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064760
    Auto-Submit: Maksim Ivanov <em...@chromium.org>
    Reviewed-by: Fabian Sommer <fabian...@chromium.org>
    Commit-Queue: Fabian Sommer <fabian...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1077434}

    ---
    M chrome/browser/certificate_provider/DIR_METADATA
    M chrome/browser/extensions/api/certificate_provider/DIR_METADATA
    M chrome/test/data/extensions/api_test/certificate_provider/DIR_METADATA
    M chrome/test/data/extensions/signin_screen_manual_test_app/DIR_METADATA
    M chromeos/components/certificate_provider/DIR_METADATA
    M chromeos/components/security_token_pin/DIR_METADATA
    6 files changed, 48 insertions(+), 12 deletions(-)


    To view, visit change 4064760. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I98835238aa01f23df5a6064cd7ce6c075ddbf5ba
    Gerrit-Change-Number: 4064760
    Gerrit-PatchSet: 2
    Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fabian Sommer <fabian...@chromium.org>
    Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
    Gerrit-MessageType: merged
    Reply all
    Reply to author
    Forward
    0 new messages