Move channel-related (Chrome-specific) global state out of Feature. (issue 22299009)

[y...@chromium.org]

Reviewers: Matt Perry,

Description:
Move channel-related (Chrome-specific) global state out of Feature.

BUG=162530

Please review this at https://codereview.chromium.org/22299009/

SVN Base: svn://svn.chromium.org/chrome/trunk/src

Affected files:
M
chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
M chrome/browser/extensions/api/app_window/app_window_api.cc
M
chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc
M
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
M chrome/browser/extensions/extension_browsertest.h
M chrome/browser/extensions/extension_service.cc
M chrome/browser/extensions/extension_system.cc
M chrome/browser/extensions/script_badge_controller_unittest.cc
M chrome/chrome_common.gypi
M
chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc
M chrome/common/extensions/features/base_feature_provider_unittest.cc
M chrome/common/extensions/features/complex_feature_unittest.cc
M chrome/common/extensions/features/feature.h
M chrome/common/extensions/features/feature.cc
A chrome/common/extensions/features/feature_channel.h
A chrome/common/extensions/features/feature_channel.cc
M chrome/common/extensions/features/simple_feature.cc
M chrome/common/extensions/features/simple_feature_unittest.cc
M
chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
M chrome/common/extensions/manifest_tests/extension_manifest_test.h
M
chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
M chrome/common/extensions/permissions/permission_set_unittest.cc
M chrome/common/extensions/permissions/permissions_data_unittest.cc
M chrome/renderer/extensions/dispatcher.cc
M chrome/renderer/extensions/module_system.cc

[mpcom...@chromium.org]

lgtm



https://codereview.chromium.org/22299009/

[commi...@chromium.org]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/y...@chromium.org/22299009/1


https://chromiumcodereview.appspot.com/22299009/

[commi...@chromium.org]

Change committed as 216613

https://chromiumcodereview.appspot.com/22299009/

[kal...@chromium.org]

What are you planning to do from there?

https://codereview.chromium.org/22299009/

[Yoyo Zhou]

Move Feature and Manifest to extensions/common.

sent from a tiny touchscreen

[Benjamin Kalman]

Features still rely on chrome channels though.

--
You received this message because you are subscribed to the Google Groups "Extensions reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email to extensions-revi...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/extensions-reviews/CAJcyfygirLyvp%2BMgH9og_STBkEj6_qy%2BmLZ3T4mzJnguAHi8ew%40mail.gmail.com?hl=en.
 
 

[Yoyo Zhou]

On Fri, Aug 9, 2013 at 5:10 PM, Benjamin Kalman <kal...@google.com> wrote:
> Features still rely on chrome channels though.

Our current implementation of features (e.g. SimpleFeature) does. But
some other content embedder could have a different features
implementation that doesn't know about channels.