[Extensions] Add OnUserPermissionsSettingsChanged() to menu model [chromium/src : main]

0 views
Skip to first unread message

Emilia Paz (Gerrit)

unread,
Oct 27, 2025, 7:01:45 PM (3 days ago) Oct 27
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Emilia Paz . resolved

Let's continue migrating methods :)

Open in Gerrit

Related details

Attention is currently required from:
  • Shuhei Takahashi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I92acf19fdd3ae03af4d3594182cbef4a895b7313
Gerrit-Change-Number: 7088589
Gerrit-PatchSet: 4
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
Gerrit-Attention: Shuhei Takahashi <n...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 23:01:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shuhei Takahashi (Gerrit)

unread,
Oct 27, 2025, 8:51:59 PM (3 days ago) Oct 27
to Emilia Paz, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz

Shuhei Takahashi voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I92acf19fdd3ae03af4d3594182cbef4a895b7313
    Gerrit-Change-Number: 7088589
    Gerrit-PatchSet: 4
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
    Gerrit-Attention: Emilia Paz <emil...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 00:51:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Emilia Paz (Gerrit)

    unread,
    Oct 28, 2025, 12:28:31 AM (3 days ago) Oct 28
    to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Emilia Paz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I92acf19fdd3ae03af4d3594182cbef4a895b7313
    Gerrit-Change-Number: 7088589
    Gerrit-PatchSet: 4
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 04:28:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 28, 2025, 12:31:50 AM (3 days ago) Oct 28
    to Emilia Paz, Shuhei Takahashi, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Extensions] Add OnUserPermissionsSettingsChanged() to menu model

    Move PermissionsManager::Observer::OnUserPermissionsSettingsChanged
    from the platform delegate views to the model.

    No functionality changed.
    Bug: 449814184
    Change-Id: I92acf19fdd3ae03af4d3594182cbef4a895b7313
    Commit-Queue: Emilia Paz <emil...@chromium.org>
    Auto-Submit: Emilia Paz <emil...@chromium.org>
    Reviewed-by: Shuhei Takahashi <n...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1536442}
    Files:
    • M chrome/browser/ui/extensions/extensions_menu_view_model.cc
    • M chrome/browser/ui/extensions/extensions_menu_view_model.h
    • M chrome/browser/ui/extensions/extensions_menu_view_model_browsertest.cc
    • M chrome/browser/ui/extensions/extensions_menu_view_platform_delegate.h
    • M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.cc
    • M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
    Change size: M
    Delta: 6 files changed, 45 insertions(+), 30 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Shuhei Takahashi
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I92acf19fdd3ae03af4d3594182cbef4a895b7313
    Gerrit-Change-Number: 7088589
    Gerrit-PatchSet: 5
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages