Erik Chen (Gerrit)

unread,

Aug 13, 2026, 2:24:21 PM (3 days ago) Aug 13

to Chris Thompson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Chromium LUCI CQ, droger+w...@chromium.org, aixba+wat...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, orinj...@chromium.org, pauladed...@google.com, philli...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Chris Thompson

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Chris Thompson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Thompson (Gerrit)

unread,

Aug 14, 2026, 1:49:49 PM (2 days ago) Aug 14

to Erik Chen, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Chromium LUCI CQ, droger+w...@chromium.org, aixba+wat...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, orinj...@chromium.org, pauladed...@google.com, philli...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Erik Chen

Chris Thompson voted and added 5 comments

Votes added by Chris Thompson

Code-Review

+1

5 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Chris Thompson . resolved

LGTM (% our previous discussion about agent over-formatting)

File chrome/browser/dom_distiller/tab_utils_browsertest.cc

Line 97, Patchset 13 (Latest):

    if (updated_) {
      return;
    }

Chris Thompson . unresolved

(And here)

File chrome/browser/download/download_ui_controller_unittest.cc

Line 63, Patchset 13 (Latest):

  if (receiver_.get()) {
    *receiver_ = item;
  }

Chris Thompson . unresolved

(And here)

File chrome/browser/webapps/webapps_client_android.cc

Line 131, Patchset 13 (Latest): const GURL& manifest_id) const {}

Chris Thompson . unresolved

(And here)

File chrome/browser/webapps/webapps_client_desktop.cc

Line 208, Patchset 13 (Latest):

      .RecordDismiss(
          web_app::GenerateAppIdFromManifestId(ManifestId(manifest_id)),
          base::Time::Now());

Chris Thompson . unresolved

(Some more cases of unrelated code lines reformatting)

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

Aug 14, 2026, 7:08:31 PM (2 days ago) Aug 14

to Chris Thompson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, Chromium LUCI CQ, droger+w...@chromium.org, aixba+wat...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, orinj...@chromium.org, pauladed...@google.com, philli...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Erik Chen voted and added 5 comments

Votes added by Erik Chen

Commit-Queue

+2

5 comments

Patchset-level comments

File-level comment, Patchset 13:

Chris Thompson . resolved

LGTM (% our previous discussion about agent over-formatting)

Erik Chen

fixed, sorry!

File chrome/browser/dom_distiller/tab_utils_browsertest.cc

Line 97, Patchset 13:

    if (updated_) {
      return;
    }

Chris Thompson . resolved

(And here)

Erik Chen

Done

File chrome/browser/download/download_ui_controller_unittest.cc

Line 63, Patchset 13:

  if (receiver_.get()) {
    *receiver_ = item;
  }

Chris Thompson . resolved

(And here)

Erik Chen

Done

File chrome/browser/webapps/webapps_client_android.cc

Line 131, Patchset 13: const GURL& manifest_id) const {}

Chris Thompson . resolved

(And here)

Erik Chen

Done

File chrome/browser/webapps/webapps_client_desktop.cc

Line 208, Patchset 13: .RecordDismiss(


          web_app::GenerateAppIdFromManifestId(ManifestId(manifest_id)),
          base::Time::Now());

Chris Thompson . resolved

(Some more cases of unrelated code lines reformatting)

Erik Chen

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 14, 2026, 7:13:36 PM (2 days ago) Aug 14

to Erik Chen, Chris Thompson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Permissions Reviews, droger+w...@chromium.org, aixba+wat...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, csharris...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, extension...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, orinj...@chromium.org, pauladed...@google.com, philli...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, vakh+safe_br...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

13 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/download/download_ui_controller_unittest.cc
Insertions: 4, Deletions: 6.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/dom_distiller/tab_utils_browsertest.cc
Insertions: 2, Deletions: 4.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/ui/views/location_bar/location_bar_view.cc
Insertions: 1, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/webapps/webapps_client_desktop.cc
Insertions: 5, Deletions: 8.

The diff is too large to show. Please review the diff.
```
```
The name of the file: chrome/browser/webapps/webapps_client_android.cc
Insertions: 6, Deletions: 3.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Delete SecurityStateTabHelper

The components-side base class is now referenced by nothing: its
Chrome subclass is gone, every read goes through free functions or
SecurityStateModelDelegate, and the remaining sixteen #includes across
chrome/ were all dead. Remove the class, its build entry and the dead
includes. Test fixture names that echo the old class name are left
as-is; they test security state behavior, which is unchanged.

This completes the removal started in the previous CLs: security
state is computed on demand from the WebContents (components free
functions, enriched by chrome_security_state in Chrome), the two
navigation side effects live in the TabFeatures-owned
SecurityStateEventObserver, and nothing stores security state as
WebContents user data anymore.

Bug: 540709814

Agent-Generated: true

Change-Id: I404fecffe118ef528bc8a754f35b598b02ff4979

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8180260

Commit-Queue: Erik Chen <erik...@chromium.org>

Reviewed-by: Chris Thompson <cth...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1680004}

Files:

M chrome/browser/android/webapk/webapk_restore_manager.cc
M chrome/browser/dom_distiller/tab_utils_browsertest.cc
M chrome/browser/download/download_ui_controller_unittest.cc
M chrome/browser/extensions/api/management/chrome_management_api_delegate_non_android.cc
M chrome/browser/lookalikes/safety_tip_ui_helper.cc
M chrome/browser/safe_browsing/android/suspicious_site_browsertest.cc
M chrome/browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc
M chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
M chrome/browser/ui/extensions/hosted_app_browser_controller.cc
M chrome/browser/ui/page_info/page_info_dialog.cc
M chrome/browser/ui/views/location_bar/location_bar_view.cc
M chrome/browser/ui/views/picture_in_picture/document_pip_frame_view_unittest.cc
M chrome/browser/ui/web_applications/app_browser_controller.cc
M chrome/browser/webapps/webapps_client_android.cc
M chrome/browser/webapps/webapps_client_desktop.cc
M components/security_state/content/BUILD.gn
M components/security_state/content/DEPS
D components/security_state/content/security_state_tab_helper.cc
D components/security_state/content/security_state_tab_helper.h

Change size: M

Delta: 19 files changed, 0 insertions(+), 136 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Chris Thompson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Delete SecurityStateTabHelper [chromium/src : main]

Erik Chen (Gerrit)

New activity on the change

Related details

Chris Thompson (Gerrit)

Chris Thompson voted and added 5 comments

Votes added by Chris Thompson

5 comments

Related details

Erik Chen (Gerrit)

Erik Chen voted and added 5 comments

Votes added by Erik Chen

5 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information