Move IsGuest from SiteInstance to SecurityPrincipal [chromium/src : main]

0 views
Skip to first unread message

Viktoriya Bryhider (Gerrit)

unread,
Jan 28, 2026, 8:12:49 PM (2 days ago) Jan 28
to Chromium LUCI CQ, chromium...@chromium.org, Kevin McNee, Hiroki Nakagawa, prerendering-reviews, James Su, James Maclean, ajwong...@chromium.org, alexmo...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org
Attention needed from Viktoriya Bryhider

Message from Viktoriya Bryhider

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Viktoriya Bryhider
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83770e386b2d73fee01e916240cab5b936b3ba52
Gerrit-Change-Number: 7234613
Gerrit-PatchSet: 13
Gerrit-Owner: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-Reviewer: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-Comment-Date: Thu, 29 Jan 2026 01:12:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Viktoriya Bryhider (Gerrit)

unread,
Jan 29, 2026, 2:34:29 PM (2 days ago) Jan 29
to Alex Moshchuk, Liang Zhao, Chromium LUCI CQ, chromium...@chromium.org, Kevin McNee, Hiroki Nakagawa, prerendering-reviews, James Su, James Maclean, ajwong...@chromium.org, alexmo...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org
Attention needed from Alex Moshchuk and Liang Zhao

Viktoriya Bryhider added 1 comment

Patchset-level comments
File-level comment, Patchset 14 (Latest):
Viktoriya Bryhider . resolved

IsGuest for SecurityPrincipal is green and should be reviewable - it is ok to do after or before GetStoragePartitionConfig. Thank you.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Moshchuk
  • Liang Zhao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83770e386b2d73fee01e916240cab5b936b3ba52
Gerrit-Change-Number: 7234613
Gerrit-PatchSet: 14
Gerrit-Owner: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Liang Zhao <lz...@microsoft.com>
Gerrit-Reviewer: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
Gerrit-Attention: Liang Zhao <lz...@microsoft.com>
Gerrit-Comment-Date: Thu, 29 Jan 2026 19:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Charlie Reis (Gerrit)

unread,
Jan 30, 2026, 3:50:49 PM (9 hours ago) Jan 30
to Viktoriya Bryhider, Alex Moshchuk, Liang Zhao, Chromium LUCI CQ, chromium...@chromium.org, Kevin McNee, Hiroki Nakagawa, prerendering-reviews, James Su, James Maclean, ajwong...@chromium.org, alexmo...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org
Attention needed from Alex Moshchuk, Liang Zhao and Viktoriya Bryhider

Charlie Reis voted and added 1 comment

Votes added by Charlie Reis

Code-Review+1

1 comment

Patchset-level comments
Charlie Reis . resolved

Thanks! LGTM as a good early use of SecurityPrincipal outside content/, and something that makes sense to access via SecurityPrincipal vs the more instance/BCG-specific SiteInstance. I don't feel strongly on the ordering, but I might recommend landing the IsSandboxed CL at https://chromium-review.googlesource.com/c/chromium/src/+/7243420 first, just because it's more clearly about a security property.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Moshchuk
  • Liang Zhao
  • Viktoriya Bryhider
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83770e386b2d73fee01e916240cab5b936b3ba52
Gerrit-Change-Number: 7234613
Gerrit-PatchSet: 14
Gerrit-Owner: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Charlie Reis <cr...@chromium.org>
Gerrit-Reviewer: Liang Zhao <lz...@microsoft.com>
Gerrit-Reviewer: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
Gerrit-Attention: Viktoriya Bryhider <vbry...@microsoft.com>
Gerrit-Attention: Liang Zhao <lz...@microsoft.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 20:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Liang Zhao (Gerrit)

unread,
Jan 30, 2026, 7:19:30 PM (5 hours ago) Jan 30
to Viktoriya Bryhider, Charlie Reis, Alex Moshchuk, Chromium LUCI CQ, chromium...@chromium.org, Kevin McNee, Hiroki Nakagawa, prerendering-reviews, James Su, James Maclean, ajwong...@chromium.org, alexmo...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org
Attention needed from Alex Moshchuk and Viktoriya Bryhider

Liang Zhao voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Moshchuk
  • Viktoriya Bryhider
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83770e386b2d73fee01e916240cab5b936b3ba52
    Gerrit-Change-Number: 7234613
    Gerrit-PatchSet: 14
    Gerrit-Owner: Viktoriya Bryhider <vbry...@microsoft.com>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Charlie Reis <cr...@chromium.org>
    Gerrit-Reviewer: Liang Zhao <lz...@microsoft.com>
    Gerrit-Reviewer: Viktoriya Bryhider <vbry...@microsoft.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Attention: Viktoriya Bryhider <vbry...@microsoft.com>
    Gerrit-Comment-Date: Sat, 31 Jan 2026 00:19:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Moshchuk (Gerrit)

    unread,
    Jan 30, 2026, 9:13:09 PM (3 hours ago) Jan 30
    to Viktoriya Bryhider, Kevin McNee, Liang Zhao, Charlie Reis, Chromium LUCI CQ, chromium...@chromium.org, Hiroki Nakagawa, prerendering-reviews, James Su, James Maclean, ajwong...@chromium.org, alexmo...@chromium.org, blink-work...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, tburkar...@chromium.org, tranbaod...@chromium.org, webap...@microsoft.com, yhanad...@chromium.org
    Attention needed from Kevin McNee and Viktoriya Bryhider

    Alex Moshchuk voted and added 1 comment

    Votes added by Alex Moshchuk

    Code-Review+1

    1 comment

    Patchset-level comments
    Alex Moshchuk . resolved

    LGTM as well. We could probably use OO+1 on this, as it's a straightforward content API change, but let me still add mcnee@ for the guest_view owner review, to help raise awareness about SecurityPrincipal (which will land first in https://chromium-review.googlesource.com/c/chromium/src/+/6919201). Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kevin McNee
    • Viktoriya Bryhider
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83770e386b2d73fee01e916240cab5b936b3ba52
    Gerrit-Change-Number: 7234613
    Gerrit-PatchSet: 14
    Gerrit-Owner: Viktoriya Bryhider <vbry...@microsoft.com>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Charlie Reis <cr...@chromium.org>
    Gerrit-Reviewer: Kevin McNee <mc...@chromium.org>
    Gerrit-Reviewer: Liang Zhao <lz...@microsoft.com>
    Gerrit-Reviewer: Viktoriya Bryhider <vbry...@microsoft.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Kevin McNee <mc...@chromium.org>
    Gerrit-Attention: Viktoriya Bryhider <vbry...@microsoft.com>
    Gerrit-Comment-Date: Sat, 31 Jan 2026 02:12:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages