[Extensions] Remove PermissionsManager::Observer from menu delegate [chromium/src : main]
0 views
Skip to first unread message
Emilia Paz (Gerrit)
Oct 27, 2025, 7:03:45 PM (3 days ago) Oct 27
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Emilia Paz . resolved
Last CL for PermissionsManager::Observer :)
Related details
Attention is currently required from:
- Shuhei Takahashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shuhei Takahashi (Gerrit)
Oct 27, 2025, 8:53:20 PM (3 days ago) Oct 27
to Emilia Paz, Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Shuhei Takahashi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 28, 2025, 12:30:08 PM (2 days ago) Oct 28
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Emilia Paz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 28, 2025, 12:33:16 PM (2 days ago) Oct 28
to Shuhei Takahashi, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Emilia Paz voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 28, 2025, 12:36:34 PM (2 days ago) Oct 28
to Emilia Paz, Shuhei Takahashi, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Extensions] Remove PermissionsManager::Observer from menu delegate
Remove PermissionsManager::Observer from the menu platform delegate for
Views since every method has been migrated to the menu model.
This CL also renamed methods that had a name collision while the
observer was both in the menu model and menu platform delegate views.
No functionality changed.
Bug: 449814184
Change-Id: I690aa392ea689dad2a045d0a6cb727a6053f7e10
Reviewed-by: Shuhei Takahashi <n...@chromium.org>
Commit-Queue: Emilia Paz <emil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536727}
Files:
- M chrome/browser/ui/extensions/extensions_menu_view_model.cc
- M chrome/browser/ui/extensions/extensions_menu_view_model_browsertest.cc
- M chrome/browser/ui/extensions/extensions_menu_view_platform_delegate.h
- M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.cc
- M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
Change size: M
Delta: 5 files changed, 19 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Shuhei Takahashi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages