PoC: Skip extension initialization for per-navigation [chromium/src : main]
Eriko Kurimoto (Gerrit)
Eriko Kurimoto added 1 comment![]( "Open in Gerrit")
@rak...@chromium.org May I ask you for an initial review?
This cl aims to disable extension per-navigation only for our navigation, and I'm judging the navigation.
Related details
- Rakina Zata Amni
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eriko Kurimoto (Gerrit)
Eriko Kurimoto added 1 comment![]( "Open in Gerrit")
@rak...@chromium.org May I ask you for an initial review?
This cl aims to disable extension per-navigation only for our navigation, and I'm judging the navigation.
ops, i sent the message in the middle of the text.
I'm judging the navigation by `IsInitialWebUINavigation`
Related details
- Rakina Zata Amni
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Rakina Zata Amni added 5 comments![]( "Open in Gerrit")
Thanks!
if (!skip_extensions) {Is this still needed with the in-renderer resource loading flag?
void ExtensionWebContentsObserver::ReadyToCommitNavigation(I wonder if ReadyToCommit is a bit too close to commit. How long does the extension startup take on the renderer? Is it possible that would delay the commit? (If so maybe you should move it to DidStartNavigation?)
// We initialize extension on ReadyToCommitNavigation.Doing this for every process can potentially slow done all process creations. I think you should only skip when the RPH is a topchrome (includes non-initial WebUI too) process. Currently we don't have a way to tell that, but we can change this [flag](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/renderer_host/render_process_host_impl.cc;l=1575;drc=95ff298d19036fea0323de0cc8f4ba0921bd9d11) (which is currently wrong because if other topchrome creates the process first before initial WebUI) to be "is topchrome process" flag (which will be correctly set regardless of which topchrome navigates to it, which includes initial WebUI and non-initial WebUI).
bool should_skip_extensions = false;There's no need for this to be in the CommitNavigationParams since the renderer doesn't need the information. You can just save it as a member of NavigationRequest, or maybe even just expose `IsInitialWebUINavigation()`
Related details
- Eriko Kurimoto
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |