hierarchical: Split HierarchicalMenuController constructor for flyout [chromium/src : main]

0 views
Skip to first unread message

Masa Fujita (Gerrit)

unread,
Oct 29, 2025, 2:24:03 PM (2 days ago) Oct 29
to chromium...@chromium.org, AJITH KUMAR V, chromium-a...@chromium.org, meilian...@chromium.org, davidj...@chromium.org, wychen...@chromium.org, peilinwa...@google.com, yusufo...@chromium.org, gogeral...@chromium.org, yuezhang...@chromium.org, browser-comp...@chromium.org, srahim...@chromium.org, aji...@samsung.com, hanxi...@chromium.org, mattsimm...@chromium.org, extension...@chromium.org

Masa Fujita has uploaded the change for review

Commit message

hierarchical: Split HierarchicalMenuController constructor for flyout

In an incoming refactor that lets `FlyoutController` manage the list of
the flyout popups, the controller's constructor will require the first
popup object. In preparation, we split the constructor for
`HierarchicalMenuController` and while we're at it defer passing
flyout-related arguments.

This change should have the added advantage of clearly

This CL should have no functional change.
Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c

Change diff


Change information

Files:
  • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabOverflowMenuCoordinator.java
  • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
  • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
  • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinatorTest.java
  • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuMediatorTest.java
  • M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarMediator.java
  • M chrome/browser/ui/android/appmenu/internal/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuHandlerImpl.java
  • M content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
  • M ui/android/java/src/org/chromium/ui/hierarchicalmenu/HierarchicalMenuController.java
  • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuHost.java
  • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuUtils.java
Change size: M
Delta: 11 files changed, 54 insertions(+), 63 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
Gerrit-Change-Number: 7097478
Gerrit-PatchSet: 1
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 29, 2025, 2:39:07 PM (2 days ago) Oct 29
to AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
Gerrit-Change-Number: 7097478
Gerrit-PatchSet: 3
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Oct 2025 18:39:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 29, 2025, 4:47:59 PM (2 days ago) Oct 29
to Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
Gerrit-Change-Number: 7097478
Gerrit-PatchSet: 5
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Oct 2025 20:47:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 29, 2025, 5:30:00 PM (2 days ago) Oct 29
to Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
Gerrit-Change-Number: 7097478
Gerrit-PatchSet: 7
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Oct 2025 21:29:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Masa Fujita (Gerrit)

unread,
Oct 29, 2025, 5:47:57 PM (2 days ago) Oct 29
to Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

Masa Fujita voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
Gerrit-Change-Number: 7097478
Gerrit-PatchSet: 8
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Oct 2025 21:47:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Wenyu Fu (Gerrit)

unread,
Oct 29, 2025, 6:54:48 PM (2 days ago) Oct 29
to Masa Fujita, Jenna Himawan, Eleanor Lee, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Eleanor Lee, Jenna Himawan and Masa Fujita

Wenyu Fu added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Wenyu Fu . resolved

+Jenna to help take a first pass (knowing this being a refactor), I'll add the OWNERS +1

Open in Gerrit

Related details

Attention is currently required from:
  • Eleanor Lee
  • Jenna Himawan
  • Masa Fujita
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
Gerrit-Change-Number: 7097478
Gerrit-PatchSet: 8
Gerrit-Owner: Masa Fujita <mas...@google.com>
Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
Gerrit-Reviewer: Masa Fujita <mas...@google.com>
Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
Gerrit-CC: Wenyu Fu <wen...@chromium.org>
Gerrit-Attention: Eleanor Lee <elean...@google.com>
Gerrit-Attention: Masa Fujita <mas...@google.com>
Gerrit-Attention: Jenna Himawan <jhim...@google.com>
Gerrit-Comment-Date: Wed, 29 Oct 2025 22:54:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jenna Himawan (Gerrit)

unread,
Oct 30, 2025, 12:21:26 PM (yesterday) Oct 30
to Masa Fujita, Wenyu Fu, Eleanor Lee, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Attention needed from Eleanor Lee and Masa Fujita

Jenna Himawan voted and added 1 comment

Votes added by Jenna Himawan

Code-Review+1

1 comment

File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
Line 111, Patchset 10 (Latest): this(activity, topContentOffsetPx, nativeDelegate, false);
Jenna Himawan . unresolved

nit: `nativeDelegate, /* isCustomItemPresent= */ false)`

Open in Gerrit

Related details

Attention is currently required from:
  • Eleanor Lee
  • Masa Fujita
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
    Gerrit-Change-Number: 7097478
    Gerrit-PatchSet: 10
    Gerrit-Owner: Masa Fujita <mas...@google.com>
    Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
    Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
    Gerrit-Reviewer: Masa Fujita <mas...@google.com>
    Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
    Gerrit-CC: Wenyu Fu <wen...@chromium.org>
    Gerrit-Attention: Eleanor Lee <elean...@google.com>
    Gerrit-Attention: Masa Fujita <mas...@google.com>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 16:21:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Masa Fujita (Gerrit)

    unread,
    Oct 30, 2025, 5:59:24 PM (22 hours ago) Oct 30
    to Jenna Himawan, Wenyu Fu, Eleanor Lee, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
    Attention needed from Eleanor Lee

    Masa Fujita added 2 comments

    Patchset-level comments
    File-level comment, Patchset 11 (Latest):
    Masa Fujita . resolved

    @elean...@google.com PTAL bookmarkbarmediator

    File chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
    Line 111, Patchset 10: this(activity, topContentOffsetPx, nativeDelegate, false);
    Jenna Himawan . resolved

    nit: `nativeDelegate, /* isCustomItemPresent= */ false)`

    Masa Fujita

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eleanor Lee
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Gerrit-Change-Number: 7097478
      Gerrit-PatchSet: 11
      Gerrit-Owner: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
      Gerrit-Reviewer: Masa Fujita <mas...@google.com>
      Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
      Gerrit-CC: Wenyu Fu <wen...@chromium.org>
      Gerrit-Attention: Eleanor Lee <elean...@google.com>
      Gerrit-Comment-Date: Thu, 30 Oct 2025 21:59:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Jenna Himawan <jhim...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Masa Fujita (Gerrit)

      unread,
      Oct 30, 2025, 5:59:32 PM (22 hours ago) Oct 30
      to Jenna Himawan, Wenyu Fu, Eleanor Lee, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
      Attention needed from Eleanor Lee

      Masa Fujita voted Commit-Queue+1

      Commit-Queue+1
      Gerrit-Comment-Date: Thu, 30 Oct 2025 21:59:22 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Eleanor Lee (Gerrit)

      unread,
      Oct 30, 2025, 6:04:22 PM (22 hours ago) Oct 30
      to Masa Fujita, Wenyu Fu, Jenna Himawan, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
      Attention needed from Masa Fujita and Wenyu Fu

      Eleanor Lee voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Masa Fujita
      • Wenyu Fu
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Gerrit-Change-Number: 7097478
      Gerrit-PatchSet: 11
      Gerrit-Owner: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
      Gerrit-Reviewer: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
      Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
      Gerrit-Attention: Masa Fujita <mas...@google.com>
      Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
      Gerrit-Comment-Date: Thu, 30 Oct 2025 22:04:13 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Wenyu Fu (Gerrit)

      unread,
      Oct 30, 2025, 6:27:14 PM (22 hours ago) Oct 30
      to Masa Fujita, Eleanor Lee, Jenna Himawan, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

      Wenyu Fu voted and added 1 comment

      Votes added by Wenyu Fu

      Code-Review+1

      1 comment

      Patchset-level comments
      Wenyu Fu . resolved

      RS given Jenna + Eleanor's review

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Gerrit-Change-Number: 7097478
      Gerrit-PatchSet: 11
      Gerrit-Owner: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
      Gerrit-Reviewer: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
      Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
      Gerrit-Comment-Date: Thu, 30 Oct 2025 22:27:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Masa Fujita (Gerrit)

      unread,
      Oct 30, 2025, 6:45:16 PM (21 hours ago) Oct 30
      to Jinsuk Kim, Wenyu Fu, Eleanor Lee, Jenna Himawan, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

      Masa Fujita added 1 comment

      Patchset-level comments
      Masa Fujita . resolved

      @jins...@chromium.org PTAL SelectionPopupControllerImpl

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Gerrit-Change-Number: 7097478
      Gerrit-PatchSet: 11
      Gerrit-Owner: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
      Gerrit-Reviewer: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
      Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
      Gerrit-CC: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Comment-Date: Thu, 30 Oct 2025 22:45:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jinsuk Kim (Gerrit)

      unread,
      7:54 AM (8 hours ago) 7:54 AM
      to Masa Fujita, Wenyu Fu, Eleanor Lee, Jenna Himawan, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
      Attention needed from Masa Fujita

      Jinsuk Kim voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Masa Fujita
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Gerrit-Change-Number: 7097478
      Gerrit-PatchSet: 11
      Gerrit-Owner: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
      Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
      Gerrit-Attention: Masa Fujita <mas...@google.com>
      Gerrit-Comment-Date: Fri, 31 Oct 2025 11:54:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Masa Fujita (Gerrit)

      unread,
      10:35 AM (6 hours ago) 10:35 AM
      to Jinsuk Kim, Wenyu Fu, Eleanor Lee, Jenna Himawan, Chromium LUCI CQ, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

      Masa Fujita voted and added 1 comment

      Votes added by Masa Fujita

      Commit-Queue+2

      1 comment

      Patchset-level comments
      Masa Fujita . resolved

      Thank you so much for the quick reviews!

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Gerrit-Change-Number: 7097478
      Gerrit-PatchSet: 11
      Gerrit-Owner: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Eleanor Lee <elean...@google.com>
      Gerrit-Reviewer: Jenna Himawan <jhim...@google.com>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Masa Fujita <mas...@google.com>
      Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
      Gerrit-CC: AJITH KUMAR V <aji...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Oct 2025 14:35:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      10:39 AM (6 hours ago) 10:39 AM
      to Masa Fujita, Jinsuk Kim, Wenyu Fu, Eleanor Lee, Jenna Himawan, AJITH KUMAR V, chromium...@chromium.org, aji...@samsung.com, browser-comp...@chromium.org, chromium-a...@chromium.org, davidj...@chromium.org, extension...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, peilinwa...@google.com, srahim...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      hierarchical: Split HierarchicalMenuController constructor for flyout

      In an incoming refactor that lets `FlyoutController` manage the list of
      the flyout popups, the controller's constructor will require the first
      popup object. In preparation, we split the constructor for
      `HierarchicalMenuController`.  While we're at it, we move the
      construction of the controller for `ContextMenuCoordinator` to its
      constructor, also in preparation for the said refactor.

      This change should have the added advantage of clearly separating the
      flyout-specific configuration from the main construction path.


      This CL should have no functional change.
      Bug: 433410990
      Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c
      Reviewed-by: Wenyu Fu <wen...@chromium.org>
      Commit-Queue: Masa Fujita <mas...@google.com>
      Reviewed-by: Eleanor Lee <elean...@google.com>
      Reviewed-by: Jinsuk Kim <jins...@chromium.org>
      Reviewed-by: Jenna Himawan <jhim...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1538590}
      Files:
        • M chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabOverflowMenuCoordinator.java
        • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
        • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
        • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinatorTest.java
        • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuMediatorTest.java
        • M chrome/browser/bookmarks/android/java/src/org/chromium/chrome/browser/bookmarks/bar/BookmarkBarMediator.java
        • M chrome/browser/ui/android/appmenu/internal/java/src/org/chromium/chrome/browser/ui/appmenu/AppMenuHandlerImpl.java
        • M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/BrowserUiListMenuUnitTest.java
        • M components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/listmenu/BrowserUiListMenuRenderTest.java
        • M content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
        • M ui/android/java/src/org/chromium/ui/hierarchicalmenu/HierarchicalMenuController.java
        • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuHost.java
        • M ui/android/java/src/org/chromium/ui/listmenu/ListMenuUtils.java
        • M ui/android/junit/src/org/chromium/ui/hierarchicalmenu/FlyoutControllerUnitTest.java
        • M ui/android/junit/src/org/chromium/ui/hierarchicalmenu/HierarchicalMenuControllerUnitTest.java
        Change size: M
        Delta: 15 files changed, 67 insertions(+), 90 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Wenyu Fu, +1 by Eleanor Lee, +1 by Jenna Himawan, +1 by Jinsuk Kim
         Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        


         Gerrit-MessageType: merged 
        

         Gerrit-Project: chromium/src 
        

         Gerrit-Branch: main 
        

         Gerrit-Change-Id: I350338b08aeb30919c3345ed07bc4cfcb3d2b16c 
        

         Gerrit-Change-Number: 7097478 
        

         Gerrit-PatchSet: 12 
        

         Gerrit-Owner: Masa Fujita <mas...@google.com> 
        

         Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
        

         Gerrit-Reviewer: Eleanor Lee <elean...@google.com> 
        

         Gerrit-Reviewer: Jenna Himawan <jhim...@google.com> 
        

         Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org> 
        

         Gerrit-Reviewer: Masa Fujita <mas...@google.com> 
        

         Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org> 
        

         Gerrit-CC: AJITH KUMAR V <aji...@chromium.org> 
        

        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages