[Extensions] Add OnShowAccessRequestsInToolbarChanged() to menu model [chromium/src : main]

0 views
Skip to first unread message

Emilia Paz (Gerrit)

unread,
Oct 27, 2025, 7:02:50 PM (2 days ago) Oct 27
to Shuhei Takahashi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi

Emilia Paz voted and added 2 comments

Votes added by Emilia Paz

Commit-Queue+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Emilia Paz . resolved

And last one for this observer!

File chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
Line 108, Patchset 2 (Parent):
// PermissionsManager::Observer:
void OnShowAccessRequestsInToolbarChanged(
const extensions::ExtensionId& extension_id,
bool can_show_requests) override;
Emilia Paz . unresolved

This is the last method. In next CL will remove the observer, and rename methods whose name was colliding

Open in Gerrit

Related details

Attention is currently required from:
  • Shuhei Takahashi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c66bb70a8edb5950d02aa0643c9695102897cd6
Gerrit-Change-Number: 7087445
Gerrit-PatchSet: 4
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
Gerrit-Attention: Shuhei Takahashi <n...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 23:02:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shuhei Takahashi (Gerrit)

unread,
Oct 27, 2025, 8:53:02 PM (2 days ago) Oct 27
to Emilia Paz, Shuhei Takahashi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz

Shuhei Takahashi voted and added 1 comment

Votes added by Shuhei Takahashi

Code-Review+1

1 comment

File chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
Line 108, Patchset 2 (Parent):
// PermissionsManager::Observer:
void OnShowAccessRequestsInToolbarChanged(
const extensions::ExtensionId& extension_id,
bool can_show_requests) override;
Emilia Paz . resolved

This is the last method. In next CL will remove the observer, and rename methods whose name was colliding

Shuhei Takahashi

Yay!

Open in Gerrit

Related details

Attention is currently required from:
  • Emilia Paz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c66bb70a8edb5950d02aa0643c9695102897cd6
    Gerrit-Change-Number: 7087445
    Gerrit-PatchSet: 4
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
    Gerrit-Attention: Emilia Paz <emil...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 00:52:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Emilia Paz <emil...@chromium.org>
    satisfied_requirement
    open
    diffy

    Emilia Paz (Gerrit)

    unread,
    Oct 28, 2025, 1:04:09 AM (2 days ago) Oct 28
    to Shuhei Takahashi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Emilia Paz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c66bb70a8edb5950d02aa0643c9695102897cd6
    Gerrit-Change-Number: 7087445
    Gerrit-PatchSet: 5
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 05:03:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 28, 2025, 1:07:18 AM (2 days ago) Oct 28
    to Emilia Paz, Shuhei Takahashi, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    4 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [Extensions] Add OnShowAccessRequestsInToolbarChanged() to menu model

    Move PermissionsManager::Observer::OnShowAccessRequestsInToolbarChanged
    from the platform delegate views to the model.

    No functionality changed.
    Bug: 449814184
    Change-Id: I7c66bb70a8edb5950d02aa0643c9695102897cd6
    Reviewed-by: Shuhei Takahashi <n...@chromium.org>
    Commit-Queue: Emilia Paz <emil...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1536452}
    Files:
    • M chrome/browser/ui/extensions/extensions_menu_view_model.cc
    • M chrome/browser/ui/extensions/extensions_menu_view_model.h
    • M chrome/browser/ui/extensions/extensions_menu_view_model_browsertest.cc
    • M chrome/browser/ui/extensions/extensions_menu_view_platform_delegate.h
    • M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.cc
    • M chrome/browser/ui/views/extensions/extensions_menu_view_platform_delegate_views.h
    Change size: M
    Delta: 6 files changed, 39 insertions(+), 20 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Shuhei Takahashi
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7c66bb70a8edb5950d02aa0643c9695102897cd6
    Gerrit-Change-Number: 7087445
    Gerrit-PatchSet: 6
    Gerrit-Owner: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
    Gerrit-Reviewer: Shuhei Takahashi <n...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages