[Extensions] Fix extensions menu right-spacing and shifting on Linux [chromium/src : main]
0 views
Skip to first unread message
Eva Su (Gerrit)
Aug 14, 2026, 3:57:31 PM (2 days ago) Aug 14
to Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Andrea Orru
Eva Su voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Andrea Orru
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrea Orru (Gerrit)
Aug 14, 2026, 6:14:22 PM (2 days ago) Aug 14
to Eva Su, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Eva Su
Andrea Orru voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Eva Su
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eva Su (Gerrit)
Aug 14, 2026, 6:14:34 PM (2 days ago) Aug 14
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Eva Su voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 14, 2026, 6:34:47 PM (2 days ago) Aug 14
to Eva Su, Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Fix extensions menu right-spacing and shifting on Linux
Previously, when opening the extensions menu on Linux with a fresh user
profile and hovering over the extensions button, the menu would shift to
the left and have an unwanted gap on the right side.
The culprit CL was found to be crrev.com/c/8008153 which set the site
permissions label text to the full accessible name. These names can get
quite long (for example, "Always on all sites. Installed by your
administrator”) which would cause the menu to request an unconstrained
width, inflating the preferred width of the initial bubble frame on
Linux. On Linux, mouse hover triggers an explicit Views re-layout pass
that contracts the inner content back to standard width while leaving
the bubble window frame at its initial inflated size, whereas Windows
and macOS do not perform this hover-triggered layout recalculation.
This CL elides the site permissions label (this is safe to do because
eliding is purely for rendering, a11y still stores the full string and
VO will announce the full, un-elided string) and updates the flex
specification so that the label can shrink to 0 when space is tight, but
won't grow larger than its text.
Screencast showing that the menu does not shift and have the unwanted
gap when extensions button is first clicked and hovered:
https://screencast.googleplex.com/cast/NDUwNTgyNjI5MDA0MDgzMnxhZGE4ZTNiZS1iYw
Bug: 537566660
Change-Id: Ibf8c124cc3991b0dd4bf8f9776cc8e7648d75405
Reviewed-by: Andrea Orru <andre...@chromium.org>
Commit-Queue: Eva Su <ev...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1679980}
Files:
- M chrome/browser/ui/views/extensions/extensions_menu_entry_view.cc
Change size: XS
Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrea Orru
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages