[M149] Reland "Site Search: Gate KeywordProvider on Android" [chromium/src : refs/branch-heads/7827]
0 views
Skip to first unread message
chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com (Gerrit)
1:34 PM (3 hours ago) 1:34 PM
to Keigo Oka, android-bu...@system.gserviceaccount.com, jdonnel...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, omnibox-...@chromium.org
chrome-che...@chops-service-accounts.iam.gserviceaccount.com voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
1:34 PM (3 hours ago) 1:34 PM
to Keigo Oka, chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, jdonnel...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, omnibox-...@chromium.org
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:33 PM (1 hour ago) 3:33 PM
to Keigo Oka, chrome-che...@chops-service-accounts.iam.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, jdonnel...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, omnibox-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M149] Reland "Site Search: Gate KeywordProvider on Android"
Original change's description:
> Reland "Site Search: Gate KeywordProvider on Android"
>
> This reverts commit ec3bd80720752b5a05e008cbe03c5ce198083c35.
>
> Reason for revert: Test fixed
>
> Original change's description:
> > Revert "Site Search: Gate KeywordProvider on Android"
> >
> > This reverts commit 02f7c0dc7be30f9d0e44bfb77c16d029d0e05a0a.
> >
> > Reason for revert: breaks bots
> > https://ci.chromium.org/ui/p/chrome/builders/ci/android-desktop-16-x64-rel-emu-tests/6500/overview
> >
> > Original change's description:
> > > Site Search: Gate KeywordProvider on Android
> > >
> > > On Android, KeywordProvider was unconditionally generating non-extension
> > > keyword matches because AutocompleteProvider::TYPE_KEYWORD is always
> > > included in the provider types when ENABLE_EXTENSIONS_CORE is true
> > > (which is the case for Desktop Android). This resulted in the keyword
> > > mode chip appearing for site search engines even when the
> > > omnibox-site-search flag was default/disabled.
> > >
> > > This change conditionally includes AutocompleteProvider::TYPE_KEYWORD
> > > in AutocompleteClassifier::DefaultOmniboxProviders based on the
> > > omnibox::kOmniboxSiteSearch feature flag on Android, removing the
> > > need to manually filter them out later in the provider.
> > >
> > > Bug: 516585270
> > > Change-Id: I3ed8eba10febe6791c2dc0b21334ddeac1a6ba3f
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7867236
> > > Auto-Submit: Keigo Oka <o...@chromium.org>
> > > Commit-Queue: Tomasz Wiszkowski <en...@google.com>
> > > Reviewed-by: Tomasz Wiszkowski <en...@google.com>
> > > Cr-Commit-Position: refs/heads/main@{#1637344}
> >
> > Bug: 516585270
> > Change-Id: I2468abdbfc2fad1de1fc2c73eb49c6f92acf70d9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7874193
> > Auto-Submit: Joel Hockey <joelh...@chromium.org>
> > Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
> > Owners-Override: Joel Hockey <joelh...@chromium.org>
> > Commit-Queue: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/main@{#1637467}
>
> Bug: 516585270
> Change-Id: I5dae06224e9e15615cde7022fc15cef3573de25f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882278
> Reviewed-by: Tomasz Wiszkowski <en...@google.com>
> Reviewed-by: Hidehiko Abe <hide...@chromium.org>
> Auto-Submit: Keigo Oka <o...@chromium.org>
> Commit-Queue: Tomasz Wiszkowski <en...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1638628}
(cherry picked from commit 6079dc43bdb05b64840ff040a4210debbe404496)
Bug: 516996403,516585270
Change-Id: I5dae06224e9e15615cde7022fc15cef3573de25f
Auto-Submit: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7827@{#2257}
Cr-Branched-From: 9f3e9aaccba63bd2ec30334e45e0bfd07ebcc8f1-refs/heads/main@{#1625079}
Files:
- M chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc
- M components/omnibox/browser/autocomplete_classifier.cc
Change size: S
Delta: 2 files changed, 13 insertions(+), 1 deletion(-)
Branch: refs/branch-heads/7827
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages