CloudPolicyStore: separate key file for extension-install [chromium/src : main]

0 views
Skip to first unread message

Nicolas Ouellet-Payeur (Gerrit)

unread,
Jan 29, 2026, 1:30:18 PM (2 days ago) Jan 29
to AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org

Nicolas Ouellet-Payeur has uploaded the change for review

Commit message

CloudPolicyStore: separate key file for extension-install
Bug: 477545526
Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e

Change diff


Change information

Files:
  • M components/policy/core/common/cloud/machine_level_user_cloud_policy_store.cc
  • M components/policy/core/common/cloud/user_cloud_policy_store.cc
Change size: S
Delta: 2 files changed, 12 insertions(+), 5 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
Gerrit-Change-Number: 7532802
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolas Ouellet-Payeur <nico...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicolas Ouellet-Payeur (Gerrit)

unread,
Jan 29, 2026, 2:08:53 PM (2 days ago) Jan 29
to Yann Dago, AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Yann Dago

Nicolas Ouellet-Payeur added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Nicolas Ouellet-Payeur . resolved

ydago@, PTAL

(assuming we still want a separate key file for extension-install?)

Open in Gerrit

Related details

Attention is currently required from:
  • Yann Dago
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
Gerrit-Change-Number: 7532802
Gerrit-PatchSet: 4
Gerrit-Owner: Nicolas Ouellet-Payeur <nico...@chromium.org>
Gerrit-Reviewer: Yann Dago <yd...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-Attention: Yann Dago <yd...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 19:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yann Dago (Gerrit)

unread,
Jan 29, 2026, 2:55:56 PM (2 days ago) Jan 29
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Nicolas Ouellet-Payeur

Yann Dago voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nicolas Ouellet-Payeur
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
    Gerrit-Change-Number: 7532802
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Yann Dago <yd...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Comment-Date: Thu, 29 Jan 2026 19:55:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yann Dago (Gerrit)

    unread,
    Jan 29, 2026, 2:57:00 PM (2 days ago) Jan 29
    to Nicolas Ouellet-Payeur, Chromium LUCI CQ, AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Nicolas Ouellet-Payeur

    Yann Dago added 1 comment

    Patchset-level comments
    Yann Dago . resolved

    I think you can rebase this and land it , failures are coming from the CL before it

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nicolas Ouellet-Payeur
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
    Gerrit-Change-Number: 7532802
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Yann Dago <yd...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Comment-Date: Thu, 29 Jan 2026 19:56:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Nicolas Ouellet-Payeur (Gerrit)

    unread,
    Jan 30, 2026, 3:32:31 PM (9 hours ago) Jan 30
    to Yann Dago, Chromium LUCI CQ, AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org

    Nicolas Ouellet-Payeur voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
    Gerrit-Change-Number: 7532802
    Gerrit-PatchSet: 6
    Gerrit-Owner: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Yann Dago <yd...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 20:32:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 30, 2026, 3:42:32 PM (9 hours ago) Jan 30
    to Nicolas Ouellet-Payeur, Yann Dago, AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    4 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    CloudPolicyStore: separate key file for extension-install
    Bug: 477545526
    Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
    Reviewed-by: Yann Dago <yd...@chromium.org>
    Commit-Queue: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1577481}
    Files:
    • M components/policy/core/common/cloud/machine_level_user_cloud_policy_store.cc
    • M components/policy/core/common/cloud/profile_cloud_policy_store.cc
    • M components/policy/core/common/cloud/user_cloud_policy_store.cc
    Change size: S
    Delta: 3 files changed, 17 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yann Dago
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9bcd1fcfe4a77028010f56b6531d849f26e59c9e
    Gerrit-Change-Number: 7532802
    Gerrit-PatchSet: 7
    Gerrit-Owner: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Yann Dago <yd...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages