iwa: Implement chromeos.isolatedWebApp.setShape [chromium/src : main]

0 views
Skip to first unread message

Edman Anjos (Gerrit)

unread,
Feb 27, 2026, 2:28:58 AM (13 days ago) Feb 27
to Edman Anjos, Hidehiko Abe, Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Hidehiko Abe and Simon Hangl

Edman Anjos added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Edman Anjos . resolved

hi Hidehiko, Simon, PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie290a6f3b2e5585ab3149da798925033a7c39ffd
Gerrit-Change-Number: 7566876
Gerrit-PatchSet: 9
Gerrit-Owner: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Feb 2026 07:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Feb 27, 2026, 8:17:23 AM (13 days ago) Feb 27
to Edman Anjos, Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos and Simon Hangl

Hidehiko Abe added 4 comments

Patchset-level comments
Hidehiko Abe . resolved

Could you fix build failures?

File chrome/browser/ash/isolated_web_app/DEPS
Line 14, Patchset 9 (Latest): "blink_extensions_browsertest\.cc": [
Hidehiko Abe . unresolved

oops, I probably overlooked. `\` must be escaped.
`"blink_extensions_browsertest\\.cc"`
Ditto for below.

File chromeos/ash/experiences/isolated_web_app/DEPS
Line 12, Patchset 9 (Latest): ".*_unittest\.cc": [
Hidehiko Abe . unresolved

ditto

File chromeos/ash/experiences/isolated_web_app/shaped_window_targeter.h
Line 26, Patchset 9 (Latest): explicit ShapedWindowTargeter(const std::vector<gfx::Rect>& shape_rects);
Hidehiko Abe . unresolved

for slightly better performance, how about taking the arg by value, and std::move() in the ctor?

Open in Gerrit

Related details

Attention is currently required from:
  • Edman Anjos
  • Simon Hangl
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie290a6f3b2e5585ab3149da798925033a7c39ffd
    Gerrit-Change-Number: 7566876
    Gerrit-PatchSet: 9
    Gerrit-Owner: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Edman Anjos <ed...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 13:16:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Paulina Gacek (Gerrit)

    unread,
    Mar 3, 2026, 4:51:18 AM (9 days ago) Mar 3
    to Edman Anjos, Hidehiko Abe, Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
    Attention needed from Edman Anjos and Simon Hangl

    Paulina Gacek added 1 comment

    File chromeos/ash/experiences/isolated_web_app/shaped_window_targeter.h
    Line 18, Patchset 9 (Latest):// A `WindowTargeter` for a window that uses a custom shape for hit-testing. The
    // window shape is given by the intersection of `shape_rects`. Events outside
    // the rectangles fall through to the next targeter in the chain.
    Paulina Gacek . unresolved

    The comments here repeatedly state that the window shape is defined by the intersection of the rectangles. Shouldn't this be the union?

    If a web developer passes multiple disjoint rectangles to setShape() to create a custom window outline, an intersection would evaluate to an empty region.

    Suggest updating lines 18, 24, and 38 to say "union" instead of "intersection".

    Gerrit-CC: Paulina Gacek <paulin...@google.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Edman Anjos <ed...@chromium.org>
    Gerrit-Comment-Date: Tue, 03 Mar 2026 09:51:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Edman Anjos (Gerrit)

    unread,
    6:39 AM (6 hours ago) 6:39 AM
    to Edman Anjos, Code Review Nudger, Paulina Gacek, Hidehiko Abe, Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
    Attention needed from Hidehiko Abe and Simon Hangl

    Edman Anjos added 4 comments

    File chrome/browser/ash/isolated_web_app/DEPS
    Line 14, Patchset 9: "blink_extensions_browsertest\.cc": [
    Hidehiko Abe . resolved

    oops, I probably overlooked. `\` must be escaped.
    `"blink_extensions_browsertest\\.cc"`
    Ditto for below.

    Edman Anjos

    This CL no longer changes this file.

    I uploaded https://crrev.com/c/7657724 to fix this line.

    File chromeos/ash/experiences/isolated_web_app/DEPS
    Line 12, Patchset 9: ".*_unittest\.cc": [
    Hidehiko Abe . resolved

    ditto

    Edman Anjos

    Done, thanks

    File chromeos/ash/experiences/isolated_web_app/shaped_window_targeter.h
    Line 26, Patchset 9: explicit ShapedWindowTargeter(const std::vector<gfx::Rect>& shape_rects);
    Hidehiko Abe . resolved

    for slightly better performance, how about taking the arg by value, and std::move() in the ctor?

    Edman Anjos

    Done, thanks

    Line 18, Patchset 9:// A `WindowTargeter` for a window that uses a custom shape for hit-testing. The

    // window shape is given by the intersection of `shape_rects`. Events outside
    // the rectangles fall through to the next targeter in the chain.
    Paulina Gacek . resolved

    The comments here repeatedly state that the window shape is defined by the intersection of the rectangles. Shouldn't this be the union?

    If a web developer passes multiple disjoint rectangles to setShape() to create a custom window outline, an intersection would evaluate to an empty region.

    Suggest updating lines 18, 24, and 38 to say "union" instead of "intersection".

    Edman Anjos

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Simon Hangl
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie290a6f3b2e5585ab3149da798925033a7c39ffd
      Gerrit-Change-Number: 7566876
      Gerrit-PatchSet: 11
      Gerrit-Owner: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Simon Hangl <sim...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Paulina Gacek <paulin...@google.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 10:38:47 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Paulina Gacek <paulin...@google.com>
      Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages