Fix Extension Request Access Button going underneath the extensions icon [chromium/src : main]
Jason Jiang (Gerrit)
Jason Jiang added 4 comments![]( "Open in Gerrit")
Jason JiangAdd a link to the screencast with the solution
Done
sibling_observation_.Observe(extensions_button);Jason JiangDo we need RemovedFromWidget -> sibling_observation_.Reset();?
Yes, just added it in the newest push
int clip_width = std::max(0, extensions_button->x() - x());Jason JiangDo we need to flip for RTL?
No need to flip for RTL as the math below this flips it correctly
Related details
- David Yeung
- Eva Su
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Yeung (Gerrit)
David Yeung added 3 comments![]( "Open in Gerrit")
Recording: https://screencast.googleplex.com/cast/NjU3ODg3OTM2Mjc2MDcwNHxkYTgyNTMxZS00Ngnit. Move this up in the description and have Bug and Change-id with no new line spacing.
ie
```
...
Previously the Allow #? was clipping behind the extensions icon, causing
a weird visual.
Recording:
https://screencast.googleplex.com/cast/NjU3ODg3OTM2Mjc2MDcwNHxkYTgyNTMxZS00Ng
Bug:395627283
Change-Id: I75a6c673428e6d77fcbc6ba3e6639c8708afec36
```
sibling_observation_.Observe(extensions_button);Jason JiangDo we need RemovedFromWidget -> sibling_observation_.Reset();?
Yes, just added it in the newest push
Which patchset has this change? I was expecting something like
```
ExtensionsRequestAccessButton::RemovedFromWidget() { sibling_observation_.Reset() };
```
int clip_width = std::max(0, extensions_button->x() - x());Jason JiangDo we need to flip for RTL?
No need to flip for RTL as the math below this flips it correctly
clip_width would be 0 if the x coordinate is flipped for RTL. On line 198, clip_rect uses clip_width in both cases to specify the width.
Related details
- Eva Su
- Jason Jiang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jason Jiang (Gerrit)
Jason Jiang added 3 comments![]( "Open in Gerrit")
Recording: https://screencast.googleplex.com/cast/NjU3ODg3OTM2Mjc2MDcwNHxkYTgyNTMxZS00Ngnit. Move this up in the description and have Bug and Change-id with no new line spacing.
ie
```...
Previously the Allow #? was clipping behind the extensions icon, causing
a weird visual.Recording:
https://screencast.googleplex.com/cast/NjU3ODg3OTM2Mjc2MDcwNHxkYTgyNTMxZS00NgBug:395627283
Change-Id: I75a6c673428e6d77fcbc6ba3e6639c8708afec36
```
Done
sibling_observation_.Observe(extensions_button);Jason JiangDo we need RemovedFromWidget -> sibling_observation_.Reset();?
David YeungYes, just added it in the newest push
Which patchset has this change? I was expecting something like
```
ExtensionsRequestAccessButton::RemovedFromWidget() { sibling_observation_.Reset() };
```
It's reset in OnViewIsDeleting.
int clip_width = std::max(0, extensions_button->x() - x());Jason JiangDo we need to flip for RTL?
David YeungNo need to flip for RTL as the math below this flips it correctly
clip_width would be 0 if the x coordinate is flipped for RTL. On line 198, clip_rect uses clip_width in both cases to specify the width.
hmmm I see, let me run a few tests on this and see thank you!
Related details
- David Yeung
- Eva Su
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |