[PDF Ink Signatures] Set a CrashKey in PDFiumEngine::AddFont() [chromium/src : main]
0 views
Skip to first unread message
April Kallmeyer (Gerrit)
6:01 PM (3 hours ago) 6:01 PM
to chromium...@chromium.org, chromium-a...@chromium.org, pdf-r...@chromium.org, extension...@chromium.org
April Kallmeyer has uploaded the change for review![]( "Open in Gerrit")
Commit message
[PDF Ink Signatures] Set a CrashKey in PDFiumEngine::AddFont()
This should hopefully give us enough information to figure out why
PDFium could not load the font if it crashes on CHECK(font).
Change-Id: I41b2345b7170872e08e38c335a15b9e47e509e25
Change diff
diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc
index c8fe376..a9900c1 100644
--- a/pdf/pdfium/pdfium_engine.cc
+++ b/pdf/pdfium/pdfium_engine.cc
@@ -110,6 +110,7 @@
#endif
#if BUILDFLAG(ENABLE_PDF_INK2)
+#include "base/debug/crash_logging.h"
#include "base/rand_util.h"
#include "pdf/pdf_ink_metrics_handler.h"
#include "pdf/pdf_ink_transform.h"
@@ -5202,6 +5203,10 @@
&serialized_typeface_stream, skia::DefaultFontMgr());
CHECK(typeface);
+ SkString family_name;
+ typeface->getFamilyName(&family_name);
+ SCOPED_CRASH_KEY_STRING64("pdf", "font_name", family_name.c_str());
+
std::unique_ptr<SkStreamAsset> font_stream = typeface->openStream(nullptr);
sk_sp<const SkData> font_data = MakeDataAvoidingCopy(font_stream.get());
base::span<const uint8_t> font_data_span = gfx::SkDataToSpan(font_data);
Change information
Files:
- M pdf/pdfium/pdfium_engine.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
April Kallmeyer (Gerrit)
6:02 PM (3 hours ago) 6:02 PM
to Lei Zhang, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Lei Zhang
April Kallmeyer voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
6:21 PM (3 hours ago) 6:21 PM
to April Kallmeyer, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from April Kallmeyer
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File pdf/pdfium/pdfium_engine.cc
Line 5208, Patchset 1 (Latest):
SCOPED_CRASH_KEY_STRING64("pdf", "font_name", family_name.c_str());Lei Zhang . unresolved
How about using SCOPED_CRASH_KEY_STRING256(), the next size up, in case there are longer font names.
Related details
Attention is currently required from:
- April Kallmeyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages