[json_schema_compiler] Enforce strict C++ header existence check [chromium/src : main]

0 views

Skip to first unread message

Devlin Cronin (Gerrit)

unread,

2:23 PM (2 hours ago) 2:23 PM

to Takuto Ikuta, Devlin Cronin, Tim, Chromium LUCI CQ, chromium...@chromium.org, chrome-b...@google.com, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Takuto Ikuta and Tim

Devlin Cronin added 2 comments

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Devlin Cronin . unresolved

Thanks, Takuto! It looks like there's some bot failures; mind looking into those and pinging when this is ready for another pass? Let me know if you run into any issues.

Also, if it's helpful, we could probably extract some of this work into precursor CLs (e.g. moving inputs around to the types_only sections). Up to you, though

File tools/json_schema_compiler/json_schema_api.gni

Line 295, Patchset 8 (Latest):

    non_custom_api_names =
        filter_exclude(get_path_info(invoker.sources, "name"),
                       custom_impl_schemas)

Devlin Cronin . unresolved

nit: this is magical enough to me that it probably warrants a short comment explaining what it's doing.

Open in Gerrit

Related details

Attention is currently required from:

Takuto Ikuta
Tim

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages