Revert "Add cws zero state iph variation 3" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Oct 30, 2025, 8:01:28 PM (7 days ago) Oct 30
to Emilia Paz, AyeAye, Chromium LUCI CQ, Howard Chang, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org
Attention needed from Dana Fried and Howard Chang

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
  • Howard Chang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie65f3c8335a93ab3789db8bc40c5a49d9e3a4918
Gerrit-Change-Number: 7103721
Gerrit-PatchSet: 1
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Howard Chang <howa...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Attention: Howard Chang <howa...@google.com>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Oct 2025 00:01:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 30, 2025, 8:02:28 PM (7 days ago) Oct 30
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Howard Chang, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org
Attention needed from Dana Fried and Howard Chang

Emilia Paz voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
  • Howard Chang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie65f3c8335a93ab3789db8bc40c5a49d9e3a4918
Gerrit-Change-Number: 7103721
Gerrit-PatchSet: 1
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Howard Chang <howa...@google.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Attention: Howard Chang <howa...@google.com>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Oct 2025 00:02:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 30, 2025, 8:02:44 PM (7 days ago) Oct 30
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Howard Chang, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org
Attention needed from Dana Fried and Howard Chang

Emilia Paz voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Fri, 31 Oct 2025 00:02:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 30, 2025, 8:03:52 PM (7 days ago) Oct 30
to Emilia Paz, Rubber Stamper, AyeAye, Howard Chang, Dana Fried, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, estali...@chromium.org, dfried...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Add cws zero state iph variation 3"

This reverts commit 1e41e69094f303403c7e032ee45ef6481e951531.

Reason for revert: 
crrev.com/c/7084950 is causing many builders to fail. Revert has conflicts with this CL, so reverting both since they are related

Original change's description:
> Add cws zero state iph variation 3
>
> This cl is similar to https://chromium-review.googlesource.com/c/chromium/src/+/7084950
>
> Demo: https://screenshot.googleplex.com/Bw3Mfz9CxjRaJnz
>
> Bug: 409573170
> Change-Id: I8545e2674ec70d26ac99e241ed38ad9a972ff320
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7092648
> Reviewed-by: Dana Fried <dfr...@chromium.org>
> Reviewed-by: Emilia Paz <emil...@chromium.org>
> Commit-Queue: Howard Chang <howa...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1538136}
Bug: 409573170
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ie65f3c8335a93ab3789db8bc40c5a49d9e3a4918
Owners-Override: Emilia Paz <emil...@chromium.org>
Commit-Queue: Emilia Paz <emil...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1538295}
Files:
  • M chrome/app/extensions_strings.grdp
  • D chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_CHIPS_WITH_LINK_IPH_DESCRIPTION.png.sha1
  • D chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_CHIPS_WITH_LINK_IPH_LINK_LABEL.png.sha1
  • D chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_IPH_HEADER_V2.png.sha1
  • M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.css
  • M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.html.ts
  • M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.ts
  • M chrome/browser/ui/views/user_education/browser_user_education_service.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/extensions_zero_state_promo_interactive_uitest.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_ui.cc
  • M chrome/test/data/webui/extensions_zero_state/zero_state_promo_app_test.ts
  • M chrome/test/data/webui/extensions_zero_state/zero_state_promo_browsertest.cc
  • M components/feature_engagement/public/feature_constants.cc
  • M components/feature_engagement/public/feature_constants.h
  • M extensions/common/extension_urls.cc
  • M extensions/common/extension_urls.h
  • M extensions/common/switches.cc
  • M extensions/common/switches.h
Change size: L
Delta: 19 files changed, 5 insertions(+), 373 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie65f3c8335a93ab3789db8bc40c5a49d9e3a4918
Gerrit-Change-Number: 7103721
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages