Fix ExtensionInstallCloudPolicyChecksEnabled not applied per source [chromium/src : main]
0 views
Skip to first unread message
Yann Dago (Gerrit)
Feb 19, 2026, 6:13:43 PM (18 hours ago) Feb 19
to Andrea Orru, Nicolas Ouellet-Payeur, Lei Zhang, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Lei Zhang and Nicolas Ouellet-Payeur
Yann Dago voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Lei Zhang
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Feb 19, 2026, 6:13:51 PM (18 hours ago) Feb 19
to Andrea Orru, Nicolas Ouellet-Payeur, Lei Zhang, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Lei Zhang and Nicolas Ouellet-Payeur
Yann Dago voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Yann Dago (Gerrit)
Feb 19, 2026, 6:35:57 PM (18 hours ago) Feb 19
to Andrea Orru, Nicolas Ouellet-Payeur, Lei Zhang, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Lei Zhang and Nicolas Ouellet-Payeur
Yann Dago voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Yann Dago (Gerrit)
Feb 19, 2026, 6:50:10 PM (17 hours ago) Feb 19
to Andrea Orru, Nicolas Ouellet-Payeur, Lei Zhang, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Lei Zhang and Nicolas Ouellet-Payeur
Yann Dago voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Lei Zhang
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 19, 2026, 8:16:27 PM (16 hours ago) Feb 19
to Yann Dago, Andrea Orru, Nicolas Ouellet-Payeur, Lei Zhang, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/policy/test/data/pref_mapping/ExtensionInstallCloudPolicyChecksEnabled.json
Insertions: 48, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Fix ExtensionInstallCloudPolicyChecksEnabled not applied per source
This change registers the `kExtensionInstallCloudPolicyChecksEnabled`
preference in the local state and updates
`ExtensionInstallPolicyService` to monitor and respect this
machine-level preference. The service now checks both user profile and
local state preferences to determine if policy checks are enabled for
user and machine policies, respectively. The `UserCloudPolicyStore` is
updated to correctly handle the validation and installation of extension
install policies using a templated validation callback.
Bug: 485872483
Change-Id: I7d93da464a9f3cd906af663e757ca0934b22d91b
Reviewed-by: Andrea Orru <andre...@chromium.org>
Commit-Queue: Yann Dago <yd...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1587538}
Files:
- M chrome/browser/policy/cloud/extension_install_policy_service.cc
- M chrome/browser/policy/cloud/extension_install_policy_service.h
- M chrome/browser/prefs/browser_prefs.cc
- M components/policy/core/common/cloud/cloud_policy_manager.cc
- M components/policy/core/common/cloud/user_cloud_policy_store.cc
- M components/policy/core/common/cloud/user_cloud_policy_store.h
- M components/policy/test/data/pref_mapping/ExtensionInstallCloudPolicyChecksEnabled.json
- M extensions/browser/extension_prefs.cc
- M extensions/browser/extension_prefs.h
- M extensions/browser/pref_names.h
Change size: M
Delta: 10 files changed, 135 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrea Orru
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages