extensions: Enable chrome.tabGrousp.query() on desktop Android [chromium/src : main]
0 views
Skip to first unread message
James Cook (Gerrit)
Jan 8, 2026, 3:58:52 PM (19 hours ago) Jan 8
to Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Zoraiz Naeem
James Cook voted and added 5 comments![]( "Open in Gerrit")
Votes added by James Cook
| Commit-Queue | +1 |
5 comments
Patchset-level comments
File chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Line 58, Patchset 3 (Latest):
using tab_groups::TabGroupId;James Cook . unresolved
I did this because `std::optional<tab_groups::TabGroupId>` is long and was causing line wrapping in some cases.
Line 215, Patchset 3 (Latest):
std::optional<TabGroupId> group1 = CreateTabGroup({0});James Cook . unresolved
The test is unchanged, it just uses cross-platform interfaces (TabListInterface) and helper methods (CreateTabGroup).
Line 253, Patchset 3 (Latest):
std::optional<TabGroupId> group1 = CreateTabGroup({0});James Cook . unresolved
ditto, the test is unchanged, just refactored
Line 461, Patchset 3 (Latest):
TabGroupId group = tab_strip_model->AddToNewGroup({0, 1, 2});James Cook . unresolved
I'll convert these to the CreateTabGroup() helper method when I enable the tests on Android. For now they are Win/Mac/Linux/ChromeOS only.
Related details
Attention is currently required from:
- Zoraiz Naeem
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zoraiz Naeem (Gerrit)
Jan 8, 2026, 4:28:21 PM (18 hours ago) Jan 8
to James Cook, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from James Cook
Zoraiz Naeem voted and added 4 comments![]( "Open in Gerrit")
Votes added by Zoraiz Naeem
| Code-Review | +1 |
4 comments
Patchset-level comments
Zoraiz Naeem . resolved
lgtm!
File chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Line 58, Patchset 3 (Latest):
using tab_groups::TabGroupId;James Cook . resolved
I did this because `std::optional<tab_groups::TabGroupId>` is long and was causing line wrapping in some cases.
Zoraiz Naeem
Acknowledged
Line 253, Patchset 3 (Latest):
std::optional<TabGroupId> group1 = CreateTabGroup({0});James Cook . resolved
ditto, the test is unchanged, just refactored
Zoraiz Naeem
Acknowledged
Line 461, Patchset 3 (Latest):
TabGroupId group = tab_strip_model->AddToNewGroup({0, 1, 2});James Cook . unresolved
I'll convert these to the CreateTabGroup() helper method when I enable the tests on Android. For now they are Win/Mac/Linux/ChromeOS only.
Attention is currently required from:
- James Cook
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
James Cook (Gerrit)
Jan 8, 2026, 5:23:00 PM (17 hours ago) Jan 8
to Zoraiz Naeem, Achuith Bhandarkar, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
James Cook voted and added 3 comments![]( "Open in Gerrit")
Votes added by James Cook
| Commit-Queue | +2 |
3 comments
Patchset-level comments
File chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Line 215, Patchset 3:
std::optional<TabGroupId> group1 = CreateTabGroup({0});James Cook . resolved
James CookThe test is unchanged, it just uses cross-platform interfaces (TabListInterface) and helper methods (CreateTabGroup).
Acknowledged
Line 461, Patchset 3:
TabGroupId group = tab_strip_model->AddToNewGroup({0, 1, 2});James Cook . resolved
Zoraiz NaeemI'll convert these to the CreateTabGroup() helper method when I enable the tests on Android. For now they are Win/Mac/Linux/ChromeOS only.
Maybe add a TODO if it will be while till you get to it?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 6:33:15 PM (16 hours ago) Jan 8
to James Cook, Zoraiz Naeem, Achuith Bhandarkar, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Insertions: 1, Deletions: 0.
@@ -458,6 +458,7 @@
TabGroupModel* tab_group_model = tab_strip_model->group_model();
// Create a group.
+ // TODO(crbug.com/405219902): Convert call to CreateTabGroup() here and below.
TabGroupId group = tab_strip_model->AddToNewGroup({0, 1, 2});
tab_groups::TabGroupVisualData visual_data(
u"Initial title", tab_groups::TabGroupColorId::kBlue);
```
Change information
Commit message:
extensions: Enable chrome.tabGrousp.query() on desktop Android
Enable the API method implementation on Android and enable the
corresponding browser tests.
Bug: 405219902
Change-Id: I34407a06029704a1429177dc5f9e6611c1d9bc54
Reviewed-by: Zoraiz Naeem <zorai...@chromium.org>
Commit-Queue: James Cook <jame...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566595}
Files:
- M chrome/browser/extensions/api/tab_groups/tab_groups_api.cc
- M chrome/browser/extensions/api/tab_groups/tab_groups_api_browsertest.cc
Change size: M
Delta: 2 files changed, 82 insertions(+), 54 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zoraiz Naeem
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages