Replace CompletionOnceCallback with ErrorCallback for FileStream operations [chromium/src : main]

[Helmut Januschka (Gerrit)]

Attention needed from Tsuyoshi Horo

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helmut Januschka . resolved

hello @ho...@chromium.org thanks in advance for review.

please let me know if you want me to address anything!

Open in Gerrit

Related details

Attention is currently required from:

• Tsuyoshi Horo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0

Gerrit-Change-Number: 7552938

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Feb 2026 20:53:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Dan Harrington (Gerrit)]

Attention needed from Emilia Paz, Helmut Januschka and Tsuyoshi Horo

Dan Harrington voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Emilia Paz
• Helmut Januschka
• Tsuyoshi Horo

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0

Gerrit-Change-Number: 7552938

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Feb 2026 21:20:07 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Emilia Paz (Gerrit)]

Attention needed from Helmut Januschka and Tsuyoshi Horo

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Emilia Paz . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Tsuyoshi Horo

Gerrit-Comment-Date: Mon, 09 Feb 2026 21:41:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Tsuyoshi Horo (Gerrit)]

Attention needed from Helmut Januschka

Tsuyoshi Horo voted and added 2 comments

Votes added by Tsuyoshi Horo

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Tsuyoshi Horo . resolved

lgtm

File net/base/mock_file_stream.h

Line 25, Patchset 3 (Latest):class MockFileStream : public FileStream {

Tsuyoshi Horo . unresolved

It seems that the MockFileStream class is no longer being used. Could you please delete net/base/mock_file_stream.h and net/base/mock_file_stream.cc? Doing this in a follow-up CL after this one lands is fine with me.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0

Gerrit-Change-Number: 7552938

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Comment-Date: Thu, 12 Feb 2026 04:32:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Emilia Paz (Gerrit)]

Attention needed from Dan Harrington, Helmut Januschka and Tsuyoshi Horo

Emilia Paz voted and added 1 comment

Votes added by Emilia Paz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Emilia Paz . resolved

extensions slgtm

Open in Gerrit

Related details

Attention is currently required from:

• Dan Harrington
• Helmut Januschka
• Tsuyoshi Horo

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0

Gerrit-Change-Number: 7552938

Gerrit-PatchSet: 4

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-Attention: Dan Harrington <harri...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 21:06:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Dan Harrington (Gerrit)]

Attention needed from Helmut Januschka and Tsuyoshi Horo

Dan Harrington voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Tsuyoshi Horo

Gerrit-Comment-Date: Thu, 19 Feb 2026 21:08:26 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Helmut Januschka (Gerrit)]

Attention needed from Dan Harrington, Emilia Paz and Tsuyoshi Horo

Helmut Januschka added 1 comment

File net/base/mock_file_stream.h

Line 25, Patchset 3:class MockFileStream : public FileStream {

Tsuyoshi Horo . resolved

It seems that the MockFileStream class is no longer being used. Could you please delete net/base/mock_file_stream.h and net/base/mock_file_stream.cc? Doing this in a follow-up CL after this one lands is fine with me.

Helmut Januschka

removed them, splitting is more pain than gain in that case i guess!

Open in Gerrit

Related details

Attention is currently required from:

• Dan Harrington
• Emilia Paz
• Tsuyoshi Horo

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0

Gerrit-Change-Number: 7552938

Gerrit-PatchSet: 4

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Attention: Dan Harrington <harri...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Feb 2026 21:31:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Tsuyoshi Horo <ho...@chromium.org>

[Tsuyoshi Horo (Gerrit)]

Attention needed from Dan Harrington, Emilia Paz and Helmut Januschka

Tsuyoshi Horo voted and added 1 comment

Votes added by Tsuyoshi Horo

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Tsuyoshi Horo . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Dan Harrington
• Emilia Paz
• Helmut Januschka

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I950d97a6cb8a27dcb039749d26f5595d131feeb0

Gerrit-Change-Number: 7552938

Gerrit-PatchSet: 5

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Dan Harrington <harri...@chromium.org>

Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Emilia Paz <emil...@chromium.org>

Gerrit-Attention: Dan Harrington <harri...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 03:14:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes