[iOS][CPE] Remove expired and obsolete histograms [chromium/src : main]
0 views
Skip to first unread message
Rafał Godlewski (Gerrit)
Mar 11, 2026, 10:54:34 AM (yesterday) Mar 11
to Alexis Hétu, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Alexis Hétu
Rafał Godlewski voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
Mar 11, 2026, 10:55:32 AM (yesterday) Mar 11
to Rafał Godlewski, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Rafał Godlewski
Alexis Hétu voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
Mar 11, 2026, 11:02:22 AM (yesterday) Mar 11
to Mark Cogan, Alexis Hétu, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Alexis Hétu and Mark Cogan
Rafał Godlewski voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexis Hétu
- Mark Cogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
Mar 11, 2026, 11:34:42 AM (yesterday) Mar 11
to Sebastien S-G, Mark Cogan, Alexis Hétu, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Alexis Hétu, Mark Cogan and Sebastien S-G
Rafał Godlewski added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Alexis Hétu
- Mark Cogan
- Sebastien S-G
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sebastien S-G (Gerrit)
Mar 11, 2026, 12:04:16 PM (yesterday) Mar 11
to Rafał Godlewski, Mark Cogan, Alexis Hétu, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Alexis Hétu, Mark Cogan and Rafał Godlewski
Sebastien S-G voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alexis Hétu
- Mark Cogan
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
5:19 AM (7 hours ago) 5:19 AM
to Rafał Godlewski, Sebastien S-G, Alexis Hétu, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Attention needed from Rafał Godlewski
Gauthier Ambard voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:39 AM (7 hours ago) 5:39 AM
to Rafał Godlewski, Gauthier Ambard, Sebastien S-G, Alexis Hétu, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, rkgibso...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS][CPE] Remove expired and obsolete histograms
Removes subset of expired CPE histograms that I deem not very useful for
any analysis:
* logging that a field in credentials details view was copied
* logging the count of searches made in credential list
* logging the count of reauths (without breakdown on whether
it was for passkeys, passwords, result, passcode set etc.)
* inaccurate "display" count (was only logged when credential
list was displayed and CPE generally can be displayed in different
scenarios; also, the important actions from the list are logged ->
password / passkey used)
Useful histograms will be revived in a follow-up CL.
Bug: 40875924,428705368,374763682
Fixed: 40875921,397217742,430047954
Change-Id: Ie027c53c600c23367904b833fc0f8fa222fc0cc1
Reviewed-by: Sebastien S-G <se...@chromium.org>
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Commit-Queue: Rafał Godlewski <rg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1598295}
Files:
- M ios/chrome/app/application_delegate/metrics_mediator.mm
- M ios/chrome/common/app_group/app_group_metrics.h
- M ios/chrome/common/app_group/app_group_metrics.mm
- M ios/chrome/credential_provider_extension/credential_provider_view_controller.mm
- M ios/chrome/credential_provider_extension/ui/credential_details_view_controller.mm
- M ios/chrome/credential_provider_extension/ui/credential_list_view_controller.mm
- M tools/metrics/histograms/metadata/ios/histograms.xml
Change size: M
Delta: 7 files changed, 0 insertions(+), 200 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard, +1 by Sebastien S-G
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages