Use SearchboxContextData::Context to propagate model mode [chromium/src : main]

0 views
Skip to first unread message

Josiah Kiehl (Gerrit)

unread,
Mar 27, 2026, 5:54:42 PM (6 days ago) Mar 27
to Code Review Nudger, Duncan Mercer, Chromium IPC Reviews, Will Harris, Nihar Majmudar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org

Josiah Kiehl added 1 comment

Patchset-level comments
File-level comment, Patchset 27 (Latest):
Josiah Kiehl . resolved

Hi friends, I finally got a moment to revive this CL. Please re-review in its rebased, fixed up state and lmk what can be improved. Ty!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id009fb4df636131bb94f4b6ce2929f4863348189
Gerrit-Change-Number: 7675147
Gerrit-PatchSet: 27
Gerrit-Owner: Josiah Kiehl <ki...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
Gerrit-Reviewer: Nihar Majmudar <nih...@google.com>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Comment-Date: Fri, 27 Mar 2026 21:54:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Mar 27, 2026, 5:56:05 PM (6 days ago) Mar 27
to Josiah Kiehl, Chromium IPC Reviews, Will Harris, Code Review Nudger, Duncan Mercer, Nihar Majmudar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
Attention needed from Duncan Mercer, Nihar Majmudar and Will Harris

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: w...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): w...@chromium.org


Reviewer source(s):
w...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
  • Nihar Majmudar
  • Will Harris
Gerrit-Attention: Nihar Majmudar <nih...@google.com>
Gerrit-Attention: Duncan Mercer <mer...@google.com>
Gerrit-Attention: Will Harris <w...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Mar 2026 21:55:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Will Harris (Gerrit)

unread,
Mar 27, 2026, 7:52:16 PM (6 days ago) Mar 27
to Josiah Kiehl, Chromium IPC Reviews, Will Harris, Code Review Nudger, Duncan Mercer, Nihar Majmudar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
Attention needed from Duncan Mercer, Josiah Kiehl and Nihar Majmudar

Will Harris added 1 comment

Patchset-level comments
Will Harris . unresolved

this seems fine from security of mojom perspective but please come back when you have other owners lgtm and bots passing, and I will rs lgtm the mojom (in case it changes).

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
  • Josiah Kiehl
  • Nihar Majmudar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id009fb4df636131bb94f4b6ce2929f4863348189
    Gerrit-Change-Number: 7675147
    Gerrit-PatchSet: 27
    Gerrit-Owner: Josiah Kiehl <ki...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
    Gerrit-Reviewer: Nihar Majmudar <nih...@google.com>
    Gerrit-Reviewer: Will Harris <w...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Nihar Majmudar <nih...@google.com>
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Attention: Josiah Kiehl <ki...@google.com>
    Gerrit-Comment-Date: Fri, 27 Mar 2026 23:52:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Duncan Mercer (Gerrit)

    unread,
    Mar 31, 2026, 2:20:00 PM (2 days ago) Mar 31
    to Josiah Kiehl, Chromium IPC Reviews, Will Harris, Code Review Nudger, Nihar Majmudar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
    Attention needed from Josiah Kiehl and Nihar Majmudar

    Duncan Mercer voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Josiah Kiehl
    • Nihar Majmudar
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id009fb4df636131bb94f4b6ce2929f4863348189
      Gerrit-Change-Number: 7675147
      Gerrit-PatchSet: 28
      Gerrit-Owner: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
      Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Nihar Majmudar <nih...@google.com>
      Gerrit-Reviewer: Will Harris <w...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-Attention: Nihar Majmudar <nih...@google.com>
      Gerrit-Attention: Josiah Kiehl <ki...@google.com>
      Gerrit-Comment-Date: Tue, 31 Mar 2026 18:19:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nihar Majmudar (Gerrit)

      unread,
      1:20 PM (2 hours ago) 1:20 PM
      to Josiah Kiehl, Duncan Mercer, Chromium IPC Reviews, Will Harris, Code Review Nudger, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
      Attention needed from Josiah Kiehl

      Nihar Majmudar voted and added 1 comment

      Votes added by Nihar Majmudar

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 28 (Latest):
      Nihar Majmudar . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Josiah Kiehl
      Gerrit-Attention: Josiah Kiehl <ki...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 17:19:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nihar Majmudar (Gerrit)

      unread,
      1:21 PM (2 hours ago) 1:21 PM
      to Josiah Kiehl, Wenhu Cheng, Duncan Mercer, Chromium IPC Reviews, Will Harris, Code Review Nudger, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
      Attention needed from Josiah Kiehl and Wenhu Cheng

      Nihar Majmudar added 1 comment

      File chrome/browser/ui/omnibox/omnibox_context_menu_controller.cc
      Line 913, Patchset 28 (Latest): UpdateSearchboxContext(
      /*tab_info=*/std::nullopt,
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Josiah Kiehl
      • Wenhu Cheng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id009fb4df636131bb94f4b6ce2929f4863348189
      Gerrit-Change-Number: 7675147
      Gerrit-PatchSet: 28
      Gerrit-Owner: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
      Gerrit-Reviewer: Josiah Kiehl <ki...@google.com>
      Gerrit-Reviewer: Nihar Majmudar <nih...@google.com>
      Gerrit-Reviewer: Will Harris <w...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Sophie Chang <sophi...@chromium.org>
      Gerrit-CC: Wenhu Cheng <wen...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Wenhu Cheng <wen...@google.com>
      Gerrit-Attention: Josiah Kiehl <ki...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 17:21:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Wenhu Cheng (Gerrit)

      unread,
      1:46 PM (1 hour ago) 1:46 PM
      to Josiah Kiehl, Nihar Majmudar, Duncan Mercer, Chromium IPC Reviews, Will Harris, Code Review Nudger, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, jmedle...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org, asvitki...@chromium.org, ntp-dev...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, ananyasee...@google.com, christia...@chromium.org, ipc-securi...@chromium.org, jdonnel...@chromium.org, niharm...@google.com, omnibox-...@chromium.org, oshima...@chromium.org
      Attention needed from Josiah Kiehl

      Wenhu Cheng added 1 comment

      File chrome/browser/ui/omnibox/omnibox_context_menu_controller.cc
      Line 913, Patchset 28 (Latest): UpdateSearchboxContext(
      /*tab_info=*/std::nullopt,
      Wenhu Cheng

      yeah, my previous change actually replaced the UpdateSearchboxContext with composebox_handler->SetActiveToolMode, but are we trying to delete that change now?
      https://chromium-review.googlesource.com/c/chromium/src/+/7694822

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Josiah Kiehl
      Gerrit-Attention: Josiah Kiehl <ki...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 17:46:18 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Nihar Majmudar <nih...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages