Migrate LaunchResult::State into LaunchResult. [chromium/src : main]

0 views

Skip to first unread message

Hidehiko Abe (Gerrit)

unread,

6:12 AM (6 hours ago) 6:12 AM

to Jun Ishiguro, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, aixba+wat...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Jun Ishiguro

Hidehiko Abe added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hidehiko Abe . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Jun Ishiguro

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jun Ishiguro (Gerrit)

unread,

6:31 AM (6 hours ago) 6:31 AM

to Hidehiko Abe, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, aixba+wat...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, cros-essential...@chromium.org, crost...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, japhet+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, oshima...@chromium.org, philli...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, webap...@microsoft.com, zelin+watch-we...@chromium.org

Attention needed from Hidehiko Abe

Jun Ishiguro voted and added 4 comments

Votes added by Jun Ishiguro

Code-Review

4 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jun Ishiguro . resolved

LGTM with nits

File chrome/browser/apps/app_service/app_service_proxy_ash.cc

Line 633, Patchset 1 (Latest): std::move(callback).Run(std::move(launch_result));

Jun Ishiguro . unresolved

nit: also remove std::move?

File chrome/browser/apps/app_service/app_service_proxy_base.cc

Line 678, Patchset 1 (Latest): std::move(callback).Run(std::move(launch_result));

Jun Ishiguro . unresolved

nit: ditto.

File chrome/browser/web_applications/app_service/web_apps.cc

Line 148, Patchset 1 (Latest): std::move(callback).Run(apps::LaunchResult(result));

Jun Ishiguro . unresolved

nit: remove?

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages