EICP: ExtensionService::CheckManagementPolicy() when policy changes [chromium/src : main]

0 views

Skip to first unread message

Nicolas Ouellet-Payeur (Gerrit)

unread,

Jan 30, 2026, 4:12:49 PM (8 hours ago) Jan 30

to Devlin Cronin, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Devlin Cronin

Nicolas Ouellet-Payeur added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Nicolas Ouellet-Payeur . resolved

rdevlin.cronin@, PTAL

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Devlin Cronin (Gerrit)

unread,

Jan 30, 2026, 5:04:36 PM (7 hours ago) Jan 30

to Nicolas Ouellet-Payeur, Devlin Cronin, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Nicolas Ouellet-Payeur

Devlin Cronin voted and added 3 comments

Votes added by Devlin Cronin

Code-Review

3 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Devlin Cronin . resolved

LGTM; thanks, Nicolas!

File chrome/browser/extensions/extension_service.cc

Line 257, Patchset 5 (Latest): profile_)) {

Devlin Cronin . unresolved

When can this be null?

Line 258, Patchset 5 (Latest): extension_install_policy_observation_.Observe(

Devlin Cronin . unresolved

Do we need to do anything to guarantee ExtensionInstallPolicyServiceFactory outlives ExtensionService? Otherwise, the ScopedObservation here would have a UAF when ExtensionService destructs.

(If this is already guaranteed, mind adding a comment about how?)