[json-schema-compiler] Support absl::optional for function fields [chromium/src : main]
1 view
Skip to first unread message
Claudio DeSouza (Gerrit)
Sep 11, 2022, 11:28:00 PM9/11/22
to Devlin Cronin, abigailbk...@google.com, anthony...@chormium.org, azeemarshad+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, dmurph+wat...@chromium.org, dominickn+...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gordonseto+w...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, mfoltz...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sarakat...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org
Attention is currently required from: Devlin Cronin.
Claudio DeSouza would like Devlin Cronin to review this change.
[json-schema-compiler] Support absl::optional for function fields
This CL follows up on work to replace the use of std::unique_ptr<T> as
the stand in optional type with absl::optional.
Bug: 1354063
Change-Id: I86495e579ffc6080b8aba09c6c6987c42bc343c1
---
M chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
M tools/json_schema_compiler/cc_generator.py
M tools/json_schema_compiler/cpp_util.py
M tools/json_schema_compiler/test/functions_as_parameters_unittest.cc
4 files changed, 20 insertions(+), 7 deletions(-)
To view, visit change 3889059. To unsubscribe, or for help writing mail filters, visit settings.
Devlin Cronin (Gerrit)
Sep 14, 2022, 9:35:41 PM9/14/22
to Claudio DeSouza, abigailbk...@google.com, anthony...@chormium.org, azeemarshad+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, dmurph+wat...@chromium.org, dominickn+...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gordonseto+w...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, mfoltz...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sarakat...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Kevin McNee, Peter Beverloo, James Maclean
Attention is currently required from: Claudio DeSouza.
Patch set 3:Code-Review +1
1 comment:
Patchset:
LGTM!
To view, visit change 3889059. To unsubscribe, or for help writing mail filters, visit settings.
Claudio DeSouza (Gerrit)
Sep 15, 2022, 5:35:11 PM9/15/22
to abigailbk...@google.com, anthony...@chormium.org, azeemarshad+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, dmurph+wat...@chromium.org, dominickn+...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gordonseto+w...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, mfoltz...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sarakat...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Kevin McNee, Peter Beverloo, James Maclean
Attention is currently required from: Claudio DeSouza.
Patch set 7:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Sep 15, 2022, 5:40:50 PM9/15/22
to Claudio DeSouza, abigailbk...@google.com, anthony...@chormium.org, azeemarshad+...@chromium.org, chadduffin+w...@chromium.org, chromium-a...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, dmurph+wat...@chromium.org, dominickn+...@chromium.org, dtseng...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, gordonseto+w...@google.com, hirokisa...@chromium.org, hsuregan+wa...@chromium.org, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, mfoltz...@chromium.org, mtomas...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, sarakat...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yuzo+...@chromium.org, Devlin Cronin, Akihiro Ota, chromium...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kevin Babbitt, Kevin McNee, Peter Beverloo, James Maclean
Chromium LUCI CQ submitted this change.
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Approvals:
Devlin Cronin: Looks good to me
Claudio DeSouza: Commit
[json-schema-compiler] Support absl::optional for function fields
This CL follows up on work to replace the use of std::unique_ptr<T> as
the stand in optional type with absl::optional.
Bug: 1354063
Change-Id: I86495e579ffc6080b8aba09c6c6987c42bc343c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3889059
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Commit-Queue: Claudio DeSouza <cdes...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1047691}
---
M chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h
M tools/json_schema_compiler/cc_generator.py
M tools/json_schema_compiler/cpp_util.py
M tools/json_schema_compiler/test/functions_as_parameters_unittest.cc
4 files changed, 24 insertions(+), 7 deletions(-)
Reply all
Reply to author
Forward
0 new messages